From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Fri, 15 Sep 2023 15:12:16 +0800 Message-ID: <87ttrvzz8v.fsf@yahoo.com> References: <87ttsomgb5.fsf@mssdvd.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> <87il8oodrm.fsf@mssdvd.com> <87il8ncruu.fsf@mssdvd.com> <83wmx2z8w1.fsf@gnu.org> <87cyyufi5k.fsf@yahoo.com> <87fs3omzqg.fsf@mssdvd.com> <83wmwrkjbn.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Davide Masserut , stefankangas@gmail.com, 65509@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 09:13:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh30r-0003HF-0X for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 09:13:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh30f-0003EK-C7; Fri, 15 Sep 2023 03:13:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh30a-0003BW-Va for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:12:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh30a-0003QK-9R for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:12:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh30g-0006TU-Gw for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 07:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65509-submit@debbugs.gnu.org id=B65509.169476196324858 (code B ref 65509); Fri, 15 Sep 2023 07:13:02 +0000 Original-Received: (at 65509) by debbugs.gnu.org; 15 Sep 2023 07:12:43 +0000 Original-Received: from localhost ([127.0.0.1]:41934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh30N-0006Ss-9s for submit@debbugs.gnu.org; Fri, 15 Sep 2023 03:12:43 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:40618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh30K-0006Sd-R7 for 65509@debbugs.gnu.org; Fri, 15 Sep 2023 03:12:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694761949; bh=erV4yOaUlGr7ojmovV3Wzt/EN94/wW98rS7/wjZUmN0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=YukVnbuKJIPUdMgRHCPUHU4Cxl0RyO3UDnvf1hOA+QLiqjM1Lvx0yThG9qRjko88D+nuYBRT3FvZUVq3Nc1g0dnFUr45tAP8I5KZJkoLLkr4CTwqdd2i9nGjVpssZqWVfi1i0zAlQMUqr8uUv1/AyE9ogFTiONnNYKhedXsrqJ29bCIB4rOhkg28lQ+8+YGLJ5Il6mmDU5TRaMV66I2YysZYbvjAApvP/z548s5FDIy+C2hqJlN+kk/uoUgAyyhpyaCXfRhBrfw6PMlx9vz7jbEWIv37lqN6AkAXkKrQWLz2pwYi3RGHBoV0QCtrg4Fh6bB+LJ5GS6Kr9rS4+sK5Dg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694761949; bh=3P+CPGNOr3zv0wG1Mq6MOZwvFhCD24aZSf0qJf3TIvZ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jpLRqu20eFuTTA2bu16UUNkjzN/kSM/3MbDqIFt70Tv6mVF52CEBkrmjL0fJ1Yw5GMsCjRHWqrCfgu48jngzV0WuXm/PNxQ9Lo5aQkRM0BxSaJmdu3L4wJuYgxaD7E8Zd48Jbmt9sjou/7Qdwu4Kno5QgqptmfZiJusgqq+liIj7OPD0pSM35xZybY/Tb5ggqYc/x+/ZOgfzWelK3+rU1tyv0ysx8XgtTNWKdeMuZA0l5qKK9zgmhjfgU6RLQWWpefK7e7wypIycyxycgOk4BNIBjlceuTZ80QsLxIcUgpsKpM7wD33xsxpIwqsU60/4vZq/HUtXWwjPYM47Sv6eCw== X-YMail-OSG: IiNWO0IVM1mqarM1ZGdaiI5zJDnLvtrShclCyVLJoQxAYsbMm3D9iZEG3jVCh7s JS6YSPlPYOLQ7GRKRFeHQ.D7ZHH1jC5yNixxixxzMGcqGJJFrGbZejSZ_4_2.6lVe_0OrZBldh_r lVnGdbfegC4mJbMCUBBDHaYVbS50DhHbQ6512f9V4rr4QIk3Zf4Hdeo4IU2csLGF_p__HJPf4vJk 0BWg3ZqU.IzWI0P_zwmRSYY7XzsdYm6Ys4yVtXIDmA4mNL3h5Vt0lYrF3DI5HEN4K3x7oOfXmPND BujA_V9K2ddcyzXCUNU1oGmP_gfubndQKrA5HuVXFEmuOZAA53UeYldsh5a_G.ujfw18oULOq2ee DBoxJQp9dveST3xPUFYWrGL0dnpMFv8EjgXav2w6ADhBSPkfUyWRB6DJPC5xM6nmhcqDW_KWNJoX r2lb_yY7DyJGEMlyf9rotPaJYknMSmM8VU7TOCy5s7LvnQqq.MXj8EY_AbFbiEoWLuJBsH2638KG RDW0Hsqwd9Ne9kFuiHHti1fNP_ry7musDqFp8KNDyv1Fc8XG3Ff15SZ9rd_M.oaK1S7UXM4zUxhq sYSMrErJ2H9eSrzqxZLXKHzz5hJYNeRMJp7Zv6yGU6UeE3KZszOzNGTsT1M8NPjPWhhk6qRmpOZA E5DfItWxv6zgp64wlqti1IXNAv.8JyoLknLU4ZJgXsAypqxuny1OxPkKDhzWigLGH_EPL_b5uNRK adT3TxP8l7GyZNtkvAprAqwMlDNOB5NvgAwz.Jsiz54a4UulWPGx9Yx4x0p20tfBtTYrTH8uT9QQ gnS9hZqJM8QueJBSMKqo8ASuAi7dR6UV6.EgW4yP8X X-Sonic-MF: X-Sonic-ID: 87430058-25ce-4d4a-8170-7a2021ce9dbd Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Fri, 15 Sep 2023 07:12:29 +0000 Original-Received: by hermes--production-sg3-55c667b499-gg78d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 046767a2ce5402beb943616d2735f645; Fri, 15 Sep 2023 07:12:22 +0000 (UTC) In-Reply-To: <83wmwrkjbn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Sep 2023 10:05:16 +0300") X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270502 Archived-At: Eli Zaretskii writes: > Ping! Po Lu, could you please respond? > >> From: Davide Masserut >> Cc: stefankangas@gmail.com, 65509@debbugs.gnu.org >> Date: Fri, 08 Sep 2023 17:49:43 +0200 >> >> >> Po Lu writes: >> >> > Eli Zaretskii writes: >> > >> >>> From: Davide Masserut >> >>> Cc: Stefan Kangas , Eli Zaretskii , >> >>> 65509@debbugs.gnu.org >> >>> Date: Wed, 06 Sep 2023 16:01:58 +0200 >> >>> >> >>> It turns out that Emacs 29 has new CLI option that solves exactly these problems. >> >>> >> >>> The attached patch replaces the usage of --display=$DISPLAY with --reuse-frame. >> >> >> >> Po Lu, any objections to installing this on emacs-29? >> > >> > Yes. Davide, would you please rewrite the patch so that your change is >> > only applied to the PGTK port? >> >> Done. Po, why can't we use --reuse-frame in X builds? >> >> >> >From 43085522a08b94ef594bd270d61a38d7bb26e036 Mon Sep 17 00:00:00 2001 >> From: Davide Masserut >> Date: Thu, 24 Aug 2023 18:33:39 +0200 >> Subject: [PATCH] Avoid using --display to reuse frames in PGTK >> >> Using hard-coded display values can cause PGTK graphical frames to >> open using the wrong backend or not open at all. >> >> * Makefile.in (install-etc): Use --reuse-frame instead of >> --display=$DISPLAY. >> --- >> Makefile.in | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Makefile.in b/Makefile.in >> index fdd9353e254..c82aad1af60 100644 >> --- a/Makefile.in >> +++ b/Makefile.in >> @@ -843,6 +843,9 @@ EMACS_ICON= >> ifeq (${USE_STARTUP_NOTIFICATION},no) >> USE_STARTUP_NOTIFICATION_SED_CMD=-e "/^StartupNotify=true$$/d" >> endif >> +ifeq ($(HAVE_PGTK),yes) >> +USE_WAYLAND_DISPLAY_SED_CMD=-e "s/display=[^ ]*/reuse-frame/" >> +endif >> install-etc: >> umask 022; ${MKDIR_P} "$(DESTDIR)${desktopdir}" >> tmp=etc/emacs.tmpdesktop; rm -f $${tmp}; \ >> @@ -857,6 +860,7 @@ install-etc: >> sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ >> -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ >> $(USE_STARTUP_NOTIFICATION_SED_CMD) \ >> + $(USE_WAYLAND_DISPLAY_SED_CMD) \ >> ${srcdir}/etc/emacsclient.desktop > $${tmp}; \ >> ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \ >> rm -f $${tmp} >> @@ -870,6 +874,7 @@ install-etc: >> client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ >> sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ >> -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ >> + $(USE_WAYLAND_DISPLAY_SED_CMD) \ >> ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \ >> ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \ >> rm -f $${tmp} >> -- >> 2.42.0 >> That was lost in the spam filter. I'd rather not use --reuse-frame under the X build, because that's not safe for Emacs 29. This LGTM now.