unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Dan McCarthy <daniel.c.mccarthy@gmail.com>
Cc: 66123@debbugs.gnu.org
Subject: bug#66123: 29.1; tar-mode errors when saving remote files
Date: Wed, 20 Sep 2023 20:36:54 +0200	[thread overview]
Message-ID: <87ttro7ku1.fsf@gmx.de> (raw)
In-Reply-To: <CAAoRiOXTJSv8V2ET05zxmcZjf2qy2y3fz0Vjit_TZU1FtYBa+A@mail.gmail.com> (Dan McCarthy's message of "Wed, 20 Sep 2023 11:32:04 -0400")

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

Dan McCarthy <daniel.c.mccarthy@gmail.com> writes:

Hi Dan,

> The setup is the same as bug#55166:
>
> /ssh:dan@solstice:/tmp/ #$ touch a b c
> /ssh:dan@solstice:/tmp/ #$ tar cf test.tar a b c
> /ssh:dan@solstice:/tmp/ #$ xz test.tar
>
> but in this case write-file throws an error instead of failing
> silently:
>
> Debugger entered--Lisp error: (wrong-type-argument "listp
> (tramp-file-name-handler tramp-crypt-file-name-handler .
> inhibit-file-name-handlers)")
>   signal(wrong-type-argument ("listp (tramp-file-name-handler
> tramp-crypt-file-name-handler . inhibit-file-name-handlers)"))

Oops, a comma is missing. Could you pls try the appended patch? Note
that, due to macro expansion, you must recompile lisp/net/tramp.el first
and then lisp/net/tramp-sh.el afterwards.

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 523 bytes --]

diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 502ededcfb7..8ace0165ed9 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -3734,7 +3734,7 @@ tramp-skeleton-write-region
 			(let ((inhibit-file-name-handlers
 			       `(tramp-file-name-handler
 				 tramp-crypt-file-name-handler
-				 . inhibit-file-name-handlers))
+				 . ,inhibit-file-name-handlers))
 			      (inhibit-file-name-operation 'write-region))
 			  (find-file-name-handler ,visit 'write-region))))
 	  ;; We use this to save the value of

  reply	other threads:[~2023-09-20 18:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 15:32 bug#66123: 29.1; tar-mode errors when saving remote files Dan McCarthy
2023-09-20 18:36 ` Michael Albinus [this message]
2023-09-20 19:34   ` Dan McCarthy
2023-09-21  7:25     ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttro7ku1.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=66123@debbugs.gnu.org \
    --cc=daniel.c.mccarthy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).