unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 66636@debbugs.gnu.org
Subject: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler
Date: Fri, 20 Oct 2023 14:09:45 +0800	[thread overview]
Message-ID: <87ttql4yfq.fsf@yahoo.com> (raw)
In-Reply-To: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> ("Mattias Engdegård"'s message of "Thu, 19 Oct 2023 13:48:21 +0200")

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

> The warning about a missing lexical-binding cookie rather belongs in
> the compiler than checkdoc, because it's not about documentation or
> style but code generation and ability to detect errors, both which are
> hindered by a missing cookie.
>
> Moving the warning to the compiler also makes it more widely seen.

So long as this warning is only displayed within code part of Emacs
itself, there are no valid objections to such a change.

But you have instead elected to generate warnings whenever such files
are byte-compiled.  There exist many packages which do not enable
lexical binding, whose authors have studiously elected not to: most of
Drew Adams' for example.  So this is tantamount to punitive action
against their users, in the form of an unsightly warning each time such
packages are installed.





  parent reply	other threads:[~2023-10-20  6:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 11:48 bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Mattias Engdegård
2023-10-19 11:55 ` Eli Zaretskii
2023-10-19 14:12   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-19 17:40 ` Stefan Kangas
2023-10-20 10:15   ` Mattias Engdegård
2023-10-20 20:55     ` Stefan Kangas
2023-10-20  6:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-20  7:01   ` Eli Zaretskii
2023-10-20  7:13     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20  7:21       ` Eli Zaretskii
2023-10-20 19:44         ` Stefan Kangas
2023-10-20 13:38   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20 17:40     ` Mattias Engdegård
2023-10-20 19:27       ` Eli Zaretskii
2023-10-21  9:53         ` Mattias Engdegård
2023-10-21 11:17           ` Eli Zaretskii
2023-10-21 13:17             ` Mattias Engdegård
2023-10-21 14:42             ` Drew Adams
2023-10-21 15:44             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 16:08               ` Eli Zaretskii
2023-10-22  0:15               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22  4:12                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22  5:16                   ` Eli Zaretskii
2023-10-22  5:28                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20 16:27   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttql4yfq.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=66636@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).