From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Philip Kaludercic <philipk@posteo.net>
Newsgroups: gmane.emacs.bugs
Subject: bug#68678: 29.1; package-recompile-all should skip system packages in
 package-directory-list
Date: Sun, 28 Jan 2024 21:40:28 +0000
Message-ID: <87ttmx16ib.fsf@posteo.net>
References: <CADbSrJyYvAiO-dmFK-uhp39gwubf5SzDeP1TtrLEOvZc3SgLLQ@mail.gmail.com>
 <87jznyfkas.fsf@posteo.net>
 <CADbSrJyPvX-w8tq=zKXAcR7PyKjVcFkrhn=EaLihf_XtDtNqiQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="1465"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: 68678@debbugs.gnu.org
To: Allen Li <darkfeline@felesatra.moe>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 28 22:41:16 2024
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1rUCtw-0000EU-A9
	for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jan 2024 22:41:16 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1rUCtg-0006LM-25; Sun, 28 Jan 2024 16:41:00 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rUCtb-0006L3-Ro
 for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 16:40:56 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rUCtZ-00085p-Te
 for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 16:40:55 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rUCth-0001u1-OW
 for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 16:41:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Philip Kaludercic <philipk@posteo.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Sun, 28 Jan 2024 21:41:01 +0000
Resent-Message-ID: <handler.68678.B68678.17064780477280@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 68678
X-GNU-PR-Package: emacs
Original-Received: via spool by 68678-submit@debbugs.gnu.org id=B68678.17064780477280
 (code B ref 68678); Sun, 28 Jan 2024 21:41:01 +0000
Original-Received: (at 68678) by debbugs.gnu.org; 28 Jan 2024 21:40:47 +0000
Original-Received: from localhost ([127.0.0.1]:58478 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1rUCtS-0001tM-TT
 for submit@debbugs.gnu.org; Sun, 28 Jan 2024 16:40:47 -0500
Original-Received: from mout02.posteo.de ([185.67.36.66]:37163)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@posteo.net>) id 1rUCtP-0001t8-RP
 for 68678@debbugs.gnu.org; Sun, 28 Jan 2024 16:40:45 -0500
Original-Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 7CABB240101
 for <68678@debbugs.gnu.org>; Sun, 28 Jan 2024 22:40:29 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1706478029; bh=hdPiqucHL7868BOjWzwm8j6nKYQTypCGEYRgu0YPhAU=;
 h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:Content-Transfer-Encoding:From;
 b=Gpscxu+zvEzUqC2jMeC+DQ+RtsoOQRXfshH1nMwdBAH6y2pl0jRNf/qGiclwPMTfy
 rqjjeQUvEbPKtDYwH/4RA7s/knHsp/VDzcSMzxqOSTIreaoRyygg9087RnaoJZ7tx5
 Vr7bvMJi2IEiFIDwqBxiX+ASHngdoUXYp9wHLfEaDFLdHjgaP2kMmCl0F2NOA2gOWR
 6KUKUnO8lUwcvUnmI/B49KQv9LLtH3qt/GUKjPRKTf/Glk5mCvy1b89WyurV1VCb17
 2bX4IUBIE83Xnm8057xUaRG9sZ4wDfqvXx8BL75BUNJbQaBLHy8tLyuyr8oBOUg2Fj
 yuIbH6qv2rOLg==
Original-Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4TNPx85XwPz6tvk;
 Sun, 28 Jan 2024 22:40:28 +0100 (CET)
In-Reply-To: <CADbSrJyPvX-w8tq=zKXAcR7PyKjVcFkrhn=EaLihf_XtDtNqiQ@mail.gmail.com>
 (Allen Li's message of "Thu, 25 Jan 2024 14:58:36 -0800")
Autocrypt: addr=philipk@posteo.net; keydata=
 mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
 BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
 BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
 Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
 NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
 z4oM
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:279110
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/279110>

Allen Li <darkfeline@felesatra.moe> writes:

> On Wed, Jan 24, 2024 at 2:17=E2=80=AFPM Philip Kaludercic <philipk@posteo=
.net> wrote:
>>
>> Would this patch resolve the issue for you:
>>
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> index 868373f46c2..fe7b10f569a 100644
>> --- a/lisp/emacs-lisp/package.el
>> +++ b/lisp/emacs-lisp/package.el
>> @@ -2610,7 +2610,8 @@ package-recompile-all
>>  are invalid due to changed byte-code, macros or the like."
>>    (interactive)
>>    (pcase-dolist (`(_ ,pkg-desc) package-alist)
>> -    (package-recompile pkg-desc)))
>> +    (with-demoted-errors "Error while recompiling: %S"
>> +      (package-recompile pkg-desc))))
>>
>>  ;;;###autoload
>>  (defun package-autoremove ()
>
> That works for me, though it's possible that someone may want errors
> recompiling user packages surfaced directly.

That is why I used `with-demoted-errors', which propagates errors if
`debug-on-error' is non-nil.  Or do you mean permanently and
specifically related to this issue, e.g. in form of a user option.