From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69084: 30; check-declare-directory chokes on lock files Date: Mon, 12 Feb 2024 20:26:57 +0100 Message-ID: <87ttmd32m6.fsf@bernoul.li> Reply-To: Jonas Bernoulli Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32691"; mail-complaints-to="usenet@ciao.gmane.io" To: 69084@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 12 20:56:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZcPR-0008Fu-II for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Feb 2024 20:56:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZcP6-0003Wz-Rd; Mon, 12 Feb 2024 14:55:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZcP4-0003Wr-WF for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:55:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZcP4-0002mG-NB for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:55:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZcPL-0006iG-2b for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:56:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69084 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170776772325570 (code B ref -1); Mon, 12 Feb 2024 19:56:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 19:55:23 +0000 Original-Received: from localhost ([127.0.0.1]:53928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZcOf-0006eI-RY for submit@debbugs.gnu.org; Mon, 12 Feb 2024 14:55:22 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:54190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZbxq-0004Rr-I0 for submit@debbugs.gnu.org; Mon, 12 Feb 2024 14:27:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZbxP-00026w-SL for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:27:12 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZbxM-0005w6-5v for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 14:27:11 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id E3B4E162D7 for ; Mon, 12 Feb 2024 20:27:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:from:from; s=sel2011a; t=1707766020; bh=n3ZAzWz qu6oRIvOFngHMMulZMrtUf4hCOdQnfMRpC00=; b=dJn47OYhpNjhPSxCfgo/h3g XZVOEL3zGoArXmHTgtZzdafI3LluUW3OM5wV0NDFxnID5PI04a1vW/Zhlh/z12CM 2VIfSx2sg291hREBiluFnD8kfs0tihWRvv5D73YuK0YHScGpQPshxGKqbm0c5WFv yxOonqgvqTJ3g5sWnADU= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id f0BABZsWACyd for ; Mon, 12 Feb 2024 20:27:00 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id B62BE162D5 for ; Mon, 12 Feb 2024 20:26:59 +0100 (CET) Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279922 Archived-At: `check-declare-directory' chokes on lock files for libraries: check-declare-scan: Opening input file: No such file or directory, /home/jonas/.config/emacs/lib/forge/lisp/.#forge-pullreq.el This simple change would take care of that: diff --git a/lisp/emacs-lisp/check-declare.el b/lisp/emacs-lisp/check-declare.el @@ -328,7 +328,7 @@ check-declare-directory (setq root (directory-file-name (file-relative-name root))) (or (file-directory-p root) (error "Directory `%s' not found" root)) - (let ((files (directory-files-recursively root "\\.el\\'"))) + (let ((files (directory-files-recursively root "\\`[^.].*\\.el\\'"))) (when files (apply #'check-declare-files files)))) I am not sure this is acceptable as it would also skip over other hidden files. IMO that would be okay; libraries arguably shouldn't be hidden files. Cheers, Jonas