From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.bugs Subject: bug#69815: [PATCH] Fix some CSS issues on elpa.gnu.org Date: Fri, 22 Mar 2024 07:55:08 -0500 Message-ID: <87ttkyh19l.fsf@pub.pink> References: <87sf0rpf9n.fsf@pub.pink> <87jzm19le0.fsf@posteo.net> <875xxkmfrg.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34236"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.8; emacs 30.0.50 Cc: 69815@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 22 14:11:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rnefg-0008ZN-3u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Mar 2024 14:10:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnefE-0004bC-IY; Fri, 22 Mar 2024 09:10:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnef8-0004an-VI for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2024 09:10:25 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rnef7-0007sW-PL for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2024 09:10:22 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rnefm-0004vN-9L for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2024 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69815-submit@debbugs.gnu.org id=B69815.171111301618779 (code B ref 69815); Fri, 22 Mar 2024 13:11:02 +0000 Original-Received: (at 69815) by debbugs.gnu.org; 22 Mar 2024 13:10:16 +0000 Original-Received: from localhost ([127.0.0.1]:51093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnef1-0004sh-Oe for submit@debbugs.gnu.org; Fri, 22 Mar 2024 09:10:16 -0400 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:41643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnebx-0004hy-VE for 69815@debbugs.gnu.org; Fri, 22 Mar 2024 09:07:08 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 255483200A17; Fri, 22 Mar 2024 08:58:01 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 22 Mar 2024 08:58:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1711112280; x=1711198680; bh=1HPhoWZ+hrvc1139vQh0mzYQBXfyknk81eRwHMV9/lg=; b= hYS4oNsiWvs2dQqzupzmJujDymKsH0AoB5OTydslbSBgYUGGWBqzxKjc5oTjuGqm j3p80A9MtU/akV7Llw5yc7Xj+FDtugyfpSInag5tzey4n4bT1hMcyGrwn/k8efP3 D5N2SCQ0EjOJc7T+X5xHS0xt3EhUwXkwv5KIQQ8vj4JldOp9Xt8s6gOcN5ACvu5p P2TnrcZ8ojo/Do7EUMLBGxQouROoRnk+8ICFe3jkhsgjOE4+2bi05lc3aBLuRRv7 KPQr3egEefccivUtEzdX5+ZCeRAvT7Ibqe59FgqDNmYhT7Z7Swh5RyVX+zPAd6mR iUt84PQWyfCHcjUPxe8Dsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711112280; x= 1711198680; bh=1HPhoWZ+hrvc1139vQh0mzYQBXfyknk81eRwHMV9/lg=; b=p 2sVfgFDpj7BgIZ3LuFlmUaY6YKtmoKQTOEhIWpMQK2OCBZAUfNwxUrQkcpQhFdR/ rl6eyHTU3P7MQZCjwc0yj74t0i30eouyOMaFzGKDavZ3KgD+dij4W3yN4r2L2ZXu YOiF4kPssueHWTqD65VJqNhtrZczY+DgDIj+LYE2d6gggn3hU9qg317e56BIxpgv TDEcrgzYUAgMYr3s3xedeCmDaETDVtlkZDxQ5oeAA7wL58UDieE6d01QorVX+RA5 biwpLJ7mLZsNUZyU9Vb83NdHVnpc3TiPKhMbij5+odtPQi91CU+wkdhwuUFrkC8z +EidcN1n+uwkS03WgrlhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddttddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpehjohhh nhcumhhuhhhluceojhhmsehpuhgsrdhpihhnkheqnecuggftrfgrthhtvghrnhepueeike dvudekjedutdffueffteekkeeikedvvefgieeivefhueetfedugfdtgeffnecuffhomhgr ihhnpehpnhhgrdhithdpghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinhhk X-ME-Proxy: Feedback-ID: i74194916:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Mar 2024 08:57:59 -0400 (EDT) In-reply-to: <875xxkmfrg.fsf@pub.pink> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281937 Archived-At: I looked into it some more and at least some of the invalid HTML is generated by Org=E2=80=99s HTML export but they don=E2=80=99t consider t= hat a bug so I guess quirks mode is here to stay and the DOCTYPE patch can be discarded. john muhl writes: > Philip Kaludercic writes: > >> john muhl writes: >> >>> Here are a few patches fixing some minor issues. The first one >>> makes the packages table always full-width and expands the footer >>> background so it contains all the footer text (see before.png). >>> >>> I noticed that with a very narrow view the CSS drops the rank >>> column to help fit but it doesn=E2=80=99t help quite enough to prevent >>> horizontal overflow (narrow.png). It seems to me that the version >>> column is the least important so the second patch changes the >>> narrow view to drop it instead of the rank (after.png). >>> >>> The last patch fixes the doctype for sub-pages. >> PUBLIC> is not a valid doctype and so triggers quirks mode. Not a >>> big deal but probably better avoided. >>> >>>>>From f13cc711f0bf368f9acb1ae579ab9e078aefce1e Mon Sep 17 00:00:00 2001 >>> From: john muhl >>> Date: Thu, 14 Mar 2024 13:22:52 -0500 >>> Subject: [PATCH] Fix some CSS issues >>> >>> * html/layout.css (footer): Remove fixed height so the background >>> expands to encompass all footer content. >>> (table): Make packages table always use full page width. >>> --- >>> html/layout.css | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/html/layout.css b/html/layout.css >>> index 7d3be41..9d04958 100644 >>> --- a/html/layout.css >>> +++ b/html/layout.css >>> @@ -1,4 +1,4 @@ >>> -l/* Copyright (C) 2010-2022, 2024 Free Software Foundation, Inc. >>> +/* Copyright (C) 2010-2022, 2024 Free Software Foundation, Inc. >>>=20=20 >>> This file is free software: you can redistribute it and/or modify >>> it under the terms of the GNU General Public License as published by >>> @@ -74,7 +74,7 @@ html, body { >>> height: 100%; >>> margin: 0 auto -50px; /* the bottom margin is the negative value of = the footer's height */ >>> } >>> -footer, .push, .footer { >>> +.push { >>> height: 90px; /* .push must be the same height as .footer */ >>> } >>>=20=20 >>> @@ -302,6 +302,10 @@ footer p, .footer p { >>> line-height: 1.4em; >>> } >>>=20=20 >>> +table { >>> + width: 100%; >>> +} >>> + >>> @media screen and (max-width: 999px) { >>> .container { >>> width: 600px; >>> @@ -313,10 +317,6 @@ footer p, .footer p { >>> font-size: 1em; >>> } >>>=20=20 >>> - table { >>> - width: 100%; >>> - } >>> -=20=20 >>> .container { >>> width: 90%; >>> padding: 40px 5%; >>> --=20 >>> 2.41.0 >> >> Looks good. >> >>> >>>>>From 5dafd0d3483336ff50b5039942bc35c41d30644f Mon Sep 17 00:00:00 2001 >>> From: john muhl >>> Date: Thu, 14 Mar 2024 13:46:54 -0500 >>> Subject: [PATCH] Show rank instead of version on narrow displays >>> >>> * html/layout.css (td): >>> (th): Hide version and right align rank column. >>> --- >>> html/layout.css | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/html/layout.css b/html/layout.css >>> index 9d04958..02dfb87 100644 >>> --- a/html/layout.css >>> +++ b/html/layout.css >>> @@ -283,6 +283,11 @@ td { >>> border-bottom: 1px solid #ddd; >>> } >>>=20=20 >>> +td:last-child, >>> +th:last-child { >>> + text-align: right; >>> +} >>> + >>> footer, .footer { >>> border-top: 1px solid #999; >>> text-align:center; >>> @@ -330,7 +335,7 @@ table { >>> width: 300px; >>> } >>>=20=20 >>> - td:last-child, th:last-child { >>> + td:nth-child(2), th:nth-child(2) { >>> display: none; >>> } >>>=20=20 >>> --=20 >>> 2.41.0 >> >> >> Why not show both, and allow scrolling horizontally (x-overflow: auto) >> if there is not enough space? >> >>> >>> >>>>>From 16547922cc9339e4f920ae62a1bee09c38625cbf Mon Sep 17 00:00:00 2001 >>> From: john muhl >>> Date: Thu, 14 Mar 2024 16:54:45 -0500 >>> Subject: [PATCH] * elpa-admin.el (elpaa--html-header): Fix DOCTYPE. >>> >>> --- >>> elpa-admin.el | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/elpa-admin.el b/elpa-admin.el >>> index d4a9dcf..9475336 100644 >>> --- a/elpa-admin.el >>> +++ b/elpa-admin.el >>> @@ -1544,7 +1544,7 @@ readme file has an unconventional name" >>> ;;; Make the HTML pages for online browsing. >>>=20=20 >>> (defun elpaa--html-header (title &optional header head-extra) >>> - (format " >>> + (format " >> >> What difference does this make? Or rather how is this related to the >> other patches? That should be explained in the commit message. > > It=E2=80=99s unrelated. I just included it since it looked like a mistake. > If those pages require quirks mode then a better fix would be get > rid of that requirement. Checking now I see that they serve > non-conforming HTML so perhaps we should fix that first.