From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#70036: 30.0.50; Move file-truename to the C level Date: Wed, 27 Mar 2024 21:12:21 +0100 Message-ID: <87ttkrqvru.fsf@betli.tmit.bme.hu> References: <87le63xzjt.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16061"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 70036@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 27 21:13:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpZeP-0003zy-R0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Mar 2024 21:13:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpZe1-00030o-6k; Wed, 27 Mar 2024 16:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpZdw-0002xC-Kq for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 16:13:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpZdw-0005um-AC for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 16:13:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rpZdw-0008Ev-5d for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 16:13:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2024 20:13:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171157035231519 (code B ref 70036); Wed, 27 Mar 2024 20:13:03 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 27 Mar 2024 20:12:32 +0000 Original-Received: from localhost ([127.0.0.1]:38417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpZdP-0008CJ-Rj for submit@debbugs.gnu.org; Wed, 27 Mar 2024 16:12:32 -0400 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:44398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpZdN-0008BO-Ki for 70036@debbugs.gnu.org; Wed, 27 Mar 2024 16:12:30 -0400 Original-Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a44f2d894b7so24636966b.1 for <70036@debbugs.gnu.org>; Wed, 27 Mar 2024 13:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711570343; x=1712175143; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wQddov7wCjSXNAKfS9h6lF5gdYaHRkDSnD+VfB6BiAI=; b=fb35BOkDchcxumuMRjPXcbJ3kJpFSjRNABOpCRfMdtOXGKmvUHCWSw19uX2Sk3V78f HZOOkVft0nly/ulI5yb9FvIWTQl48tcIw9EXDjK+aD7R92jFRlc1/AYxOOkE8V5To/NX 1OdT1dCvNK/ufC3KA7+XusXpukl9iC8Csl6dphVbPy50fQ/IHD7JK4q7jQMGxqm4xqpv CvN7jCqKh3y1PyfXX4poo8LIQaVA1bIXlLKsQy5m5jPyI+cEuBcU6+EVjxNmwhdD/yx2 /His8Koq6/3EE/jffwr0GpRae/kjyHW56qsie2pJjCVlk09IlwSdC3H4yD/tXP6S4yke Tcvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711570343; x=1712175143; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wQddov7wCjSXNAKfS9h6lF5gdYaHRkDSnD+VfB6BiAI=; b=quYhhRzgK7sxTdUWNbEI97jo7b8X/TOOvR4XpHn03kP5pOmyrEmcoqFM1VyP8rqUKZ kJhsesY8GvmJCTj38OmLtYSfP6ZrUf+FIoQfxGRTDDPTTYtrSJmGLK0X+AGkKUOVbzUE GvSaf/vrhnACzLP8RcSTFeOszCrczldudC/vAPOvL1E8HVH1CPxXKr37s4rVs0xdN1QT b2RsqL2PhyRWJJYAlB4kG3+bxQEY4/xQwjsE4Hwv+kMlLXOStQ9SyVWRn6WbWoRKJCpn RKtGs3+q/GfjKicJSvuc+aNjcaO9eXSrMI45oao3SoB124ZrxJJJ+Jj+MImAgytR7inC ovsQ== X-Gm-Message-State: AOJu0YxEp5Uwe4O/m6ulT372r8bpk9moQ2AZb00Hjl/1ZszNf6/sBTRF Cytw88J1VgEsorMJte/7REVyz5m3sowir5slmii6Mnzr4EDTppWM3wBppLO1 X-Google-Smtp-Source: AGHT+IHoi1qAzH04UxdC2mE2aHfGGE2+AxLfsH9qbRXh6hgfvfgLhE2G3SJSFiRXdOPFCxxjVQmGaA== X-Received: by 2002:a17:906:cf85:b0:a4d:edbd:a3fb with SMTP id um5-20020a170906cf8500b00a4dedbda3fbmr342997ejb.44.1711570342551; Wed, 27 Mar 2024 13:12:22 -0700 (PDT) Original-Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id x18-20020a170906b09200b00a47df55cf5esm4341798ejy.13.2024.03.27.13.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 13:12:22 -0700 (PDT) In-Reply-To: <87le63xzjt.fsf@thornhill.no> (Theodor Thornhill via's message of "Wed, 27 Mar 2024 20:08:54 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282154 Archived-At: > I've been studying Eglots performance and have been noticing a couple > of things that I find very interesting. It seems like `file-truename` > is in the hot path I think Eglot repeatedly calls file-truename with the same argument (or with an argument from a small set of filenames.) I wonder whether it would make sense for Eglot to cache the result of file-truename. Do you think caching would make Eglot faster than it currently is? (Would it still be worth moving file-truename to the C level?)