From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60078: 30.0.50; Gnus: Can't remove groups of select methods that don't exist anymore Date: Sun, 12 May 2024 22:08:40 +0000 Message-ID: <87ttj2isyj.fsf@kubajecminek.cz> References: <875yedvblv.fsf@thaodan.de> <87jzlgvlfe.fsf@kubajecminek.cz> <878r0hauhl.fsf@ericabrahamsen.net> Reply-To: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60078@debbugs.gnu.org, =?UTF-8?Q?Bj=C3=B6rn?= Bidar To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 13 00:09:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6HNq-0009Uo-OE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 May 2024 00:09:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6HNQ-00079n-8Y; Sun, 12 May 2024 18:09:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6HNO-00079a-Uh for bug-gnu-emacs@gnu.org; Sun, 12 May 2024 18:09:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6HNO-0003AF-MZ for bug-gnu-emacs@gnu.org; Sun, 12 May 2024 18:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6HNO-00023t-8r; Sun, 12 May 2024 18:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 12 May 2024 22:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60078 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 60078-submit@debbugs.gnu.org id=B60078.17155517377917 (code B ref 60078); Sun, 12 May 2024 22:09:02 +0000 Original-Received: (at 60078) by debbugs.gnu.org; 12 May 2024 22:08:57 +0000 Original-Received: from localhost ([127.0.0.1]:56747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6HNJ-00023d-0l for submit@debbugs.gnu.org; Sun, 12 May 2024 18:08:57 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:20595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6HNE-00023T-NS for 60078@debbugs.gnu.org; Sun, 12 May 2024 18:08:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kubajecminek.cz; s=protonmail; t=1715551725; x=1715810925; bh=SlVncI+ZGhQtReHjWBsTTj0aP4nN/D+BTrE3KJZ8FLc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=TrdOLZ33aAe7PDYvRD38saKzSgjpNFutbaAUTb2/2QwW7DLhN/GnB7uMztvcZnJLe flPVt1Hl0rIDhGkAjOeQUaUfM0kKEFekajpgbT/kORvZk+R1WJhuMT2nTwK26kRVy6 NrMdtuMzM2DNgBoz/jola3RQK7zsiNh1IAhkbrRFjm2/lm6rLG5LR8xWHNsWMUFBJw qFGcowfAZERoEuW9s2ftBPGqT+xusohVqf69rndJIDhGGoSLS7z0w5Uw/B50wsgkJE /+YnTet9WBn1JL3tI6fRZaZjLFCE9f2eRDYGuII3MvumtxKDAdzhpzL7Ud17XxYA9b yO90dRIWPiPGQ== In-Reply-To: <878r0hauhl.fsf@ericabrahamsen.net> Feedback-ID: 98803324:user:proton X-Pm-Message-ID: 150ecc59a4d239275abf9e2ef62bd77c7e0cb3e7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284942 Archived-At: Hello Eric, thanks for looking into it once again. "Eric Abrahamsen" writes: > So it looks like there's multiple things going on here. First of all, > the check for bogus groups explicitly excludes secondary select methods. > Why I do not know, but it's been that way since 2004. I believe that this is a bug. The documentation says that the `bogus' group is such that exists in the `.newsrc' file, but isn=E2=80=99t known to= the server (i.e., it isn=E2=80=99t in the active file). So it must not be active and must not be foreign. But the definition of foreign group in `gnus-check-bogus-newsgroups' is different from what was defined by Lars in 1997: (defun gnus-group-foreign-p (group) "Say whether a group is foreign or not." (and (not (gnus-group-native-p group)) (not (gnus-group-secondary-p group)))) We should use this predicate in `gnus-check-bogus-newsgroups' which fixes the bug we hit along the way (different behaviour between primary (native) and secondary select methods). What do you think? >From a7141acb5361be1c34775bd73434889018f0e9ff Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Jakub=3D20Je=3DC4=3D8Dm=3DC3=3DADnek?=3D Date: Sun, 12 May 2024 23:58:22 +0200 Subject: [PATCH] Fix foreign group predicate in gnus-check-bogus-newsgroups * lisp/gnus/gnus-start.el (gnus-check-bogus-newsgroups): Use correct predicate for foreign groups. --- lisp/gnus/gnus-start.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el index 05ad4303b5c..b01551d8e22 100644 --- a/lisp/gnus/gnus-start.el +++ b/lisp/gnus/gnus-start.el @@ -1368,9 +1368,7 @@ gnus-check-bogus-newsgroups =09(setq info (pop newsrc) =09 group (gnus-info-group info)) =09(unless (or (gnus-active group)=09; Active -=09=09 (and (gnus-info-method info) -=09=09=09 (not (gnus-secondary-method-p -=09=09=09 (gnus-info-method info))))) ; Foreign + (gnus-group-foreign-p group)) ; Foreign =09 ;; Found a bogus newsgroup. =09 (push group bogus))) (if confirm --=20 2.34.1 Best --=20 Kuba Je=C4=8Dm=C3=ADnek (http://kubajecminek.cz)