From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Xiyue Deng Newsgroups: gmane.emacs.bugs Subject: bug#72358: 29.4; oauth2.el improvements Date: Fri, 02 Aug 2024 01:15:22 -0700 Message-ID: <87ttg349yd.fsf@debian-hx90.lan> References: <87mslz8yzk.fsf@debian-hx90.lan> <87frrr725m.fsf@gmail.com> <87ed7a8ye6.fsf@debian-hx90.lan> <87jzh2vt3y.fsf@gmail.com> <87frrp6ch8.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29978"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72358@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 02 10:17:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZnTK-0007dF-Ja for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Aug 2024 10:17:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZnT0-0000Gl-Fy; Fri, 02 Aug 2024 04:16:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZnSx-0000FX-0v for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 04:16:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZnSt-0005cQ-T2 for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 04:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=St57At159kjjn3OifAhowrYfSgzT+YnJxHQAX1qAuVo=; b=CtbxsuCuzOrePf8pXzGVM0H1JhwfYYaehzV+wfw27iKNk6rRcBHjGg8sbztU3KeiBZBvXgX8LPEuucOCbSbkb+1Z18p8iaX/xBIZJdcjfgRX8T5JSDO8f2MmCD9FEHZImEyirnc2CQdmZT8DqHVRG3T12tzkVo1k+ZUdQPXnFzhv939iRrsjnJ9t1akTMTnlQl74SH5fXwRqxcdyo0IScSa90AaR8hW+JOdXWLkMv7/ipKw1HDtT0ORNWnwYtp9AlLAH6SCCecPaxyTaLxynmFX4LJNWsbrbPc8VPc/7Izi5I5ejlG/0UutStMUs2L7w/hqirLlF6voilNuzZ0LPCQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sZnTB-0000M7-Ro for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 04:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Xiyue Deng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Aug 2024 08:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72358 X-GNU-PR-Package: emacs Original-Received: via spool by 72358-submit@debbugs.gnu.org id=B72358.17225866101344 (code B ref 72358); Fri, 02 Aug 2024 08:17:01 +0000 Original-Received: (at 72358) by debbugs.gnu.org; 2 Aug 2024 08:16:50 +0000 Original-Received: from localhost ([127.0.0.1]:52429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZnT0-0000Lb-Fw for submit@debbugs.gnu.org; Fri, 02 Aug 2024 04:16:50 -0400 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:51551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZnSy-0000LP-9v for 72358@debbugs.gnu.org; Fri, 02 Aug 2024 04:16:48 -0400 Original-Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fd640a6454so62685715ad.3 for <72358@debbugs.gnu.org>; Fri, 02 Aug 2024 01:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722586524; x=1723191324; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=St57At159kjjn3OifAhowrYfSgzT+YnJxHQAX1qAuVo=; b=fvCINgtrF3oamNRfwtg23Z93JLA8GiL7RhnoqBIaYIVvej7RSESdjIdPuI41xPw8eD 7EsepoVlIHBFWxbaVBSsKjJI9Sp5Q10iO/NhHGq8fPqDOTH8ItKuBqNKPLKLrwiqptHz +dOpFImJMTI7eAGHDztuBWkXf9xkLLEu7GW02Y1D//ras2eX+s14/V48CX8HflA1rS40 pux6J6Ht8hEbUY8dFDuZ6JppcCCxpXxqaDgotWEGATpK6BtlGVCgSXvR6TPO2GesbcLJ c1AY5A0dnsJXxnR1ucsgYA6O06hI2wvSnnDSkdq/qHTp7sR/D1lRjAeabJOpTi4nI0YI LFfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722586524; x=1723191324; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=St57At159kjjn3OifAhowrYfSgzT+YnJxHQAX1qAuVo=; b=T7pN7eVlefao6d4B3z0hVQX+OMEMIUiA+Wyi8FAKiqEI26ewnOIovErpy4Dpck8eJp xk3O+704h/12khh3YeGfvNT3poN45XZSEI1+Yl8ditWW+FPX7Obf49aNsOkf81m6d9DU oc9xC6pgZZVbAON82dnjZgnIGjMhmu2BspQniAyPqP7HLFXXGyWUN8Y7VwN3PWMWFHzA BLyLofy5tUFp0bJVI0l9WVtGiE2d3Mis2FCzpZHm0zFy2i30MZU7Oo2skQDgqGDFELJy /qBEXOgQRcuyhhmBq1Yg6t5lE2tllb3rPHcXCZhMRqL6m70Fwg/Dr7fCGQ5om8sLwhUK wfDw== X-Gm-Message-State: AOJu0YxtZZfOM85o4gcphVhk+MPNxnb0g6Vv/2qmuuuWz+MALdFbi6AW oV/0WrOf9mLOpExLUuP3uqLrHlgfy1MxM0bmppl7t6QC+VdaHXh/AlgIUA== X-Google-Smtp-Source: AGHT+IH6Wey1yVT2kEwpBhKiRDL38CF7q3jcTD2vybnykgthgvWs3EJYPXqWVytEPZB/pfhMijSSkw== X-Received: by 2002:a17:902:f683:b0:1fb:9b9f:cb29 with SMTP id d9443c01a7336-1ff572e0b5amr33704695ad.24.1722586523968; Fri, 02 Aug 2024 01:15:23 -0700 (PDT) Original-Received: from debian-hx90 (syn-076-094-249-045.res.spectrum.com. [76.94.249.45]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff58a66284sm11615185ad.0.2024.08.02.01.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 01:15:23 -0700 (PDT) In-Reply-To: <87frrp6ch8.fsf@debian-hx90.lan> (Xiyue Deng's message of "Wed, 31 Jul 2024 04:13:23 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289633 Archived-At: Xiyue Deng writes: > Robert Pluim writes: > >>>>>>> On Tue, 30 Jul 2024 12:37:05 -0700, Xiyue Deng = said: >> Xiyue> The fifth patch adds debug messages when doing a URL query wh= ich records >> Xiyue> the request URL, the request data, and the response data, and= provide a >> Xiyue> custom variable to enable this. This provides a way to help = debugging >> Xiyue> the requests, and I find it handy when testing oauth2 against= different >> Xiyue> providers. >> >>=20 >> >> OK (although perhaps make it a defvar rather than a defcustom, to >> >> avoid people accidentally enabling it). >> >>=20 >> >> Xiyue> Done also in patch 5. >> >> I see you changed `oauth2-token-file' to a `defvar', which I don=CA=BCt >> think you should do. I was talking about making `oauth2-debug' a >> defvar. >> >> Robert > > Oops. Another reminder not to write code after 2am. > > The fixed patch 5 is attached. More reviews welcome! BTW, is there any dev available to commit the changes once it's in a good shape? --=20 Xiyue Deng