From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces Date: Mon, 07 Oct 2024 23:06:20 -0700 Message-ID: <87ttdn5dsz.fsf__45626.8815834605$1728367646$gmane$org@neverwas.me> References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17504"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 73686@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 08 08:07:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sy3NN-0004Qz-Ri for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Oct 2024 08:07:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sy3N3-0005iR-2n; Tue, 08 Oct 2024 02:06:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sy3N1-0005hg-9m for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 02:06:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sy3N0-0001R0-Qy for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 02:06:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=hOxRwMXvSr7/Py51iIT99f+YY+u+7wWzXVf1YNjV73w=; b=hoD7uAPOhOiaBn5tRG+G85ssx5tVdebZ+hBGVr89YvK2IoRcijH0oSpoGzifv7+5hWS8eTm9IQnu7jYVWWBBOH6R360gjHl72ZGewi9GacNVZ86VIe/SMspWdBbWTRSQEFdT2P9RGNKjVu+FUpF2cg6j2NjCUM8m5y0ThOZBusPz02/W4PFYB0sUL0DalLX6AlDJcr4yhYQ2qTNp67YI6qYv/W1aOHSqfLq1uLCaIV4i8jF8hRwCQeMIuHqaRFAbDZFF1OVk7tUmulu1lMOo+LTd44urdRdc8CMnUFcvrLEmbpy+zdzHLCcDuw+yae17Ynmx4l6PgJehp/xFA0+Lnw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sy3N8-0008V2-J4 for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 02:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2024 06:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73686 X-GNU-PR-Package: emacs Original-Received: via spool by 73686-submit@debbugs.gnu.org id=B73686.172836760132634 (code B ref 73686); Tue, 08 Oct 2024 06:07:02 +0000 Original-Received: (at 73686) by debbugs.gnu.org; 8 Oct 2024 06:06:41 +0000 Original-Received: from localhost ([127.0.0.1]:50341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy3Mm-0008UH-Ub for submit@debbugs.gnu.org; Tue, 08 Oct 2024 02:06:41 -0400 Original-Received: from mail-108-mta142.mxroute.com ([136.175.108.142]:44251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy3Mk-0008U9-Ut for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 02:06:39 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta142.mxroute.com (ZoneMTA) with ESMTPSA id 1926abc6ea30003e01.001 for <73686@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Oct 2024 06:06:26 +0000 X-Zone-Loop: a274366291f85970fde00a69556856ed4dd911d5b1fd X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hOxRwMXvSr7/Py51iIT99f+YY+u+7wWzXVf1YNjV73w=; b=c69vgdFz+hxyF2tgbTc1hrYe+U s1YjtLLQrPmeM620/knbL7TKPojUyS6G7hULkiVoOhxUwtc78d8OdPILDmQU+JQODitjgFPLMMlai J77HirbCsVM9ktewJ2QxyVSRRF0k1ONxMMgOo75nVo8DxeswKGMfosh/dXb5Zt1RC+PmMqLbfse04 WD2f7vLE6F0RefwOTkBpCkkvbqWJ/oCqf5lAZlPrfJwcqmJw4P6IpsOwEDH2sqHQAEpse6qXKfWUa moXD2BKAo5bItUkSBB5mVdWg7UF6Pp76cxf3HkpoNkad6ZNSK2+VwWjosJK+7PWRRvRjo87f5sRkE Iv6jifbg==; In-Reply-To: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> (J. P.'s message of "Mon, 07 Oct 2024 19:47:41 -0700") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293144 Archived-At: "J.P." writes: > This appears to be related to a recent change involving the killing of > local variables in `help-setup-xref'. Poking around some, it seems the various `describe-*' commands in help-fns.el run `help-setup-xref' before doing (with-help-window (help-buffer) ...) And because `major-mode' is buffer-local, it gets wiped out with these latest changes before `help-buffer' ever sees it: (defun help-buffer () (buffer-name (if (and help-xref-following (derived-mode-p 'help-mode)) (current-buffer) (get-buffer-create "*Help*")))) (Here, `help-xref-following' is t thanks to `help-do-xref'.) > Regarding (2), the Help buffer now opens in a split whereas before it > opened in the current window. The failing test expects the old behavior This appears to happen when the `help-mode' (turned `fundamental-mode') buffer from which `describe-*' is run isn't named `*Help*', as is the case with `list-faces-display' and `erc-nicks-list-faces'. As for fixing this, I wonder if we can somehow expand the role of `help-buffer-under-preparation' (or `help-xref-following') so that instead of t, it's bound to the last value of `major-mode' prior to `help-setup-xref' running. And then `help-buffer' could first check this stashed value before considering the current `major-mode' (like via `provided-mode-derived-p' or whatever).