bug#74026: Patch to correct the list of cached functions in tramp-sh.el

bug#74026: Patch to correct the list of cached functions in tramp-sh.el

[Eyal Soha]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

The comment here is not correct:
https://github.com/emacs-mirror/emacs/blob/2a6af880b0958d527a4d32005ef9acf3bc4ea030/lisp/net/tramp-sh.el#L3736-L3740

The command file-directory-p should also be cached.  Fortunately, the
result is already cached so all that is needed is to add this function to
the list.  Performance of the ssh commands for vc-register is improved by
170% with this patch.

It's described in detail here: https://github.com/emacs-mirror/emacs/pull/43

How can I help get this patch into the repository?

Eyal

[-- Attachment #2: Type: text/html, Size: 861 bytes --]

bug#74026: Patch to correct the list of cached functions in tramp-sh.el

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Version: 30.2

Eyal Soha <eyalsoha@gmail.com> writes:

Hi Eyal,

> The comment here is not correct:
> https://github.com/emacs-mirror/emacs/blob/2a6af880b0958d527a4d32005ef9acf3bc4ea030/lisp/net/tramp-sh.el#L3736-L3740

The comment was correct. Meanwhile, vc-find-root has been added or
extended, we need file-directorx-p therefore.

> The command file-directory-p should also be cached.  Fortunately, the
> result is already cached so all that is needed is to add this function
> to the list.  Performance of the ssh commands for vc-register is
> improved by 170% with this patch.
>
> It's described in detail here:
> https://github.com/emacs-mirror/emacs/pull/43
>
> How can I help get this patch into the repository?

Thanks for your comprehensive investigation. I've tried your changes,
Tramp's regression tests still pass.

So I have pushed it to the repositories. Will appear end of this month
with Tramp 2.7.1.4 on GNU ELPA. Closing the bug.

> Eyal

Best regards, Michael.

bug#74026: Patch to correct the list of cached functions in tramp-sh.el

[Eyal Soha]

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

Yes, I imagine that it was once correct and no longer.

To help prevent this issue in the future, Tramp could print a message
whenever the handler is installed yet commands other than the ones in the
list get run.

Thanks for the help! I have closed the PR on GitHub.

Eyal

On Sat, Oct 26, 2024, 06:22 Michael Albinus <michael.albinus@gmx.de> wrote:

> Version: 30.2
>
> Eyal Soha <eyalsoha@gmail.com> writes:
>
> Hi Eyal,
>
> > The comment here is not correct:
> >
> https://github.com/emacs-mirror/emacs/blob/2a6af880b0958d527a4d32005ef9acf3bc4ea030/lisp/net/tramp-sh.el#L3736-L3740
>
> The comment was correct. Meanwhile, vc-find-root has been added or
> extended, we need file-directorx-p therefore.
>
> > The command file-directory-p should also be cached.  Fortunately, the
> > result is already cached so all that is needed is to add this function
> > to the list.  Performance of the ssh commands for vc-register is
> > improved by 170% with this patch.
> >
> > It's described in detail here:
> > https://github.com/emacs-mirror/emacs/pull/43
> >
> > How can I help get this patch into the repository?
>
> Thanks for your comprehensive investigation. I've tried your changes,
> Tramp's regression tests still pass.
>
> So I have pushed it to the repositories. Will appear end of this month
> with Tramp 2.7.1.4 on GNU ELPA. Closing the bug.
>
> > Eyal
>
> Best regards, Michael.
>

[-- Attachment #2: Type: text/html, Size: 2208 bytes --]

bug#74026: Patch to correct the list of cached functions in tramp-sh.el

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eyal Soha <eyalsoha@gmail.com> writes:

Hi Eyal,

> To help prevent this issue in the future, Tramp could print a message
> whenever the handler is installed yet commands other than the ones in
> the list get run.

Well, I don't believe it is worth the trouble. It was the first time in
two decades that the list had to be extended.

> Thanks for the help! I have closed the PR on GitHub.
>
> Eyal

Best regards, Michael.

bug#74026: Patch to correct the list of cached functions in tramp-sh.el

[Eyal Soha]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

👍

Eyal reacted via Gmail
<https://www.google.com/gmail/about/?utm_source=gmail-in-product&utm_medium=et&utm_campaign=emojireactionemail#app>

On Sat, Oct 26, 2024, 08:48 Michael Albinus <michael.albinus@gmx.de> wrote:

> Eyal Soha <eyalsoha@gmail.com> writes:
>
> Hi Eyal,
>
> > To help prevent this issue in the future, Tramp could print a message
> > whenever the handler is installed yet commands other than the ones in
> > the list get run.
>
> Well, I don't believe it is worth the trouble. It was the first time in
> two decades that the list had to be extended.
>
> > Thanks for the help! I have closed the PR on GitHub.
> >
> > Eyal
>
> Best regards, Michael.
>

[-- Attachment #2: Type: text/vnd.google.email-reaction+json, Size: 40 bytes --]

{
  "emoji": "👍",
  "version": 1
}

[-- Attachment #3: Type: text/html, Size: 1249 bytes --]