From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Tue, 19 Nov 2024 18:13:14 +0200 Message-ID: <87ttc3td5x.fsf@thaodan.de> References: <86frnovhg8.fsf@gnu.org> <867c90vbfk.fsf@gnu.org> <861pz8uzyo.fsf@gnu.org> <86zflwtjlz.fsf@gnu.org> <86wmgztfse.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18466"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 19 17:14:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDQs6-0004fZ-Nc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Nov 2024 17:14:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDQre-00034L-8q; Tue, 19 Nov 2024 11:14:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDQrb-0002ye-C4 for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 11:14:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDQrb-0006oH-3b for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 11:14:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=r5EWDBb3StUt/BXoLpYaBIwCF5E8vAVWoUHWOG6Tvy0=; b=ER/olKr8+5cbT7czCP+48ZQs7Bh50IQ8uNfGHHvAJ1xdwWa+VtsCdDYI3HF/JXQ5PUe4OgzbM/8qd3vD7fNucNjx5Xlg/w5S02px/zRv2H1H3DfhxqnDRMCcnWdvQ9Sv9gXPGtNsOYQQ/kUgE7D3UPhRnUxsoC1D9l5vVX8qsgCtVFAhO5/vE+xT0LelKFWbL820P7U6gUGAfebXI74ncadH/+/TYZ7mEiub3H8vupE3QGaln1GNIwsgQzpggW8hZwjndo6P12EAeiinLdtDiclmLg3xHZa1J1eMjS2P1mNiLMNPLN9jxIx+J9LxhkOyMoEK4DtHSOcuQvemawOZ1Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDQra-0005gL-Vm for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 11:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2024 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.173203280121745 (code B ref 74413); Tue, 19 Nov 2024 16:14:02 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 19 Nov 2024 16:13:21 +0000 Original-Received: from localhost ([127.0.0.1]:43761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDQqu-0005eZ-2J for submit@debbugs.gnu.org; Tue, 19 Nov 2024 11:13:20 -0500 Original-Received: from thaodan.de ([185.216.177.71]:59614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDQqr-0005eL-5x for 74413@debbugs.gnu.org; Tue, 19 Nov 2024 11:13:18 -0500 Original-Received: from NordStern (unknown [185.252.118.71]) by thaodan.de (Postfix) with ESMTPSA id 72464D00038; Tue, 19 Nov 2024 18:13:15 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1732032795; bh=CWAMKdrpuPTUR+G0w13NEdzoypUzS6qXT6B265ETCxE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=wgjHQlrqabYIFsbvveod6+0Idvh1LjUx9Cs9H1jEcPrWyvA88U33CPMINgaRmzarK Mggis+fL0LHvLBZYk54PfxNC5C4C1brMzhYS24UyS7O+uCl3tJVZjqmINcX/LQ79eB 9wyj9+PtP3zxbwz3QRP5x2PzKZ4AsivjK90U/J2+0UF9rmd1fqWPAg4v95EpD+R9cs UtlLcqq4gDMX7v3vEB2h/jCvQhVVIzyPD2r4LLDLTzX+etyWmnXK2JX1r1VzSvbHxc WYue91mb4I86ZrFwh6Bm0ENvLMyKMQBbt53TKe/6g51n5tdsFQLAmALI/10wvs/fmh dGHUqTuronZzBT/YJaT2exKdFZkOzztEYVLzrw7Ifkmrr2KP15G+eBKH6sro09W5h/ QJFP+tGihwvfgQxo50jhXFfh5hhlbXbTEQccC9M5Ig3EpiTN7mtoYF8H2tPFHM6kfj T5/A4mMyjq1Xl13Iq9fXeSRBwD5XtimEer3jrKzMxzqM/kYm3pTZckha3DTy7+yyA6 WjmlWbR7ZWwRGeoyztkGcOqHp/3tUOX6dcC97kueKwFYlImy9vBQeLWWGj67dnWw7f V7L2TBYF8NOueSbFUz2PEHdNkuWbaRg3PSxwDDGOh69SvPctpvl2XS8POTHICafVfZ T6FwUMnDyQLEWB9pTqZVvGso= In-Reply-To: <86wmgztfse.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Nov 2024 17:16:33 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295644 Archived-At: Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: stefankangas@gmail.com, luangruo@yahoo.com, 74413@debbugs.gnu.org >> Date: Mon, 18 Nov 2024 23:48:38 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > I still don't think I understand, sorry. Do you mean the file is >> > generated from a Git repository, but then Emacs is somehow built from >> > a directory that is not under Git? >>=20 >> The file can be generated from the git repository outside of the Emacs >> builder. > > So you mean someone will chdir to the Git repository, say > > $ make etc-emacsver > > Then take the produced file and manually install it when Emacs is > built (in another directory) and installed, is that right? I extract the file from the obs service and generate file from the services metadata. The make target is there to create the file if Emacs is built with git installed or if the target is used in the way you mentioned above.=20 In both cases the emacs VCS functions will still work after the built without the sources or git installed, in the case of the former as long as in the packager has provided the metadata themselves.=20 >> > But if this is the scenario, how can you be sure the produced Emacs bi= nary was made from that revision >> > on that branch? This is only guaranteed if you actually build from >> > Git when you record this information. >> > >> > What am I missing? >>=20 >> If the source is generated by the CI it can also store this information >> in the build source which then can be extracted from the ci metadata to >> the Emacs sources on the builder. >>=20 >> I can be sure that Emacs was built from that revision as much as I can >> trust the CI to use the sources I told it to use. If I can't trust one, >> I can't trust the other. > > But CI builds from Git, doesn't it? If so, the Emacs it produces > already records the revision and the branch. The source generator, the source service runs git but the builder doesn't. Because the builder doesn't have to deal with git the rebuild chain is smaller, build dependency changes can trigger rebuilds, and the worker doesn't have to have git installed. In most cases it's not required or wanted that worker have git as the only allowed purpose would be to get access already existing metadata but not change anything on the sources itself. Providing the metadata to the VCS emacs-repository-branch and emacs-repository-version with the previously generated metadata that belongs to the package sources removes the need for git in the build worker.