From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Date: Tue, 26 Nov 2024 21:35:17 +0000 Message-ID: <87ttbtd6ga.fsf@jeremybryant.net> References: <87ldynk8un.fsf@jeremybryant.net> Reply-To: Jeremy Bryant Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18472"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , 73827@debbugs.gnu.org To: Alex Bochannek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 26 22:36:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tG3Eq-0004Xg-Kw for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Nov 2024 22:36:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tG3EA-0002qK-MJ; Tue, 26 Nov 2024 16:36:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG3E4-0002k8-4K for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 16:36:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tG3E3-0000iX-QQ for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 16:36:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=K7P/R8ErzP9r34e1vNWWPW9BlLoLkka49jITaxEpZi0=; b=YUoo2HFxpCFOb66+8/vLUYBg21CfINf+7Crjg95AgF1HWsoEXQJ0tzlkcOxAzLEjCNZOJjib2jKJI2pSjV0Mv1T/o77RIymiohBYV94TAJrKryJCbojZSQkSmqapr77Bt0QCauy4YX/D0ayUPb9OJ1YZiNG8w+Pbb7dYTHTtvmTegcs3ihD9fEcfqpAP/zhCdzsu/grlB62P644yJyL99Fz/SdnPF0AtLPYryaCrDxWwz08aUOmPRcdixyMKFWWSclzPel69kEsFyBRHs2nXz7mKwksk9vaobUFPUoJy0LJbkMLQ8WwdUETPuOyXh6rLW4j6r6VfEREt4nLU8YgnSQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tG3E3-0001tA-HJ for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 16:36:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2024 21:36:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73827-submit@debbugs.gnu.org id=B73827.17326569317179 (code B ref 73827); Tue, 26 Nov 2024 21:36:03 +0000 Original-Received: (at 73827) by debbugs.gnu.org; 26 Nov 2024 21:35:31 +0000 Original-Received: from localhost ([127.0.0.1]:53726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG3DW-0001rj-J1 for submit@debbugs.gnu.org; Tue, 26 Nov 2024 16:35:30 -0500 Original-Received: from out-182.mta1.migadu.com ([95.215.58.182]:38792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG3DT-0001rP-7E for 73827@debbugs.gnu.org; Tue, 26 Nov 2024 16:35:28 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1732656921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K7P/R8ErzP9r34e1vNWWPW9BlLoLkka49jITaxEpZi0=; b=hP7QiiGPU6Hni+VRE+G6ePdjsVZxzd5Acu/8IrsWuNOUjaBA7tOpUp4a3TYIylPUrn7UJS cLQ6UvXqqwkcCIEe5gxmVY5VoC7mvc7yoqZZvJ7OTDy0qtT8NsXajoyiKJ2+Efnggl8mAZ S2K9HGLNlqlCHOLDli0Y0XG8XKntSPfp516yRIWfFM9q4w5cR2bhxHTz8MmtSrbh6oAq81 PjHkdH9VSBQpNswAwa9fqGYCDxfIw/zIR9ETSY990pAS1QQow59Rq4+YpicyEKYKfZ3Q7v 0OuUCbw4vLQr69pEzFxSXrOI41xuyZSaZBjjkTbRdqQrCbkTh2ib+mL7Lpqw6A== In-Reply-To: (Alex Bochannek's message of "Mon, 25 Nov 2024 15:02:43 -0800") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296001 Archived-At: Alex Bochannek writes: > Anything else that's needed from me here? I have another trivial fix for > register-list I would like to submit. Thanks alex for your contribution. Adding Philip, any comments or suggestions on this short ELPA patch? > > Thanks! > > Alex Bochannek writes: > >> Jeremy Bryant writes: >> >>> Alex Bochannek writes: >>> >>>> Hello! >>>> >>>> I have not submitted patches against an ELPA package before, so I hope >>> >>> Philip, any comments? >>> >>>> >>>> Apologies again for the format of this submission. If someone could >>>> point me at instructions for how to make your life easier next time, I'd >>>> appreciate it. >>> >>> Please read the file CONTRIBUTE in the Emacs source tree. >> >> Figured out my issue with populating the ELPA repo (new computer, old >> version of gmake) and I am including the patch in the proper format now. >> >> From dafcff7c7a9cb6952aa740ef34a67eb61fd2a90d Mon Sep 17 00:00:00 2001 >> From: Alex Bochannek >> Date: Wed, 16 Oct 2024 19:35:33 -0700 >> Subject: [PATCH] Fix unprintable register display logic >> >> --- >> register-list.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/register-list.el b/register-list.el >> index 846d3efe49..5a81b1b7bb 100644 >> --- a/register-list.el >> +++ b/register-list.el >> @@ -478,8 +478,8 @@ the register or copy its value into the kill ring." >> (t "error")) >> (cond ((window-configuration-p (car key)) "W") >> ((frame-configuration-p (car key)) "F") >> - ((stringp (car key)) "R") >> ((string= "Unprintable entity" (car key)) "?") >> + ((stringp (car key)) "R") >> (t "error")))) >> >> ;;; Edit key/value of the register >> -- >> 2.39.5 (Apple Git-154)