unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#48013: 28.0.50; `icomplete-vertical-mode` does not support annotations/affixations
@ 2021-04-25  9:36 Daniel Mendler
  2021-04-25  9:49 ` Gregory Heytings
  2024-11-29 17:53 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 2 replies; 4+ messages in thread
From: Daniel Mendler @ 2021-04-25  9:36 UTC (permalink / raw)
  To: 48013; +Cc: gregory

The recently introduced `icomplete-vertical-mode` does not yet support
annotations as provided by `annotation/affixation-function`. Thanks to
the vertical UI, there is plenty of space to show annotations. Many
other vertical UIs already offer support, e.g., Ivy, Vertico,
external Icomplete-vertical (by Omar Antolín Camarena), etc. Is support
for annotations planned in `icomplete-vertical-mode`?





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#48013: 28.0.50; `icomplete-vertical-mode` does not support annotations/affixations
  2021-04-25  9:36 bug#48013: 28.0.50; `icomplete-vertical-mode` does not support annotations/affixations Daniel Mendler
@ 2021-04-25  9:49 ` Gregory Heytings
  2021-04-25 10:09   ` Daniel Mendler
  2024-11-29 17:53 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 1 reply; 4+ messages in thread
From: Gregory Heytings @ 2021-04-25  9:49 UTC (permalink / raw)
  To: Daniel Mendler; +Cc: 48013

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]


>
> The recently introduced `icomplete-vertical-mode` does not yet support 
> annotations as provided by `annotation/affixation-function`. Thanks to 
> the vertical UI, there is plenty of space to show annotations. Many 
> other vertical UIs already offer support, e.g., Ivy, Vertico, external 
> Icomplete-vertical (by Omar Antolín Camarena), etc. Is support for 
> annotations planned in `icomplete-vertical-mode`?
>

Thanks for your bug report.  Yes, it was planned, although this wasn't a 
top priority until your bug report arrived.  It has now moved a bit closer 
to the top of the stack ;-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#48013: 28.0.50; `icomplete-vertical-mode` does not support annotations/affixations
  2021-04-25  9:49 ` Gregory Heytings
@ 2021-04-25 10:09   ` Daniel Mendler
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Mendler @ 2021-04-25 10:09 UTC (permalink / raw)
  To: Gregory Heytings; +Cc: 48013

On 4/25/21 11:49 AM, Gregory Heytings wrote:
> Thanks for your bug report.  Yes, it was planned, although this wasn't a 
> top priority until your bug report arrived.  It has now moved a bit 
> closer to the top of the stack ;-)

That's good to hear. You are probably aware of this - it is important to 
annotate only the visible candidates, I think Omar's icomplete-vertical 
implementation originally called all annotators, which lead to a 
significant slowdown.

Thank you for working on this!





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#48013: 28.0.50; `icomplete-vertical-mode` does not support annotations/affixations
  2021-04-25  9:36 bug#48013: 28.0.50; `icomplete-vertical-mode` does not support annotations/affixations Daniel Mendler
  2021-04-25  9:49 ` Gregory Heytings
@ 2024-11-29 17:53 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 0 replies; 4+ messages in thread
From: Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-11-29 17:53 UTC (permalink / raw)
  To: 48013-done

Has been implemented.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-11-29 17:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-25  9:36 bug#48013: 28.0.50; `icomplete-vertical-mode` does not support annotations/affixations Daniel Mendler
2021-04-25  9:49 ` Gregory Heytings
2021-04-25 10:09   ` Daniel Mendler
2024-11-29 17:53 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).