unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Osama Rebach <osamarebach@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 74606-done@debbugs.gnu.org, manuel@ledu-giraud.fr
Subject: bug#74606: 31.0.50; Another rsvg API change
Date: Mon, 02 Dec 2024 12:58:01 +0100	[thread overview]
Message-ID: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> (raw)
In-Reply-To: <864j3n5u7u.fsf@gnu.org> (message from Eli Zaretskii on Sun, 01 Dec 2024 16:55:01 +0200)


rsvg_handle_get_pixbuf_and_error is defined in librsvg 2.59, so the patch
should guard against 2.59 instead of 2.58

I have libsrvg 2.58.3 and get this error:

image.c: In function 'svg_load_image':
image.c:12376:12: warning: implicit declaration of function 'rsvg_handle_get_pixbuf_and_error'; did you mean 'rsvg_handle_get_pixbuf_sub'? [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
12376 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |            rsvg_handle_get_pixbuf_sub
image.c:12376:10: warning: assignment to 'GdkPixbuf *' {aka 'struct _GdkPixbuf *'} from 'int' makes pointer from integer without a cast [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wint-conversion-Wint-conversion8;;]
12376 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
      |          ^
  CC       lastfile.o
  CCLD     temacs
  GEN      ../etc/DOC
/nix/store/va7kw1i822h95im4jacci19v0cqajfyf-binutils-2.43.1/bin/ld: image.o: in function `svg_load_image':
image.c:(.text+0x7a89): undefined reference to `rsvg_handle_get_pixbuf_and_error'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:745: temacs] Error 1
make[2]: Leaving directory '/build/source/src'
make[1]: *** [Makefile:554: src] Error 2
make[1]: Leaving directory '/build/source'
make[1]: Entering directory '/build/source'
***
*** "make all" failed with exit status 2.
***
*** You could try to:
*** - run "make bootstrap", which might fix the problem
*** - run "make V=1", which displays the full commands invoked by make,
***   to further investigate the problem
***
make[1]: *** [Makefile:418: advice-on-failure] Error 2
make[1]: Leaving directory '/build/source'
make: *** [Makefile:374: all] Error 2





  reply	other threads:[~2024-12-02 11:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29 16:42 bug#74606: 31.0.50; Another rsvg API change Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-30 11:06 ` Eli Zaretskii
2024-12-01 13:09   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-01 14:55     ` Eli Zaretskii
2024-12-02 11:58       ` Osama Rebach [this message]
2024-12-02 13:45         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 14:06           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 14:14             ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 14:41               ` Eli Zaretskii
2024-12-02 15:02                 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 15:11                   ` Eli Zaretskii
2024-12-02 16:03                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 16:24                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set \
    --to=osamarebach@gmail.com \
    --cc=74606-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).