From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9918: 24.0.90; lazy-highlighting in Info mode Date: Thu, 03 Nov 2011 21:56:20 +0200 Organization: JURTA Message-ID: <87sjm5f09n.fsf@mail.jurta.org> References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1320350322 25533 80.91.229.12 (3 Nov 2011 19:58:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 3 Nov 2011 19:58:42 +0000 (UTC) Cc: 9918@debbugs.gnu.org To: Dani Moncayo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 03 20:58:37 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RM3Qq-0003Zi-Oc for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Nov 2011 20:58:36 +0100 Original-Received: from localhost ([::1]:47409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM3Qq-0008KT-6c for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Nov 2011 15:58:36 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM3Qn-0008KJ-E1 for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 15:58:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RM3Qm-0000GP-JV for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 15:58:33 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM3Qm-0000GJ-E1 for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 15:58:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RM3TB-0001tU-Od for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 16:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2011 20:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9918 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9918-submit@debbugs.gnu.org id=B9918.13203504417235 (code B ref 9918); Thu, 03 Nov 2011 20:01:01 +0000 Original-Received: (at 9918) by debbugs.gnu.org; 3 Nov 2011 20:00:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM3Sr-0001se-I3 for submit@debbugs.gnu.org; Thu, 03 Nov 2011 16:00:41 -0400 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM3So-0001sW-CE for 9918@debbugs.gnu.org; Thu, 03 Nov 2011 16:00:39 -0400 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 443E66E809B; Thu, 3 Nov 2011 12:58:07 -0700 (PDT) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7598A451C58B; Thu, 3 Nov 2011 12:58:06 -0700 (PDT) In-Reply-To: (Dani Moncayo's message of "Thu, 3 Nov 2011 20:24:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 03 Nov 2011 16:01:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53476 Archived-At: > * "Isearch: foo" > * "Isearch: foo [failing]" > * "Isearch: foo [failing, overwrapped]" > * "Isearch: foo [failing, initial node]" Yes, moving all prefixes into suffixes and always displaying the search string at the fixed position in the message avoids this problem where prefixes shift the search string to the right in the message, so its position jumps left and right during Isearch depending on the length of the composite prefix that makes more difficult to concentrate on the search string displayed in the message. > This approach raises a question: how to show the _error_ flags to make > them distinguishable from the _informative_ flags? > > One possibility is to show all the flags the same way. After all, the > fact that the errors deactivate the Isearch should be enough for the > user to know what's going on, I think. I think to show all the flags the same way is better. Of course, this should be postponed for 24.2. But now I'd like to fix the original problem you reported. I think we should remove `(not isearch-error)' from `isearch-lazy-highlight-new-loop'. This is over-optimization. It can't know for sure beforehand whether lazy-highlighting will be able to highlight matches even when isearch-error is non-nil. === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-10-30 01:56:03 +0000 +++ lisp/isearch.el 2011-11-03 19:55:07 +0000 @@ -2674,7 +2721,6 @@ (defun isearch-lazy-highlight-new-loop ( ;; something important did indeed change (lazy-highlight-cleanup t) ;kill old loop & remove overlays (setq isearch-lazy-highlight-error isearch-error) - (when (not isearch-error) (setq isearch-lazy-highlight-start-limit beg isearch-lazy-highlight-end-limit end) (setq isearch-lazy-highlight-window (selected-window) @@ -2692,7 +2738,7 @@ (defun isearch-lazy-highlight-new-loop ( (unless (equal isearch-string "") (setq isearch-lazy-highlight-timer (run-with-idle-timer lazy-highlight-initial-delay nil - 'isearch-lazy-highlight-update)))))) + 'isearch-lazy-highlight-update))))) (defun isearch-lazy-highlight-search () "Search ahead for the next or previous match, for lazy highlighting.