unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: rms@gnu.org
Cc: 11242@debbugs.gnu.org
Subject: bug#11242: 24.1.50; Switching to rmai view buffer
Date: Mon, 16 Apr 2012 18:18:09 +0800	[thread overview]
Message-ID: <87sjg4q8ta.fsf@gnu.org> (raw)
In-Reply-To: <E1SJVoH-0001F5-04@fencepost.gnu.org> (Richard Stallman's message of "Sun, 15 Apr 2012 16:12:33 -0400")

Richard Stallman <rms@gnu.org> writes:

> It's neither one.  It's done by this code.
>
>     ;; If there is an Rmail buffer, return to it nicely
>     ;; even if this message was not started by an Rmail command.
>     (unless return-action
>       (dolist (buffer (buffer-list))
> 	(if (eq (buffer-local-value 'major-mode buffer) 'rmail-mode)
> 	    (setq return-action `(rmail-mail-return ,newbuf)))))

This code is wrong; the NEWBUF should not be passed to
rmail-mail-return, it should be the BUFFER variable in the loop.  I've
committed a fix.


BTW, having code in mail-bury to specially handle Rmail buffers is kinda
ugly.  This probably needs to be folded into the quit-window mechanism,
somehow.  In the first place, I'm not even sure it's appropriate to
redirect the user to an Rmail buffer if the mail command was not started
from Rmail.





  parent reply	other threads:[~2012-04-16 10:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-14  4:17 bug#11242: 24.1.50; Switching to rmai view buffer Richard Stallman
2012-04-14 13:30 ` martin rudalics
2012-04-14 18:31 ` Richard Stallman
2012-04-14 18:52   ` martin rudalics
2012-04-14 19:18     ` Eli Zaretskii
2012-04-15  8:14       ` martin rudalics
2012-04-15 20:12         ` Richard Stallman
2012-04-16  8:15           ` martin rudalics
2012-04-16 10:18           ` Chong Yidong [this message]
2012-04-16 22:01             ` Richard Stallman
2012-04-15  2:18     ` Richard Stallman
2012-04-15  8:14       ` martin rudalics
2012-04-15  2:18     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjg4q8ta.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=11242@debbugs.gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).