unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 6339@debbugs.gnu.org
Subject: bug#6339: url-filename => "/c:/some/file.txt"
Date: Wed, 09 May 2012 17:04:35 +0800	[thread overview]
Message-ID: <87sjf94tek.fsf@gnu.org> (raw)
In-Reply-To: <AANLkTi=1oNomjc0aTZ-B0EPhwv4zLbA=nPA1szTq7Ete@mail.gmail.com> (Juanma Barranquero's message of "Mon, 26 Jul 2010 13:50:09 +0200")

Ressurrecting this discussion...

I just looked at the relevant code and at RFC 3986, and I think the
problem is that the url object returned by url-generic-parse-url has
badly named slots.  That function ought to be following the RFC, instead
of imposing its own interpretation of things.  So the FILENAME slot,
which is returned by url-filename, should really be two slots, PATH and
QUERY, whose meanings are unambiguously defined in the URI spec.  And
there should be no expectation that the PATH part corresponds to a
filename.

In particular, RFC 3986 explicitly states that

  If a URI contains an authority component, then the path component must
  either be empty or begin with a slash ("/") character.

That is to say, the / is part of the path.

Unfortunately, it's inconvenient to change the contents of the struct
now, since that means changing the arglist of the url-parse-make-urlobj
constructor; that constructor is already called from Tramp, and maybe
other packages.  So I think we should just explicitly state that the
FILENAME slot is really PATH and QUERY together, and wash our hands of
the matter.

This also means that it should be up to callers to convert the FILENAME
slot (i.e. PATH and QUERY) into proper filenames.  The translation from
URIs to filenames is scheme-independent anyway, so it shouldn't be
handled at the level of url-generic-parse-url.





  parent reply	other threads:[~2012-05-09  9:04 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03  2:38 bug#6339: url-filename => "/c:/some/file.txt" Lennart Borgman
2010-06-03 11:13 ` Juanma Barranquero
2010-07-26 11:50 ` Juanma Barranquero
2010-07-26 12:00   ` Lennart Borgman
2010-08-01 18:46   ` Juanma Barranquero
2010-08-02  7:51     ` Michael Albinus
2011-09-21 20:28   ` Lars Magne Ingebrigtsen
2011-09-21 22:21     ` Juanma Barranquero
2011-09-21 22:31       ` Lennart Borgman
2011-09-21 22:45         ` Juanma Barranquero
2011-09-21 22:51           ` Lennart Borgman
2011-09-21 22:59             ` Juanma Barranquero
2011-09-21 23:15               ` Lennart Borgman
2011-09-21 23:18                 ` Juanma Barranquero
2011-09-21 23:32                   ` Lennart Borgman
2011-09-21 23:37                     ` Juanma Barranquero
2011-09-21 23:46                       ` Lennart Borgman
2011-09-22  0:32                         ` Juanma Barranquero
2011-09-22  0:40                           ` Lennart Borgman
2011-09-22  0:59                             ` Juanma Barranquero
2011-09-22  1:07                               ` Lennart Borgman
2011-09-22  1:14                                 ` Juanma Barranquero
2011-09-22  9:52                                   ` Lennart Borgman
2011-10-06  5:09                                   ` Kevin Rodgers
2011-10-06 11:56                                     ` Juanma Barranquero
2011-10-06 12:43                                       ` Stefan Monnier
2011-10-06 13:40                                         ` Juanma Barranquero
2011-10-06 14:24                                           ` Jason Rumney
2011-10-06 14:30                                             ` Juanma Barranquero
2011-10-06 14:38                                               ` Jason Rumney
2011-10-06 14:49                                                 ` Juanma Barranquero
2011-10-06 15:08                                                 ` Lennart Borgman
2011-10-06 15:08                                                 ` Lennart Borgman
2011-10-06 15:31                                           ` Stefan Monnier
2011-10-06 15:56                                             ` Juanma Barranquero
2011-10-06 16:49                                               ` Stefan Monnier
2011-10-06 16:54                                                 ` Juanma Barranquero
2011-10-06 21:08                                                   ` Stefan Monnier
2011-09-24  3:35                           ` Jason Rumney
2011-09-24  8:59                             ` Juanma Barranquero
2011-09-24  9:06                               ` Juanma Barranquero
2011-09-24 11:53                               ` Andreas Schwab
2011-09-24 21:56                                 ` Juanma Barranquero
2011-09-24 23:42                                   ` Andreas Schwab
2011-09-25  0:02                                     ` Juanma Barranquero
2011-09-24  9:46                             ` Lennart Borgman
2011-09-24 12:28                             ` Richard Stallman
2012-05-09  9:04   ` Chong Yidong [this message]
2012-05-09 11:52     ` Juanma Barranquero
2012-05-10 14:15       ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjf94tek.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=6339@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).