From: Christopher Schmidt <christopher@ch.ristopher.com>
To: 11795@debbugs.gnu.org
Subject: bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files
Date: Wed, 27 Jun 2012 02:27:00 +0100 (BST) [thread overview]
Message-ID: <87sjdhily5@ch.ristopher.com> (raw)
In-Reply-To: <87r4t1sk9o.fsf@web.de> (Michael Heerdegen's message of "Wed, 27 Jun 2012 01:53:07 +0200")
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Background: `wdired-finish-edit' calls `revert-buffer', which will
> call `dired-revert'. Before this is called, everything is ok. But
> `dired-revert' fails to remember the mark and the position of the
> renamed file correctly. I didn't dig any further, but I guess a
> specialized revert function is needed for `wdired-finish-edit'.
This patch for wdired.el fixes the problem here (GNU Emacs 24.1.1).
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: wdired-finish-edit-remeber-marks.diff --]
[-- Type: text/x-diff, Size: 1188 bytes --]
diff --git a/wdired.el b/wdired-fixed.el
index fe5b4ef..d241d2e 100644
--- a/wdired.el
+++ b/wdired-fixed.el
@@ -350,7 +350,8 @@ non-nil means return old filename."
(interactive)
(wdired-change-to-dired-mode)
(let ((changes nil)
- (errors 0)
+ (errors 0)
+ (marks (dired-remember-marks (point-min) (point-max)))
files-deleted
files-renamed
some-file-names-unchanged
@@ -376,6 +377,9 @@ non-nil means return old filename."
(setq changes t)
(if (not file-new) ;empty filename!
(push file-old files-deleted)
+ (push (cons (substitute-in-file-name file-new)
+ (cdr (assoc file-old marks)))
+ marks)
(push (cons file-old (substitute-in-file-name file-new))
files-renamed))))
(forward-line -1)))
@@ -393,7 +397,8 @@ non-nil means return old filename."
(= (length files-renamed) 1))
(setq dired-directory (cdr (car files-renamed))))
;; Re-sort the buffer.
- (revert-buffer))
+ (revert-buffer)
+ (dired-mark-remembered marks))
(let ((inhibit-read-only t))
(remove-text-properties (point-min) (point-max)
'(old-name nil end-name nil old-link nil
[-- Attachment #3: Type: text/plain, Size: 21 bytes --]
Christopher
next prev parent reply other threads:[~2012-06-27 1:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 23:53 bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files Michael Heerdegen
2012-06-27 0:57 ` Drew Adams
2012-06-27 1:27 ` Christopher Schmidt [this message]
2012-06-27 14:20 ` Drew Adams
2012-06-27 14:47 ` Christopher Schmidt
2012-06-27 14:59 ` Drew Adams
2012-06-27 17:39 ` Michael Heerdegen
2012-06-27 18:02 ` Christopher Schmidt
2012-06-27 21:05 ` Michael Heerdegen
2012-07-04 4:02 ` Michael Heerdegen
2012-07-04 9:18 ` martin rudalics
2012-07-04 12:29 ` Stefan Monnier
2012-08-22 4:44 ` Michael Heerdegen
2012-08-22 7:08 ` martin rudalics
2012-08-29 15:19 ` Christopher Schmidt
2012-08-29 16:15 ` Michael Heerdegen
2012-08-29 17:22 ` martin rudalics
2012-10-03 9:14 ` martin rudalics
2012-10-04 23:52 ` Michael Heerdegen
2012-10-05 7:05 ` martin rudalics
2012-10-09 0:41 ` Michael Heerdegen
2012-10-15 23:01 ` Michael Heerdegen
2012-10-16 9:39 ` martin rudalics
2012-10-17 9:37 ` martin rudalics
2012-10-17 9:51 ` Christopher Schmidt
2012-10-18 9:15 ` martin rudalics
2012-10-23 8:05 ` Juri Linkov
2012-10-24 13:31 ` Michael Heerdegen
2012-10-25 9:03 ` Juri Linkov
2012-10-27 9:18 ` Juri Linkov
2012-10-27 12:55 ` Michael Heerdegen
2012-10-27 14:38 ` Juri Linkov
2012-11-22 9:12 ` Juri Linkov
2012-11-22 15:28 ` Stefan Monnier
2012-11-23 7:29 ` Juri Linkov
2012-11-23 0:04 ` Michael Heerdegen
2012-11-23 7:30 ` Juri Linkov
2012-11-25 9:12 ` Juri Linkov
2013-01-19 6:32 ` Michael Heerdegen
2013-01-19 10:37 ` Juri Linkov
2013-01-20 5:15 ` Michael Heerdegen
2020-09-21 14:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjdhily5@ch.ristopher.com \
--to=christopher@ch.ristopher.com \
--cc=11795@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).