bug#12002: 24.1.50; ERC nick change trouble

bug#12002: 24.1.50; ERC nick change trouble

[Antoine Levitt]

Hi,

There's a bug in ERC nick change handling. Imagine you have a query with
john, who has a timeout. He then comes back as john-, and queries
you. Then, when his old timeout goes away, he changes nick back to
john. The ERC response handler then tries to change the john- query
buffer name to john, which clashes with the old buffer. Since there was
an error in the execution flow, everything is messed up.

Here's a patch that doesn't try to change the name back when a buffer of
the same name exists. It still notifies the old query buffer of the name
change though. I haven't tested it but it should be fine. (I think ...)

I'm not holding my breath on this, because of the lack of activity of
ERC maintainers. Still, at least the patch is out there.

diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el
index cce24e6..115c31f 100644
--- a/lisp/erc/erc-backend.el
+++ b/lisp/erc/erc-backend.el
@@ -1313,10 +1313,11 @@ add things to `%s' instead."
       (erc-buffer-filter
        (lambda ()
          (when (equal (erc-default-target) nick)
-           (setq erc-default-recipients
-                 (cons nn (cdr erc-default-recipients)))
-           (rename-buffer nn)
-           (erc-update-mode-line)
+           (unless (get-buffer nn)
+             (setq erc-default-recipients
+                   (cons nn (cdr erc-default-recipients)))
+             (rename-buffer nn)
+             (erc-update-mode-line))
            (add-to-list 'bufs (current-buffer)))))
       (erc-update-user-nick nick nn host nil nil login)
       (cond

bug#12002: 24.1.50; ERC nick change trouble

[Glenn Morris]

Version: 24.3

Thanks. I installed a simpler change (below). Please let me know if it
is not ok, since I don't use erc.

*** lisp/erc/erc-backend.el	2012-10-06 01:04:53 +0000
--- lisp/erc/erc-backend.el	2012-10-07 01:25:39 +0000
***************
*** 1316,1322 ****
           (when (equal (erc-default-target) nick)
             (setq erc-default-recipients
                   (cons nn (cdr erc-default-recipients)))
!            (rename-buffer nn)
             (erc-update-mode-line)
             (add-to-list 'bufs (current-buffer)))))
        (erc-update-user-nick nick nn host nil nil login)
--- 1316,1322 ----
           (when (equal (erc-default-target) nick)
             (setq erc-default-recipients
                   (cons nn (cdr erc-default-recipients)))
!            (rename-buffer nn t)         ; bug#12002
             (erc-update-mode-line)
             (add-to-list 'bufs (current-buffer)))))
        (erc-update-user-nick nick nn host nil nil login)