From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.bugs Subject: bug#12823: Invalid font name Date: Tue, 27 Nov 2012 23:26:27 +0900 Message-ID: <87sj7vxgto.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354026653 29970 80.91.229.3 (27 Nov 2012 14:30:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Nov 2012 14:30:53 +0000 (UTC) Cc: 12823@debbugs.gnu.org To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 27 15:31:04 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TdMBk-0000LR-7R for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Nov 2012 15:31:04 +0100 Original-Received: from localhost ([::1]:54509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdMBZ-0007pW-3J for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Nov 2012 09:30:53 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdMBT-0007pQ-8q for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 09:30:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdMBS-0006Hl-09 for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 09:30:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdMBR-0006Hh-Sk for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 09:30:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TdMCl-00031x-6x for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2012 09:32:24 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Nov 2012 14:32:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135402667111581 (code B ref 12823); Tue, 27 Nov 2012 14:32:06 +0000 Original-Received: (at 12823) by debbugs.gnu.org; 27 Nov 2012 14:31:11 +0000 Original-Received: from localhost ([127.0.0.1]:41361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdMBf-00030U-Nz for submit@debbugs.gnu.org; Tue, 27 Nov 2012 09:31:07 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:34446) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TdMAy-0002zd-1Q for 12823@debbugs.gnu.org; Tue, 27 Nov 2012 09:30:26 -0500 Original-Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:64027 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TdM9B-0000Cr-H2; Tue, 27 Nov 2012 09:28:26 -0500 In-Reply-To: <87wqxnro1f.fsf@gnu.org> (message from Kenichi Handa on Thu, 15 Nov 2012 22:30:52 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67508 Archived-At: For fixing this bug, I've just installed this change to trunk (rev. 111019). But, as the bug had caused crashing, it may be better to apply the change to emacs-24. --- Kenichi Handa handa@gnu.org === modified file 'src/ChangeLog' --- src/ChangeLog 2012-11-27 05:38:42 +0000 +++ src/ChangeLog 2012-11-27 13:40:38 +0000 @@ -1,3 +1,13 @@ +2012-11-18 Kenichi Handa + + * font.c (font_unparse_xlfd): Fix previous change. Keep "const" + for the variable "f". + +2012-11-13 Kenichi Handa + + * font.c (font_unparse_xlfd): Exclude special characters from the + generating XLFD name. + 2012-11-27 Paul Eggert Assume POSIX 1003.1-1988 or later for grp.h, pwd.h. === modified file 'src/font.c' --- src/font.c 2012-11-06 13:26:20 +0000 +++ src/font.c 2012-11-27 13:40:38 +0000 @@ -1234,8 +1234,21 @@ f[j] = "*"; else { + int c, k, l; + ptrdiff_t alloc; + val = SYMBOL_NAME (val); - f[j] = SSDATA (val); + alloc = SBYTES (val) + 1; + if (nbytes <= alloc) + return -1; + f[j] = p = alloca (alloc); + /* Copy the name while excluding '-', '?', ',', and '"'. */ + for (k = l = 0; k < alloc; k++) + { + c = SREF (val, k); + if (c != '-' && c != '?' && c != ',' && c != '"') + p[l++] = c; + } } }