From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 12615@debbugs.gnu.org, Harald Hanche-Olsen <hanche@math.ntnu.no>
Subject: bug#12615: 24.2.50; Non-ignored case in insert-char
Date: Tue, 08 Jan 2013 02:45:45 +0200 [thread overview]
Message-ID: <87sj6ccxj8.fsf@mail.jurta.org> (raw)
In-Reply-To: <878v89u7pg.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 04 Jan 2013 02:13:13 +0200")
In light of the incoming pretest I propose to fix the regression now in
the emacs-24 branch (the test case for the regression is `C-x 8 RET *acc TAB')
with the patch below, and later think about another fix for trunk
(I still have no idea for a better fix) that doesn't cause a regression.
=== modified file 'lisp/international/mule-cmds.el'
--- lisp/international/mule-cmds.el 2013-01-01 09:11:05 +0000
+++ lisp/international/mule-cmds.el 2013-01-06 00:19:17 +0000
@@ -2945,14 +2945,13 @@ (defun read-char-by-name (prompt)
This function also accepts a hexadecimal number of Unicode code
point or a number in hash notation, e.g. #o21430 for octal,
#x2318 for hex, or #10r8984 for decimal."
- (let ((input
- (completing-read
+ (let* ((completion-ignore-case t)
+ (input (completing-read
prompt
(lambda (string pred action)
- (let ((completion-ignore-case t))
(if (eq action 'metadata)
'(metadata (category . unicode-name))
- (complete-with-action action (ucs-names) string pred)))))))
+ (complete-with-action action (ucs-names) string pred))))))
(cond
((string-match-p "\\`[0-9a-fA-F]+\\'" input)
(string-to-number input 16))
next prev parent reply other threads:[~2013-01-08 0:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:36 bug#12615: 24.2.50; Non-ignored case in insert-char Harald Hanche-Olsen
2012-10-10 18:03 ` Harald Hanche-Olsen
2012-10-10 19:30 ` Andreas Schwab
2012-10-10 21:31 ` Glenn Morris
2012-10-11 6:32 ` Harald Hanche-Olsen
2012-10-11 0:56 ` Stefan Monnier
2012-10-11 6:37 ` Harald Hanche-Olsen
2012-10-11 20:12 ` Stefan Monnier
2012-12-29 22:56 ` Juri Linkov
2013-01-04 0:13 ` Juri Linkov
2013-01-08 0:45 ` Juri Linkov [this message]
2013-01-08 3:19 ` Stefan Monnier
2013-01-09 0:20 ` Juri Linkov
2013-01-09 2:41 ` Stefan Monnier
2013-01-10 0:24 ` Juri Linkov
2013-01-10 2:50 ` Stefan Monnier
2020-09-13 16:33 ` Lars Ingebrigtsen
2022-04-22 12:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj6ccxj8.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=12615@debbugs.gnu.org \
--cc=hanche@math.ntnu.no \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).