From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Date: Fri, 10 May 2013 21:06:15 +0200 Message-ID: <87sj1u64ew.fsf@rosalinde.fritz.box> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368212827 11421 80.91.229.3 (10 May 2013 19:07:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 May 2013 19:07:07 +0000 (UTC) Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 10 21:07:05 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uasen-000254-AY for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2013 21:07:05 +0200 Original-Received: from localhost ([::1]:44996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uasem-0000ag-SW for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2013 15:07:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uasec-0000aF-J5 for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 15:07:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaseZ-0006yb-Av for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 15:06:54 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaseZ-0006yV-6u for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 15:06:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Uasek-0003TG-Bm for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 15:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2013 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 2749-submit@debbugs.gnu.org id=B2749.136821279713264 (code B ref 2749); Fri, 10 May 2013 19:07:02 +0000 Original-Received: (at 2749) by debbugs.gnu.org; 10 May 2013 19:06:37 +0000 Original-Received: from localhost ([127.0.0.1]:35892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaseK-0003Rq-RO for submit@debbugs.gnu.org; Fri, 10 May 2013 15:06:37 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:51564) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaseH-0003Rg-Se for 2749@debbugs.gnu.org; Fri, 10 May 2013 15:06:35 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.33]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Lx1bL-1UU8OL3VZR-016j3c for <2749@debbugs.gnu.org>; Fri, 10 May 2013 21:06:20 +0200 Original-Received: (qmail invoked by alias); 10 May 2013 19:06:20 -0000 Original-Received: from i59F57249.versanet.de (EHLO rosalinde.fritz.box) [89.245.114.73] by mail.gmx.net (mp033) with SMTP; 10 May 2013 21:06:20 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX18uBSEE+18u1ZQhejyTw35BghsJ5toF5y2Ouxp6DB pVh/JCvpNxBkoO In-Reply-To: <83ehdebut7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2013 20:37:08 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74136 Archived-At: On Fri, 10 May 2013 20:37:08 +0300 Eli Zaretskii wrote: >> From: Stephen Berman [...] >> (I wish I understood why this problem occurred and how your patch >> fixes it...) [...] > I can give you a vague idea of why the problem occurred. [...] Thanks for the explanation. >> Unless someone knows of another problem with allowing >> overflow-newline-into-fringe in Visual Line mode, I would like to >> request that both my patch and yours be committed to the trunk > > Do you use Org mode or any other modes (e.g., magit) that are heavy > users of display strings? I don't use either of those modes, but I have been developing a new version of todo-mode.el for a very long time (which I plan to submit for possible inclusion in Emacs, hopefully before the next pretest begins) and it uses before-string overlays, on the order of hundreds per buffer (though most are not in the visible window at any time), as well as word-wrap and wrap-prefix. > If not, then I'm not prepared to believe > that the above is the only problem with this change. I'd like to see > much more reports from users of those modes that this change doesn't > cause any trouble, before I'd agree to installing it. Just look how > much time it took until this problem popped up. Since I knew the only > change was in a single macro that is used in a small number of places, > fixing it was a 5-min job. But imagine that the same would happen 3 > years after committing this change, with gazillions of unrelated > changes in the display code since then. I may be misunderstanding you here, but it sounds like you think the patch to enable overflow-newline-into-fringe in Visual Line mode is already in the trunk; it isn't. This bug report was initiated more than four years ago by someone (not me) who noticed the odd display of a line whose length is window-width when Visual Line mode is enabled. Chong Yidong pointed out that this was because fringe overflow was disabled in Visual Line mode and he suspected "confusing results" if it were enabled. Then this past February, almost four years later, I posted that I had enabled it in my local branch and had not observed any problems. I've been using it since then and only today hit the problem that I reported and you quickly fixed. Nobody using the vanilla trunk can have run into the problem, because fringe overflow is still disabled in Visual Line mode there. But if it were now enabled (with my patch) and your patch were also added (to prevent the problem I reported today), then Org and magit users and others will be able to see if other problems do arise. Does this make sense, or have I completely misunderstood you? Steve Berman