From: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,
Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>,
16141@debbugs.gnu.org
Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
Date: Sun, 22 Dec 2013 10:56:53 +0900 [thread overview]
Message-ID: <87sitlir6i.fsf@dhcp-193-97.nrt.redhat.com> (raw)
In-Reply-To: <87d2kqc4mb.fsf@flea.lifelogs.com>
> It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
Sorry, it's my mistake. This is proper patch.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-tag-select): Add text-property to jump to
next select field.
---
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 15bb2c0..cd59380 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -847,6 +847,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/
(put-text-property start (point) 'eww-form menu)
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
+ (unless (= start (point))
+ (put-text-property start (1+ start) 'help-echo "select field"))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
--
Kenjiro NAKAYAMA
tzz@lifelogs.com writes:
> On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote:
>
>>> Such comments should describe what the change *does* rather than what it
>>> *did*, i.e. use the present tense (and capitalize the word after the
>>> colon since it starts a sentence).
>
> KN> Thank you Stefan.
>
> KN> I resend patch with a fixed comment.
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
> KN> * net/eww.el (eww-tag-select): Add text-property to jump to
> KN> next select field.
>
> It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
>
> Thanks
> Ted
next prev parent reply other threads:[~2013-12-22 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 12:05 bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field Nakayama Kenjiro
2013-12-14 14:22 ` Stefan Monnier
2013-12-14 16:18 ` Kenjiro NAKAYAMA
2013-12-21 20:48 ` Ted Zlatanov
2013-12-22 1:56 ` Kenjiro NAKAYAMA [this message]
2013-12-22 22:41 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sitlir6i.fsf@dhcp-193-97.nrt.redhat.com \
--to=nakayamakenjiro@gmail.com \
--cc=16141@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).