From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#16969: Isearch: lazy-highlight face sometimes has foreground and background the same colour. Date: Sun, 09 Mar 2014 23:43:52 +0200 Organization: JURTA Message-ID: <87siqroxnr.fsf@mail.jurta.org> References: <20140308183550.GA2726@acm.acm> <871tycfj8e.fsf@mail.jurta.org> <531BB993.6060507@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394401933 17893 80.91.229.3 (9 Mar 2014 21:52:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Mar 2014 21:52:13 +0000 (UTC) Cc: Alan Mackenzie , 16969@debbugs.gnu.org To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 09 22:52:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WMldq-0007MC-PQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 22:52:18 +0100 Original-Received: from localhost ([::1]:45641 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMldq-0001O1-G1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 17:52:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMldg-0001Nh-H0 for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 17:52:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMlda-0007Pv-Gj for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 17:52:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMlda-0007Pr-D6 for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 17:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WMldZ-0000tm-Ur for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 17:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Mar 2014 21:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16969 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16969-submit@debbugs.gnu.org id=B16969.13944019173438 (code B ref 16969); Sun, 09 Mar 2014 21:52:01 +0000 Original-Received: (at 16969) by debbugs.gnu.org; 9 Mar 2014 21:51:57 +0000 Original-Received: from localhost ([127.0.0.1]:58436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMldU-0000tO-8d for submit@debbugs.gnu.org; Sun, 09 Mar 2014 17:51:56 -0400 Original-Received: from [69.163.184.122] (port=49702 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMldR-0000tB-Vr for 16969@debbugs.gnu.org; Sun, 09 Mar 2014 17:51:54 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 1C9F7300031E4F; Sun, 9 Mar 2014 14:51:51 -0700 (PDT) In-Reply-To: <531BB993.6060507@dancol.org> (Daniel Colascione's message of "Sat, 08 Mar 2014 16:45:07 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86696 Archived-At: >> But the problem needs to be fixed anyway. So maybe we could add the >> face attribute :distant-foreground to the `lazy-highlight' face >> that could be applied only when the background color is near to the >> foreground color like a cyan foreground on a cyan background > > And what? Are we going to apply distant-foreground to everything and > hope that the color we choose is legible in whatever theme the user has? We need to guarantee that default faces don't produce illegible combinations of foreground and background colors. This can be achieved by using :distant-foreground on the default face definition. A user redefining the face can also manually adjust :distant-foreground to use another color if the user doesn't like the default color used when the distance is more than the threshold. > We really need automatic contrast adjustment, not one-off fixes. Automatic contrast adjustment is useful too when the user has no preference for a color to use instead of an illegible color and want to adjust all such colors automatically. There is a request in bug#16974 for this feature.