From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#17322: 24.3.90; emacs crash at eassert (verify_row_hash (a)) in dispnew.c:1169 Date: Wed, 23 Apr 2014 17:49:24 +0200 Message-ID: <87sip4cagr.fsf@geodiff-mac3.ulb.ac.be> References: <871twofh4y.fsf@geodiff-mac3.ulb.ac.be> <83k3ag9kdb.fsf@gnu.org> <5357D423.1030507@yahoo.fr> <831two9hzu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1398268163 7311 80.91.229.3 (23 Apr 2014 15:49:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Apr 2014 15:49:23 +0000 (UTC) Cc: 17322@debbugs.gnu.org, Nicolas Richard To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 23 17:49:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WczQC-0006Wx-JI for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Apr 2014 17:49:16 +0200 Original-Received: from localhost ([::1]:33446 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WczQC-00015y-3J for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Apr 2014 11:49:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WczQ3-0000yp-Lb for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 11:49:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WczPy-0007j2-V2 for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 11:49:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WczPy-0007iw-Rg for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 11:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WczPy-0000h9-5E for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Apr 2014 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17322 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17322-submit@debbugs.gnu.org id=B17322.13982681342654 (code B ref 17322); Wed, 23 Apr 2014 15:49:02 +0000 Original-Received: (at 17322) by debbugs.gnu.org; 23 Apr 2014 15:48:54 +0000 Original-Received: from localhost ([127.0.0.1]:56303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WczPp-0000gi-7X for submit@debbugs.gnu.org; Wed, 23 Apr 2014 11:48:53 -0400 Original-Received: from mxin.ulb.ac.be ([164.15.128.112]:16934) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WczPm-0000gU-3C for 17322@debbugs.gnu.org; Wed, 23 Apr 2014 11:48:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUIAMffV1OkD4Xx/2dsb2JhbABZg1WrH5kvPYEwdIIlAQEEASdEDgULCxQBDCUPAQRJE4gsAQMJCA2sUZsEAYcrEwSHWYRnghgHhDkElwuILYQpghaFU4FygUE7 Original-Received: from mathsrv4.ulb.ac.be (HELO geodiff-mac3.ulb.ac.be) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 23 Apr 2014 17:48:43 +0200 In-Reply-To: <831two9hzu.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Apr 2014 18:35:01 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88256 Archived-At: Eli Zaretskii writes: >> Date: Wed, 23 Apr 2014 16:54:27 +0200 >> From: Nicolas Richard >> CC: 17322@debbugs.gnu.org >> >> (gdb) frame 2 >> #2 0x08059979 in row_equal_p (a=0xa25151c, b=0xb2a0afc, mouse_face_p=true) at dispnew.c:1169 >> 1169 eassert (verify_row_hash (a)); >> (gdb) pgrowx a >> TEXT: 19 glyphs >> 0 0: CHAR[7] pos=993 blev=0,btyp=L w=9 a+d=14+5 face=36 MB >> 1 9: CHAR[1] pos=994 blev=0,btyp=L w=9 a+d=14+5 face=36 MB >> 2 18: CHAR[0] pos=995 blev=0,btyp=L w=9 a+d=14+5 face=36 MB >> 3 27: CHAR[e] pos=996 blev=0,btyp=L w=9 a+d=14+5 face=36 MB >> 4 36: CHAR[e] pos=997 blev=0,btyp=L w=9 a+d=14+5 face=36 MB >> 5 45: CHAR[8] pos=998 blev=0,btyp=L w=9 a+d=14+5 face=36 MB >> 6 54: CHAR[7] pos=999 blev=0,btyp=L w=9 a+d=14+5 face=36 MB >> 7 63: CHAR[ ] pos=1000 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 8 72: CHAR[*] pos=1001 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 9 81: CHAR[ ] pos=1002 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 10 90: CHAR[c] pos=1003 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 11 99: CHAR[ ] pos=1004 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 12 108: CHAR[o] pos=1005 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 13 117: CHAR[ ] pos=1006 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 14 126: CHAR[l] pos=1007 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 15 135: CHAR[d] pos=1008 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 16 144: CHAR[l] pos=1009 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 17 153: CHAR[c] pos=1010 blev=0,btyp=L w=9 a+d=14+5 face=26 MB >> 18 162: CHAR[ ] pos=0 blev=0,btyp=B w=9 a+d=14+5 face=26 MB >> RIGHT: 1 glyphs >> 0 171: COMP[0 (32776..21)] pos=-1 w=1012 a+d=0+-9539 face=5 vof=2388 MB slice=32776,0,21,0 >> (gdb) pgrowx b >> TEXT: 19 glyphs >> 0 0: CHAR[7] pos=993 blev=0,btyp=L w=9 a+d=14+5 face=21 MB >> 1 9: CHAR[1] pos=994 blev=0,btyp=L w=9 a+d=14+5 face=21 MB >> 2 18: CHAR[0] pos=995 blev=0,btyp=L w=9 a+d=14+5 face=21 MB >> 3 27: CHAR[e] pos=996 blev=0,btyp=L w=9 a+d=14+5 face=21 MB >> 4 36: CHAR[e] pos=997 blev=0,btyp=L w=9 a+d=14+5 face=21 MB >> 5 45: CHAR[8] pos=998 blev=0,btyp=L w=9 a+d=14+5 face=21 MB >> 6 54: CHAR[7] pos=999 blev=0,btyp=L w=9 a+d=14+5 face=21 MB >> 7 63: CHAR[ ] pos=1000 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 8 72: CHAR[*] pos=1001 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 9 81: CHAR[ ] pos=1002 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 10 90: CHAR[c] pos=1003 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 11 99: CHAR[ ] pos=1004 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 12 108: CHAR[o] pos=1005 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 13 117: CHAR[ ] pos=1006 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 14 126: CHAR[l] pos=1007 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 15 135: CHAR[d] pos=1008 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 16 144: CHAR[l] pos=1009 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 17 153: CHAR[c] pos=1010 blev=0,btyp=L w=9 a+d=14+5 face=11 MB >> 18 162: CHAR[ ] pos=0 blev=0,btyp=B w=9 a+d=14+5 MB >> (gdb) >> >> fwiw, the chars in the brackets above correspond to a git abbreviated sha1 and a commit message as displayed e.g. in magit log buffers. > > Yes, but these two glyph rows _are_ different: they have different > faces (see the "face=" parts), and also one of them has something > displayed in the right display margin, while the other doesn't. > > Can you tell which part(s) of magit make these changes to the > displayed material? I'd say magit-refresh-log-buffer which is defined in magit.el [1], but I'm no magit expert. The margins are used to show the author name and the time elapsed since the commit was made. (magit-log, as you guess, shows a log of commits). [1] The version I have can be seen here: https://github.com/magit/magit/blob/2c9e428e180c386bb8684166bca8638991ac0f0a/magit.el#L6309 > Also, what do these commands display? > > (gdb) p/x a->hash > (gdb) p/x row_hash(a) (gdb) p/x a->hash $4 = 0x7d9d3df (gdb) p/x row_hash(a) $5 = 0x7d9d3c8 (gdb) -- Nico.