From: David Engster <deng@randomsample.de>
To: Lars Ljung <lars@matholka.se>
Cc: 18476@debbugs.gnu.org
Subject: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep
Date: Mon, 15 Sep 2014 22:16:10 +0200 [thread overview]
Message-ID: <87sijsljw5.fsf@engster.org> (raw)
In-Reply-To: <5415DA37.8050904@matholka.se> (Lars Ljung's message of "Sun, 14 Sep 2014 20:11:03 +0200")
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Lars Ljung writes:
> Every time I open a file in the Emacs source tree I see the message
> "ede-emacs-version: Searching for program: no such file or directory,
> egrep". Also, Emacs does not switch to the newly created buffer so I
> have to switch to it manually.
>
> This only happens on Windows, where I don't have egrep installed. It is
> caused by line 86 in lisp/cedet/ede/emacs.el:
>
> (call-process "egrep" nil buff nil "-n" "-e" "AC_INIT" configure_ac)
>
> I don't think this line is even necessary. The file content is inserted
> and parsed further down.
Indeed. That call to egrep seems to be some relict from the old
days. Additionally, we should also make sure that configure.ac or
configure.in exist.
Stefan, would it be OK to install the attached patch to emacs-24, or
should it go to trunk?
-David
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ede-emacs-patch.diff --]
[-- Type: text/x-diff, Size: 990 bytes --]
=== modified file 'lisp/cedet/ede/emacs.el'
--- lisp/cedet/ede/emacs.el 2014-04-02 15:14:50 +0000
+++ lisp/cedet/ede/emacs.el 2014-09-15 20:10:45 +0000
@@ -82,10 +82,6 @@
(setq default-directory (file-name-as-directory dir))
(or (file-exists-p configure_ac)
(setq configure_ac "configure.in"))
- ;(call-process "egrep" nil buff nil "-n" "-e" "^version=" "Makefile")
- (call-process "egrep" nil buff nil "-n" "-e" "AC_INIT" configure_ac)
- (goto-char (point-min))
- ;(re-search-forward "version=\\([0-9.]+\\)")
(cond
;; Maybe XEmacs?
((file-exists-p "version.sh")
@@ -113,7 +109,8 @@
;; Insert other Emacs here...
;; Vaguely recent version of GNU Emacs?
- (t
+ ((or (file-exists-p configure_ac)
+ (file-exists-p (setq configure_ac "configure.in")))
(insert-file-contents configure_ac)
(goto-char (point-min))
(re-search-forward "AC_INIT(\\(?:GNU \\)?[eE]macs,\\s-*\\([0-9.]+\\)\\s-*[,)]")
next prev parent reply other threads:[~2014-09-15 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 18:11 bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep Lars Ljung
2014-09-15 20:16 ` David Engster [this message]
2014-09-16 0:17 ` Stefan Monnier
2014-09-16 6:13 ` David Engster
2014-09-16 13:50 ` Stefan Monnier
2014-09-16 21:33 ` David Engster
2014-09-17 1:05 ` Stefan Monnier
2014-09-18 20:40 ` David Engster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sijsljw5.fsf@engster.org \
--to=deng@randomsample.de \
--cc=18476@debbugs.gnu.org \
--cc=lars@matholka.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).