bug#18599: erc-input-ring-setup: do not reset the ring when there already is one

bug#18599: erc-input-ring-setup: do not reset the ring when there already is one

[Ivan Shmakov]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Package: emacs
X-Debbugs-Cc: erc-discuss@gnu.org, Kashish Sharma <music.kashish@gmail.com>

>>>>> Kashish Sharma <music.kashish@gmail.com> writes:

[…]

 > 2. (what seems like another bug -) Input history is lost if one
 > disconnects/reconnects.

	Please consider the patch MIMEd.

	(This one was also recently pointed out on IRC, BTW.)

 > Wishlist - input history remembered across Emacs sessions.  Perhaps
 > with the option of setting the history size.

[…]

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 452 bytes --]

--- a/lisp/erc/erc-ring.el
+++ b/lisp/erc/erc-ring.el
@@ -67,7 +67,8 @@
 (defun erc-input-ring-setup ()
   "Do the setup required so that we can use comint style input rings.
 Call this function when setting up the mode."
-  (setq erc-input-ring (make-ring comint-input-ring-size))
+  (unless (ring-p erc-input-ring)
+    (setq erc-input-ring (make-ring comint-input-ring-size)))
   (setq erc-input-ring-index nil))
 
 (defun erc-add-to-input-ring (s)

bug#18599: erc-input-ring-setup: do not reset the ring when there already is one

[Ivan Shmakov]

Version: 24.5

	I no longer observe the issue (as of 2014-11-18 build,
	cb4f666ade76.)  Per my reading of the Git log, it was fixed in
	Git master back this October:

commit 3af2917c91e4eb863e1cec92a68ccb3acf940dae
Author:     Ivan Shmakov <ivan@siamics.net>
AuthorDate: Thu Oct 2 07:31:56 2014 -0400
Commit:     Kelvin White <kwhite@gnu.org>
CommitDate: Thu Oct 2 07:31:56 2014 -0400

    Do not reset input ring if one exists
    
    Fixes: debbugs:18599

	In emacs-24, this bug was fixed as part of the following
	“backport” change:

commit d1036d288de1e047f7f6043188a1063f0d6b044d
Author:     l3thal <l3thal@debian>
AuthorDate: Sat Nov 8 20:51:43 2014 -0500
Commit:     l3thal <l3thal@debian>
CommitDate: Sat Nov 8 20:51:43 2014 -0500

    backport: erc bugfixes

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A