unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Anders Lindgren <andlind@gmail.com>
Cc: 22145@debbugs.gnu.org
Subject: bug#22145: 25.0.50; tramp and auto-revert tests hang on OS X
Date: Fri, 25 Dec 2015 10:56:24 +0100	[thread overview]
Message-ID: <87si2qc0mv.fsf@gmx.de> (raw)
In-Reply-To: <CABr8ebaB1SqyrOSTXkQNSsf+bAd-JqBAYDR8_BiTsBikG-Eykw@mail.gmail.com> (Anders Lindgren's message of "Tue, 22 Dec 2015 23:32:24 +0100")

Anders Lindgren <andlind@gmail.com> writes:

> Hi!

Hi Anders,

> Test tramp-test29-vc-registered condition:
>     (error "Running bzr init ....FAILED (status 1)")
>    FAILED  30/42  tramp-test29-vc-registered

There is a problem in creating a temporary bzr repository. This is not
related to the test itself; I've committed a patch which shall make the
test more robust (not fail) in this case.

> Test tramp-test32-utf8 condition:
>     (ert-test-failed
>      ((should
>        (equal
> 	(directory-files tmp-name1 nil directory-files-no-dot-files-regexp)
> 	(sort ... ...)))
>       :form
>       (equal
>        ("“…¹ƒ„µ „¿ “±»±¾¹± ¼µ ©„¿ £„¿€" "²‚¾‚¾¿¾¼ ¿¾ ³°»°º‚¸ºµ" "“泳櫸指—³åˆ—")
>        ("“…¯ƒ„µ „¿ “±»±¾¯± ¼µ „¿ £„¿€" "²‚¾‚¾¿¾¼ ¿¾ ³°»°º‚¸ºµ" "“泳櫸指—³åˆ—"))
>       :value nil :explanation
>       (list-elt 0
> 		(arrays-of-different-length 33 30 "“…¹ƒ„µ „¿ “±»±¾¹± ¼µ ©„¿ £„¿€" "“…¯ƒ„µ „¿ “±»±¾¯± ¼µ „¿ £„¿€" first-mismatch-at 3))))
>    FAILED  36/42  tramp-test32-utf8

I have observed, that since my commit 0ad27a5aab529d507829c60fa79aad9866f492ab
from Dec 15, the strings are not encoded properly anymore. Could you pls
check, whether the following patch (reverting that change) solves this?
If not, pls send tramp-tests.log, again.

--8<---------------cut here---------------start------------->8---
*** ~/src/emacs-25/lisp/net/tramp-sh.el.~emacs-25~	2015-12-25 10:52:51.759874716 +0100
--- ~/src/emacs-25/lisp/net/tramp-sh.el	2015-12-25 10:44:28.084420801 +0100
***************
*** 4218,4229 ****
  	  (setq cs-encode (cdr cs))
  	  (unless cs-decode (setq cs-decode 'undecided))
  	  (unless cs-encode (setq cs-encode 'undecided))
! 	  (setq cs-encode
! 		(tramp-compat-coding-system-change-eol-conversion
! 		 cs-encode
! 		 (if (string-match
! 		      "^Darwin" (tramp-get-connection-property vec "uname" ""))
! 		     'mac 'unix)))
  	  (tramp-send-command vec "echo foo ; echo bar" t)
  	  (goto-char (point-min))
  	  (when (search-forward "\r" nil t)
--- 4218,4225 ----
  	  (setq cs-encode (cdr cs))
  	  (unless cs-decode (setq cs-decode 'undecided))
  	  (unless cs-encode (setq cs-encode 'undecided))
! 	  (setq cs-encode (tramp-compat-coding-system-change-eol-conversion
! 			   cs-encode 'unix))
  	  (tramp-send-command vec "echo foo ; echo bar" t)
  	  (goto-char (point-min))
  	  (when (search-forward "\r" nil t)
--8<---------------cut here---------------end--------------->8---

> -- Anders

Best regards, Michael.





  parent reply	other threads:[~2015-12-25  9:56 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  6:46 bug#22145: 25.0.50; tramp and auto-revert tests hang on OS X Anders Lindgren
2015-12-12  9:31 ` Michael Albinus
2015-12-12 18:35   ` Anders Lindgren
2015-12-12 19:21     ` Michael Albinus
2015-12-12 21:05       ` Anders Lindgren
2015-12-13  9:02         ` Michael Albinus
2015-12-13 15:36           ` Eli Zaretskii
2015-12-13 21:44           ` Anders Lindgren
2015-12-15 11:33             ` Michael Albinus
2015-12-15 19:56               ` Anders Lindgren
2015-12-15 22:57                 ` Michael Albinus
2015-12-16  6:26                   ` Anders Lindgren
2015-12-16 22:39                     ` Michael Albinus
2015-12-17 19:38                       ` Anders Lindgren
2015-12-18  8:12                         ` Michael Albinus
2015-12-18 19:55                           ` Anders Lindgren
2015-12-19 19:24                             ` Michael Albinus
2015-12-19 22:43                               ` Anders Lindgren
2015-12-20 12:30                                 ` Michael Albinus
2015-12-20 15:38                                   ` Anders Lindgren
2015-12-20 15:42                                     ` Michael Albinus
2015-12-20 17:31                                       ` Anders Lindgren
2015-12-20 17:55                                         ` Michael Albinus
2015-12-21 22:35                                           ` Anders Lindgren
2015-12-22 11:03                                             ` Michael Albinus
     [not found]                                               ` <CABr8ebaB1SqyrOSTXkQNSsf+bAd-JqBAYDR8_BiTsBikG-Eykw@mail.gmail.com>
2015-12-25  9:56                                                 ` Michael Albinus [this message]
2015-12-26  5:01                                                   ` Anders Lindgren
2015-12-26 19:56                                                     ` Michael Albinus
2015-12-26 21:41                                                       ` Anders Lindgren
2016-01-05 21:33                                               ` John Wiegley
2016-01-05 21:36                                                 ` Michael Albinus
2016-01-06  0:07                                                   ` John Wiegley
2016-01-06  4:53                                                     ` Michael Albinus
2016-01-06 18:39                                                       ` John Wiegley
2016-01-06 18:48                                                         ` Eli Zaretskii
2016-01-06 19:04                                                           ` John Wiegley
2016-01-07 20:03                                                             ` Michael Albinus
2016-01-07 20:31                                                               ` Anders Lindgren
2016-01-08  3:17                                                                 ` Random832
2016-01-08  6:03                                                                 ` Richard Stallman
2016-01-07 23:34                                                               ` John Wiegley
2016-01-08  9:13                                                                 ` Michael Albinus
2016-01-08  3:11                                                               ` Random832
2016-01-08  9:01                                                                 ` Michael Albinus
2016-01-08 13:39                                                                   ` Random832
2016-01-08 14:17                                                                     ` Michael Albinus
2016-01-08 17:40                                                                       ` Random832
2016-01-08 18:47                                                                         ` Michael Albinus
2016-01-08 20:14                                                                           ` Random832
2016-01-09 13:00                                                                             ` Michael Albinus
2016-01-09 13:06                                                                               ` Eli Zaretskii
2016-01-09 19:15                                                                                 ` Michael Albinus
2016-01-09 19:24                                                                                 ` Random832
2016-01-09 20:18                                                                                 ` Michael Albinus
2016-01-09 20:26                                                                                   ` Eli Zaretskii
2016-01-10  8:49                                                                                     ` Michael Albinus
2016-01-10 12:50                                                                                       ` Michael Albinus
     [not found]                                                                                         ` <m2fuvq2p62.fsf@newartisans.com>
2016-03-17 19:39                                                                                           ` Michael Albinus
2016-03-21 21:08                                                                                             ` John Wiegley
2016-03-22 10:09                                                                                               ` Michael Albinus
     [not found]                                                                                                 ` <87twjpi0nl.fsf@gmx.de>
     [not found]                                                                                                   ` <m2zithoz98.fsf@newartisans.com>
     [not found]                                                                                                     ` <87bn5widue.fsf@gmx.de>
     [not found]                                                                                                       ` <m260w3ex7p.fsf@newartisans.com>
     [not found]                                                                                                         ` <874mbnj4hi.fsf@gmx.de>
     [not found]                                                                                                           ` <m2wpojahsp.fsf@newartisans.com>
     [not found]                                                                                                             ` <87wpojhh8t.fsf@gmx.de>
     [not found]                                                                                                               ` <m2k2kjadov.fsf@newartisans.com>
     [not found]                                                                                                                 ` <878u0z6lty.fsf@gmx.de>
2016-04-01  8:36                                                                                                                   ` Michael Albinus
2016-04-02 21:38                                                                                                                     ` John Wiegley
2016-04-03  6:52                                                                                                                       ` Michael Albinus
2016-01-12 16:24                                                                               ` John Wiegley
2016-01-12 17:04                                                                               ` John Wiegley
2016-01-12 19:05                                                                                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si2qc0mv.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=22145@debbugs.gnu.org \
    --cc=andlind@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).