From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END Date: Fri, 29 Apr 2016 02:35:23 +0200 Message-ID: <87shy5z1ys.fsf@gnus.org> References: <484386ea-2d30-4f2b-9b2c-c67db0b5f280@default> <7759bdf5-7c4c-4b1f-a598-0a399ced4063@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461890182 24916 80.91.229.3 (29 Apr 2016 00:36:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2016 00:36:22 +0000 (UTC) Cc: 14844@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 02:36:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avwPi-0005v5-0b for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 02:36:10 +0200 Original-Received: from localhost ([::1]:51680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avwPh-0002ag-FO for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 20:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avwPd-0002Y0-SH for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 20:36:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avwPZ-0006ug-Rl for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 20:36:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avwPZ-0006uV-On for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 20:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avwPZ-0001Bi-KF for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 20:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Apr 2016 00:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14844-submit@debbugs.gnu.org id=B14844.14618901304530 (code B ref 14844); Fri, 29 Apr 2016 00:36:01 +0000 Original-Received: (at 14844) by debbugs.gnu.org; 29 Apr 2016 00:35:30 +0000 Original-Received: from localhost ([127.0.0.1]:53772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avwP4-0001B0-G9 for submit@debbugs.gnu.org; Thu, 28 Apr 2016 20:35:30 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:39734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avwP2-0001Ap-95 for 14844@debbugs.gnu.org; Thu, 28 Apr 2016 20:35:28 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avwOy-0002K8-Ph; Fri, 29 Apr 2016 02:35:26 +0200 In-Reply-To: <7759bdf5-7c4c-4b1f-a598-0a399ced4063@default> (Drew Adams's message of "Thu, 11 Jul 2013 08:49:39 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117141 Archived-At: Drew Adams writes: > Worse. It seems that the TO-END arg is not used *anywhere*, and should be > removed from `line-move' and `line-move-partial' as well. Too bad these > functions do not even have doc strings to explain what was intended by the > creation of this unused parameter. Well, it's certainly in the calls to it from simple.el: grep --color -nH -e "line-move-1" `find . -name '*.el'` ./simple.el:5930: (line-move-1 arg noerror to-end) ./simple.el:5941:;; This is like line-move-1 except that it also performs ./simple.el:5955: (line-move-1 arg noerror to-end) ./simple.el:5997: (line-move-1 arg noerror to-end))))) ./simple.el:5999:;; Display-based alternative to line-move-1. ./simple.el:6071:(defun line-move-1 (arg &optional noerror _to-end) I'll remove those from the calls, but I think the _to_end parameter will have to remain in the -1 function. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no