unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 14844@debbugs.gnu.org
Subject: bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END
Date: Fri, 29 Apr 2016 02:35:23 +0200	[thread overview]
Message-ID: <87shy5z1ys.fsf@gnus.org> (raw)
In-Reply-To: <7759bdf5-7c4c-4b1f-a598-0a399ced4063@default> (Drew Adams's message of "Thu, 11 Jul 2013 08:49:39 -0700 (PDT)")

Drew Adams <drew.adams@oracle.com> writes:

> Worse.  It seems that the TO-END arg is not used *anywhere*, and should be
> removed from `line-move' and `line-move-partial' as well.  Too bad these
> functions do not even have doc strings to explain what was intended by the
> creation of this unused parameter.

Well, it's certainly in the calls to it from simple.el:

grep --color -nH -e "line-move-1" `find . -name '*.el'`
./simple.el:5930:	  (line-move-1 arg noerror to-end)
./simple.el:5941:;; This is like line-move-1 except that it also performs
./simple.el:5955:      (line-move-1 arg noerror to-end)
./simple.el:5997:	(line-move-1 arg noerror to-end)))))
./simple.el:5999:;; Display-based alternative to line-move-1.
./simple.el:6071:(defun line-move-1 (arg &optional noerror _to-end)

I'll remove those from the calls, but I think the _to_end parameter will
have to remain in the -1 function.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2016-04-29  0:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 15:43 bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END Drew Adams
2013-07-11 15:49 ` Drew Adams
2013-07-11 16:12   ` Drew Adams
2016-04-29  0:35   ` Lars Ingebrigtsen [this message]
2016-04-29  9:30     ` Andreas Schwab
2016-04-29 12:27       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shy5z1ys.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=14844@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).