From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block Date: Tue, 07 Jun 2016 12:20:27 +0100 Message-ID: <87shwptfd0.fsf@russet.org.uk> References: <87lh2vo7s6.fsf@gmail.com> <87shx23830.fsf@gmail.com> <87wpmcwn13.fsf@russet.org.uk> <87wpm9q4z7.fsf@russet.org.uk> <87vb1rbbg1.fsf@russet.org.uk> <87shwutfmo.fsf@russet.org.uk> <87porxrk4v.fsf@russet.org.uk> <8b9b4630b1282ed76fe26452b4a8fbb6.squirrel@cloud103.planethippo.com> <87r3cacrpz.fsf@russet.org.uk> <838tyitk2k.fsf@gnu.org> <878tyicooh.fsf@russet.org.uk> <837fe2thh0.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465300316 11157 80.91.229.3 (7 Jun 2016 11:51:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Jun 2016 11:51:56 +0000 (UTC) Cc: cyd@gnu.org, monnier@iro.umontreal.ca, 23632@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 07 13:51:44 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bAFWx-0004Vw-E5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jun 2016 13:50:47 +0200 Original-Received: from localhost ([::1]:48873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAFWw-0000lI-I8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jun 2016 07:50:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAF4E-0002Lr-De for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 07:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAF4A-00058H-CF for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 07:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAF4A-00058D-8F for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 07:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bAF49-0001jQ-Uw for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 07:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2016 11:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23632-submit@debbugs.gnu.org id=B23632.14652984376602 (code B ref 23632); Tue, 07 Jun 2016 11:21:01 +0000 Original-Received: (at 23632) by debbugs.gnu.org; 7 Jun 2016 11:20:37 +0000 Original-Received: from localhost ([127.0.0.1]:57499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAF3k-0001iP-Qs for submit@debbugs.gnu.org; Tue, 07 Jun 2016 07:20:37 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:53750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAF3i-0001iA-T1 for 23632@debbugs.gnu.org; Tue, 07 Jun 2016 07:20:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=n5TzT/SENJekNR20V8TJ0S2iKfKi6T6LDeC2IAlxsb4=; b=pXJ/chEEDRP7eWIRnHwqaB+Sjf k+3Qo5bIe81WCld0gZvj0bQxdLix3IlI6Hvh3RN2G/UZNQB/cXY00GPcA+x2ySjbf6sDu8bXGeQNj OpPwAvIeq3/7vae1NMbX5RIgHkNzxHS54lTV+pdznvlHzrl1LD2ex0NOnvSsMWTp3MjrGv4x7fEer xJnGn7TNjzdqprXblHOkBN2A+kmOPMOjGc1dVE9hXeFFG6984L9gyAx22620vOyAdDX1Y38bkWup8 g/tiSgeFlD2fTGkLU2TE85J+5RIRahky3XEzCZh/6u2bHS8R2NRZYgpCk8wuEFWh4QHgTlRIwAK5M uulMHxfQ==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:33135 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bAF3c-001imC-Bk; Tue, 07 Jun 2016 12:20:28 +0100 In-Reply-To: <837fe2thh0.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 06 Jun 2016 19:22:35 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119206 Archived-At: Eli Zaretskii writes: >> From: phillip.lord@russet.org.uk (Phillip Lord) >> Cc: monnier@iro.umontreal.ca, cyd@gnu.org, 23632@debbugs.gnu.org >> Date: Mon, 06 Jun 2016 16:38:54 +0100 >> >> > Can you summarize its effect? It doesn't disable undo in recursive >> > editing, does it? >> >> No. It limits the addition of undo-boundaries to those buffers that have >> changed in at the same level of recursion. So, for example, undo will >> function in mini-buffer during completing-read, but changes in the >> mini-buffer will not result in the addition of undo-boundaries to >> buffers that changed during the command that lead to the >> completing-read. > > I guess I'm still confused a bit, because now I'm not sure what > difference does the change make. Does it record each change only > once, where previously we could record it several times? If not, what > does the above-mentioned limitation achieve, in terms of user-visible > effects? Hopefully, in most cases no user-visible effects, but it fixes the original bug report. It happens like this: call some command command changes local buffer command asks for more information from minibuffer with recursive edit change in the minibuffer forces undo-boundary into local buffer So, you get an undo-boundary where you did not expect. With this change: call some command command changes local buffer command asks for more information changes in minibuffer force undo-boundary only in mini-buffer Phil