From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Politz Newsgroups: gmane.emacs.bugs Subject: bug#26126: 26.0.50; file-notify-rm-watch removes arbitrary watches Date: Wed, 22 Mar 2017 18:43:33 +0100 Message-ID: <87shm5ky0q.fsf@luca> References: <87r31x9ulw.fsf@luca> <87shmcney8.fsf@detlef> <87efxw7xvc.fsf@luca> <87mvcjophx.fsf@detlef> <87tw6rssoi.fsf@luca> <87pohfkmvh.fsf@detlef> <87lgs2sobr.fsf@luca> <87y3w2gywc.fsf@detlef> <8737e8excq.fsf@luca> <87bmsuixuj.fsf@detlef> <87efxqmzyp.fsf@luca> <877f3h4fjd.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490204666 10360 195.159.176.226 (22 Mar 2017 17:44:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Mar 2017 17:44:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 26126@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 22 18:44:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqkIt-0001iw-Cb for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Mar 2017 18:44:11 +0100 Original-Received: from localhost ([::1]:52547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqkIz-0006K7-ET for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Mar 2017 13:44:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqkIp-0006IT-Vl for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 13:44:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqkIk-0000Az-DM for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 13:44:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41504) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqkIk-0000Ak-5S for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 13:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cqkIj-00070U-UR for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 13:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Politz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Mar 2017 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26126-submit@debbugs.gnu.org id=B26126.149020463526915 (code B ref 26126); Wed, 22 Mar 2017 17:44:01 +0000 Original-Received: (at 26126) by debbugs.gnu.org; 22 Mar 2017 17:43:55 +0000 Original-Received: from localhost ([127.0.0.1]:39703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqkIb-000701-Up for submit@debbugs.gnu.org; Wed, 22 Mar 2017 13:43:54 -0400 Original-Received: from gateway-a.fh-trier.de ([143.93.54.181]:48890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqkIZ-0006zo-L6 for 26126@debbugs.gnu.org; Wed, 22 Mar 2017 13:43:52 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Original-Received: from localhost (ip5f5bdecf.dynamic.kabel-deutschland.de [95.91.222.207]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 8498A179AC95; Wed, 22 Mar 2017 18:43:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1490204613; bh=87x7ob9MIqa2DY7W5JRisPj9A0g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=g4XXfC5gw8xi4Mf5BHh0Py5QWqTvEpOEB4NhkHg19TJ10E76kR1yfIFBt1XBYFWdb RskJoJVPUjlxl8sOjB9ChkdTM4D1qviA2mP0yWkFziNPHHyolcAralvA+5pvhyPb3Q rsfSe0g6Vu8W7Gyxo59RLdgM9RfMnNRLtq37Y/8s= In-Reply-To: <877f3h4fjd.fsf@detlef> (Michael Albinus's message of "Wed, 22 Mar 2017 14:17:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130817 Archived-At: Michael Albinus writes: > Andreas Politz writes: >>>> * inotify_add_watch internally uses a single watch per directory, which >>>> may be shared by multiple clients (using filenotify.el). The problem >>>> here seems to be that these clients may use different FLAGS as >>>> argument to file-notify-add-watch. [...] > So I would let it for you to implement it in inotify.c. When there is > also a respective test, we will see whether it is a problem for other > backends, too. This touches the question whether we're operating under the assumption, that other Lisp-code (apart from filenotify.el) may freely call inotify-add-watch or not. Because if it does, this has to be handled in inotify.c. Otherwise we may handle it in filenotify.el . If I do it in inotify.c: Is it possible to store a bit-mask (of type uint32_t) in a Lisp_Object ? Since this would be the easiest make this change. -ap