From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#27647: 26.0.50; Line numbers implemented natively disappear momentarily when frame out of focus Date: Wed, 08 Nov 2017 21:49:31 -0500 Message-ID: <87shdo4150.fsf@users.sourceforge.net> References: <83eftnitpj.fsf@gnu.org> <87inekjzy8.fsf@gmail.com> <87efp8jznq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1510195815 22883 195.159.176.226 (9 Nov 2017 02:50:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Nov 2017 02:50:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 27647@debbugs.gnu.org, Kaushal Modi To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 09 03:50:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCcut-0005Wh-Ag for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Nov 2017 03:50:07 +0100 Original-Received: from localhost ([::1]:34873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCcuz-0007Jx-3C for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Nov 2017 21:50:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCcur-0007JK-9D for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 21:50:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCcuo-0006L3-6w for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 21:50:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCcuo-0006Kx-31 for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 21:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCcun-0007d5-Qf for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 21:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Nov 2017 02:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27647-submit@debbugs.gnu.org id=B27647.151019578329298 (code B ref 27647); Thu, 09 Nov 2017 02:50:01 +0000 Original-Received: (at 27647) by debbugs.gnu.org; 9 Nov 2017 02:49:43 +0000 Original-Received: from localhost ([127.0.0.1]:59244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCcuV-0007cN-BN for submit@debbugs.gnu.org; Wed, 08 Nov 2017 21:49:43 -0500 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:46663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCcuS-0007c0-Tt; Wed, 08 Nov 2017 21:49:41 -0500 Original-Received: by mail-io0-f171.google.com with SMTP id 101so8233502ioj.3; Wed, 08 Nov 2017 18:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ubG+lxJDzrmFPBqET/hOo3Y46PTJCA78fzfV6ZXXBzI=; b=MqPDTWvg33KHUr+Wm6FcQYgIPENRYZ2JOVvdr0ObbnQjLGEiYx9C7q4q5KQy1H/Ykl 78VqubKS1eWeF648Oqyv0+4ykrF276NuDaFgjsnGu3dTnlOXgMm6EwRa/qpcaqZCqU8c TMwzyN+7mOTzxzzgaeDgrPNq65JrY6vqzDyFjKmbrAq7OsUjNWDmmALDbwuVSO2kw9+4 OI1DYTeTnieeV3AOQNAyG6g6GO4lg0HKrz+n+rUbA1eqS/+AzE9eZg1K5GBbsFt0xFW+ odIuMjkyl/tFgWQW1JBWjjx7tn2c4px2x+9W6U8McR4NrwrNpnhgq5q8XBuHEQ+R3eOW xwUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ubG+lxJDzrmFPBqET/hOo3Y46PTJCA78fzfV6ZXXBzI=; b=TSzAQDXInlB8yFCurByNFrdk2KM++gq/8xChZrb0AektMmo+RIQhIP4ZaPjViPjO9b hI+ani41wxR8SzxYO+vr53Hk8LSa+YU67RyQMsUdOkEdtIl+ufgEv0n3JJ4nV+tp6jNm p/4i09YMzKML1b0OYqjuojZNbPgADOXxOILpBtnvpiPTpNuuVfcZc6xXGQ9Yu/WKTaZB bEoSqqFVgJMVfXToM/rrKQx+lyVlpv0uvqiyby5ZmnRaHg+Ic9HMeX72PrIUV/gfrl+S UMDYwlqgqB8gjEhS6cBv76veRroLM5dZGo8aUJO843141Bdobk7UVfKS3fc93M3AWeC9 bPSA== X-Gm-Message-State: AJaThX4gsX4EpRcLuRXsT7PFF6BTdSSkKED3SyeVVcefMTZDQxvZMsHG mg8hoDDviWzm9IPFtunCez4zYQ== X-Google-Smtp-Source: ABhQp+QNBfR5SaMEa4iNeaBk5kYacjdTDqJX+6CEvC30ceo+zU6W30lOMKGvoyeTS3FIefpFc1sfiw== X-Received: by 10.107.14.15 with SMTP id 15mr3240333ioo.127.1510195775039; Wed, 08 Nov 2017 18:49:35 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id s81sm2952306ita.19.2017.11.08.18.49.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Nov 2017 18:49:32 -0800 (PST) In-Reply-To: <87efp8jznq.fsf@gmail.com> (Alex's message of "Wed, 08 Nov 2017 14:14:49 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139645 Archived-At: --=-=-= Content-Type: text/plain tags 27647 + patch quit Alex writes: > Alex writes: > >> I coincidentally stumbled across an easy recipe for this bug (or at >> least a similar bug): >> >> M-: (setq display-line-numbers t) >> M-: (setq mouse-drag-and-drop-region t) >> >> Then select a region, click on it (mouse-1), and drag the mouse. The >> line numbers will disappear until you release the mouse. >> >> Hopefully you can reproduce this on your end this time, Eli. To be >> clear, this is with a GTK build. > > Sorry, I should have also mentioned that this is indeed only the case > when x-gtk-use-system-tooltips is non-nil. Aha, the problem is this condition in should_produce_line_number: static bool should_produce_line_number (struct it *it) { ... /* Don't display line number in tooltip frames. */ if (FRAMEP (tip_frame) && EQ (WINDOW_FRAME (it->w), tip_frame)) return false; Which sounds like it would be correct, except that the meaning of tip_frame is different for GTK tooltips, as explained in x_hide_tip: static Lisp_Object x_hide_tip (bool delete) { ... #ifdef USE_GTK { /* When using system tooltip, tip_frame is the Emacs frame on which the tip is shown. */ struct frame *f = XFRAME (tip_frame); Implemented in Fx_show_tip: DEFUN ("x-show-tip", Fx_show_tip, Sx_show_tip, 1, 6, 0, ... f = decode_window_system_frame (frame); ... #ifdef USE_GTK if (x_gtk_use_system_tooltips) { ... /* This is used in Fx_hide_tip. */ XSETFRAME (tip_frame, f); Leading to the following patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Fix-line-number-display-when-using-gtk-tooltips-B.patch Content-Description: patch >From de99bf6af06aba4659740b8f3d892ff5db5bce03 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 8 Nov 2017 21:45:28 -0500 Subject: [PATCH v1] Fix line number display when using gtk tooltips (Bug#27647) * src/xdisp.c (should_produce_line_number): Don't check tip_frame when using gtk tooltips. --- src/xdisp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/xdisp.c b/src/xdisp.c index 69b74dc629..3b75811cc3 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -21126,7 +21126,8 @@ should_produce_line_number (struct it *it) #ifdef HAVE_WINDOW_SYSTEM /* Don't display line number in tooltip frames. */ - if (FRAMEP (tip_frame) && EQ (WINDOW_FRAME (it->w), tip_frame)) + if (!x_gtk_use_system_tooltips + && FRAMEP (tip_frame) && EQ (WINDOW_FRAME (it->w), tip_frame)) return false; #endif -- 2.11.0 --=-=-=--