unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 29799@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#29799: 24.5; cl-loop guard clause missing
Date: Sat, 06 Jan 2018 08:43:56 -0500	[thread overview]
Message-ID: <87shbjqezn.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87lghfqlh0.fsf@gmail.com> (Tino Calancha's message of "Wed, 03 Jan 2018 19:34:51 +0900")

Tino Calancha <tino.calancha@gmail.com> writes:

>     Fix #Bug#29799
>     
>     * lisp/emacs-lisp/cl-macs.el (cl--loop-guard-cond): New variable.
>     (cl--parse-loop-clause): Set it non-nil if the loop contains
>     a for/as clause.
>     (cl-loop): After update the loop variable, update other variables
>     only if cl--loop-guard-cond is non-nil.
>     
>     * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-loop-for-as-equals-and):
>     New test.

Looks good, but please add some more info to the summary line.





  reply	other threads:[~2018-01-06 13:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21  9:38 bug#29799: 24.5; cl-loop guard clause missing Tino Calancha
2018-01-01 21:46 ` Noam Postavsky
2018-01-01 22:58   ` Noam Postavsky
2018-01-03 10:34     ` Tino Calancha
2018-01-06 13:43       ` Noam Postavsky [this message]
2018-01-08 10:20         ` Tino Calancha
2019-10-28  3:59 ` dick.r.chiang
2019-11-21 23:25 ` dick.r.chiang
2019-11-22 12:55   ` Lars Ingebrigtsen
2019-11-22 13:51     ` dick.r.chiang
2019-11-22 14:53       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shbjqezn.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=29799@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).