From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#30745: 26.0.91; ert should macros nest strangely Date: Thu, 08 Mar 2018 08:54:41 +0000 Message-ID: <87sh9blzfy.fsf@russet.org.uk> References: <874llr4lk1.fsf@russet.org.uk> <87r2ov1l46.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1520499251 7528 195.159.176.226 (8 Mar 2018 08:54:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Mar 2018 08:54:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: 30745@debbugs.gnu.org, 24402@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 08 09:54:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etrJ6-0007MX-Fw for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Mar 2018 09:53:48 +0100 Original-Received: from localhost ([::1]:37510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etrL9-0003SX-Ah for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Mar 2018 03:55:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etrKO-0002uz-6C for bug-gnu-emacs@gnu.org; Thu, 08 Mar 2018 03:55:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etrKJ-0000JR-FK for bug-gnu-emacs@gnu.org; Thu, 08 Mar 2018 03:55:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etrKJ-0000JI-44 for bug-gnu-emacs@gnu.org; Thu, 08 Mar 2018 03:55:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1etrKI-0007Ah-U6 for bug-gnu-emacs@gnu.org; Thu, 08 Mar 2018 03:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Mar 2018 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30745-submit@debbugs.gnu.org id=B30745.152049929027529 (code B ref 30745); Thu, 08 Mar 2018 08:55:02 +0000 Original-Received: (at 30745) by debbugs.gnu.org; 8 Mar 2018 08:54:50 +0000 Original-Received: from localhost ([127.0.0.1]:50164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etrK6-00079w-4y for submit@debbugs.gnu.org; Thu, 08 Mar 2018 03:54:50 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:49500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etrK4-00079f-8g; Thu, 08 Mar 2018 03:54:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=H7mQm+3ua7BkvVRlDlf31eTH0jo8luU3dPfLhbkgepQ=; b=zeDlMFzjJN8DMCfSt33a5AcHj FzvM1n8uvyKNkZLcL6CNL4ng8M3oO0fq8G1iMcAAfEE0+GDyBdSYCKB7klGZJIMtdnP3oMaEhQP9Z 0rulLTvA81+fDAFZp3Hi2yldGMLR6kPlfb6lT1rPW8JjJOoQV0jU9ONX7sFB11JNS8PBoDVWK+i+1 AmFocEbuZrJOOrVzWD725JGYyklMhcOhsQCAJm2e65q9llBDvKKmsFCbnskqDS98McVbMA4NvDJUI E6xoH9wFkcV3LX/OwXZigt414iO5BOLXZXT1Rb4nT1p+bprHeQXFPmAmFc8QfPVPvKFeXuL02SOCy sr+Gf5tgw==; Original-Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:35400 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1etrJx-001RrA-By; Thu, 08 Mar 2018 08:54:41 +0000 In-Reply-To: <87r2ov1l46.fsf@gmail.com> (Noam Postavsky's message of "Wed, 07 Mar 2018 19:12:09 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144021 Noam Postavsky writes: > phillip.lord@russet.org.uk (Phillip Lord) writes: > >> This regression is caused by: >> >> commit 054c198c120c1f01a8ff753892d52710b740acc6 > > Hmm, according to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24402#56 > we thought nesting should still have worked, but apparently that was too > optimistic. Unfortunately, yes. I didn't try nesting two ert-deftest macros, just two should's. As the original bug report suggests it's for testing a test library (https://github.com/phillord/assess). I do have a work around now (which is to unnest the shoulds); and fortunately, this work-around is backward compatible which is important for me. I still have another test failure in my library, though. Probably caused by the same thing but I haven't worked on it yet. Phil