From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31193: 26.1; error in `term-down' after window configuration change Date: Tue, 17 Apr 2018 09:23:46 -0400 Message-ID: <87sh7ut199.fsf@gmail.com> References: <5480f11459b73e4cf0aabe12da5ce675@webmail.orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523971425 4967 195.159.176.226 (17 Apr 2018 13:23:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Apr 2018 13:23:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31193@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 17 15:23:41 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8QaD-0001Bs-93 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2018 15:23:41 +0200 Original-Received: from localhost ([::1]:38669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8QcK-0001AU-0v for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2018 09:25:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Qab-0008Cd-S7 for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 09:24:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8QaY-0004Dr-KO for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 09:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48995) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8QaY-0004Dh-GA for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 09:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8QaY-0007yK-Ao for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Apr 2018 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31193 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31193-submit@debbugs.gnu.org id=B31193.152397143530632 (code B ref 31193); Tue, 17 Apr 2018 13:24:02 +0000 Original-Received: (at 31193) by debbugs.gnu.org; 17 Apr 2018 13:23:55 +0000 Original-Received: from localhost ([127.0.0.1]:56892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8QaR-0007xz-LG for submit@debbugs.gnu.org; Tue, 17 Apr 2018 09:23:55 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:56100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8QaQ-0007xn-0J for 31193@debbugs.gnu.org; Tue, 17 Apr 2018 09:23:54 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id 145-v6so9871164itf.5 for <31193@debbugs.gnu.org>; Tue, 17 Apr 2018 06:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7X7/CBo0tLHqaGx1a7g4hKhnZGipYiMcjIsIDDJPcj0=; b=dpHi387vvKHm90ppp6oZZtRn5aeL7RkqQTxQ7wvywBDW0/lwjm2Pz7f/+K/BT0lJmX GtuHcRG9yHGpsZgZaHoFzUl6z/B6Yew7PFbPhs73m3xE+OrVEOVELDLwKjrLWSBqszcI Z85joRsxKiVfEzh87jZPWwlFsM6do8rwtpWTjPdUAt0CT1G+t+0hxMNV4XX4XcuPo/51 w8aHKtJJC3V3z5OefUbyww046qAkfhpPutFV3P0CGyfk6rUYjJRO40PNZBQY+2tJGhVA 5lKJFRltr5UrP7EmNVS3LXOMGHRmqP9MRnDB8PS5xrNTDjLhQYkulilB1p9M5Tt4gPJy rrbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7X7/CBo0tLHqaGx1a7g4hKhnZGipYiMcjIsIDDJPcj0=; b=rNHSpgL90wJSRkc7whre5Sdjz77BQA+br9sFOfnHLgEijVw8OZz/558fPWSjDjZwrO aMDHGQ+Rjf8eMm8Py1Cvkx4R2yOH9KkSxGcEv138d1bKTIAxT8vmbiE+yubJ6A5Cp7wt SCy9LzBvzYlspEU/pb7jgTc+VJSrMd3LXYG5IwN+hGBPtza4Md6iHPh1e5u+awEjTq+N yFD3xMohcPnHkWqVJi7MUo90hu+sNdqORLEcUbm4x+TFlnhlcECuDRBXEm5FavoLONJK kMgeWoGU5NPLBtV/kzqI4ZhfjKQUfLrQZn4VSO31/s3NCRvtVPhY675+xBGBjC3Q+wZL Xl2A== X-Gm-Message-State: ALQs6tDwYv+VuRJPqTdXyyOE4QsJB/BFULhRgYf798/L1mgcmug9ApDz oJnypFo8vUkSWAaCqyUXYFr6gw== X-Google-Smtp-Source: AIpwx49LkGElUnO+balflEQ29lMAre06SthVfMmpGMn7WXNkbuIRNzLCVaRkJg4enQyf4Ru84a6w0g== X-Received: by 2002:a24:d8f:: with SMTP id 137-v6mr1236026itx.30.1523971428202; Tue, 17 Apr 2018 06:23:48 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id t4-v6sm4965185ita.3.2018.04.17.06.23.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 06:23:47 -0700 (PDT) In-Reply-To: <5480f11459b73e4cf0aabe12da5ce675@webmail.orcon.net.nz> (Phil Sainty's message of "Wed, 18 Apr 2018 01:00:14 +1200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145492 Archived-At: Phil Sainty writes: > In a `term' buffer, seemingly after any window configuration change, the > process filter triggers an error due to `term-current-row' being nil > unexpectedly. > > Recipe: > > emacs -Q > M-x toggle-debug-on-error > M-x term > RET > RET #repeatedly -- all is fine at this point... > C-c 2 > RET > > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p > nil) > term-down(1 t) > term-emulate-terminal(# "\015\033[K$ > \015\n\032//home/phil\015\n") Hmm, I'm not able to reproduce this, even though it makes sense to me that my fix for Bug#30544 [1: a64c11a3aa] would cause this. Perhaps it depends on your shell prompt as well? > That test of (= term-current-row 0) occurs twice in the function. > > Trivially, testing (bound-and-true-p term-current-row) beforehand in > both pieces of code circumvents the error and appears in practice to > resolve the issue, but I don't know whether that's the *right* fix. I think changing them to function calls, i.e., (term-current-row) instead of term-current-row would be the right thing; all the other term functions use the function rather than accessing the variable directly. [1: a64c11a3aa]: 2018-04-02 06:57:53 -0400 Fix term.el rendering following a window resize (Bug#30544) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a64c11a3aa49121ceab79a2acc99c829d42417bd>