From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31492@debbugs.gnu.org
Subject: bug#31492: 26.1; query-replace-regexp undo fails in regexps w/o printable chars
Date: Sun, 20 May 2018 20:51:10 +0900 [thread overview]
Message-ID: <87sh6mwno1.fsf@gmail.com> (raw)
In-Reply-To: <83vabifzfg.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 May 2018 12:29:07 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> > The relevant
>> > element of the replacement stack (whose structure, btw, seems not to
>> > be documented anywhere), is (4 4 *scratch*), whereas I'd expect to see
>> > (1 4 *scratch) instead, because the replacement was at position 1;
>> > then setting match-data from this would DTRT.
>> Yes, that is the logic. The thing is, for some unknown reason to me,
>> the reported match-data is inexact when there are no printable chars
>> in the regexp (maybe it's expected and I am wrong on my assumptions).
>
> The reason for that is that match-data is recorded as markers, and so
> the positions move if text is inserted. In your example, the position
> of $ moved due to insertion, so the marker's position was updated as
> part of the replacement.
Yeah, I have noticed that this afternoon.
> Right, and so I submit that the problem is where the replacement stack
> is updated: it should account for these subtleties and adjust the
> stack positions accordingly, since it has the opportunity to look at
> the match position before the matched text is replaced.
I have a different approach:
If the problem arise from using markers istead of integers, then how
about we just use integers?
Please take a look:
--8<-----------------------------cut here---------------start------------->8---
commit cf13cb2dff040571b289e2ba8dcc0008394ffe3d
Author: Tino Calancha <tino.calancha@gmail.com>
Date: Sun May 20 20:43:30 2018 +0900
Fix corner case in query-replace-regexp undo
This commit fixes Bug#31492.
* lisp/replace.el(replace-save-match-data): New macro.
(replace-match-maybe-edit): Preserve match data.
* test/lisp/replace-tests.el (query-replace-undo-bug31492): Add test.
diff --git a/lisp/replace.el b/lisp/replace.el
index 3503b656d9..7d49b977fd 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -2184,6 +2184,16 @@ replace-match-data
new)))
(match-data integers reuse t)))
+(defmacro replace-save-match-data (&rest body)
+ "Like `save-match-data', but it uses integers instead of markers.
+The value returned is the value of the last form in BODY."
+ (declare (indent 0) (debug t))
+ (let ((match (gensym "match-data")))
+ `(let ((,match (match-data 'integers)))
+ (unwind-protect
+ ,@body
+ (set-match-data ,match)))))
+
(defun replace-match-maybe-edit (newtext fixedcase literal noedit match-data
&optional backward)
"Make a replacement with `replace-match', editing `\\?'.
@@ -2213,7 +2223,7 @@ replace-match-maybe-edit
nil match-data match-data))))
noedit nil)))
(set-match-data match-data)
- (replace-match newtext fixedcase literal)
+ (replace-save-match-data (replace-match newtext fixedcase literal))
;; `replace-match' leaves point at the end of the replacement text,
;; so move point to the beginning when replacing backward.
(when backward (goto-char (nth 0 match-data)))
diff --git a/test/lisp/replace-tests.el b/test/lisp/replace-tests.el
index 40a1a31cf7..40ee838e67 100644
--- a/test/lisp/replace-tests.el
+++ b/test/lisp/replace-tests.el
@@ -399,5 +399,25 @@ replace-tests--query-replace-undo
;; After undo text must be the same.
(should (string= text (buffer-string))))))
+(ert-deftest query-replace-undo-bug31492 ()
+ "Test for https://debbugs.gnu.org/31492 ."
+ (let ((text "a\nb\nc\n")
+ (count 0)
+ (inhibit-message t))
+ (with-temp-buffer
+ (insert text)
+ (goto-char 1)
+ (cl-letf (((symbol-function 'read-event)
+ (lambda (&rest args)
+ (cl-incf count)
+ (let ((val (pcase count
+ ((or 1 2) ?\s) ; replace current and go next
+ (3 ?U) ; undo-all
+ (_ ?q)))) ; exit
+ val))))
+ (perform-replace "^\\|\b\\|$" "foo" t t nil))
+ ;; After undo text must be the same.
+ (should (string= text (buffer-string))))))
+
;;; replace-tests.el ends here
--8<-----------------------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2018-05-20 11:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 13:27 bug#31492: 26.1; query-replace-regexp undo fails in regexps w/o printable chars Tino Calancha
2018-05-18 14:16 ` Eli Zaretskii
2018-05-18 14:22 ` Tino Calancha
2018-05-18 15:07 ` Eli Zaretskii
2018-05-19 1:46 ` Tino Calancha
2018-05-19 7:50 ` Eli Zaretskii
2018-05-19 14:28 ` Tino Calancha
2018-05-20 9:29 ` Eli Zaretskii
2018-05-20 11:51 ` Tino Calancha [this message]
2018-05-20 11:59 ` Eli Zaretskii
2018-05-20 12:06 ` Tino Calancha
2018-05-20 12:48 ` Eli Zaretskii
2018-05-20 13:46 ` Tino Calancha
2018-05-20 15:47 ` Eli Zaretskii
2018-05-21 1:51 ` Tino Calancha
2018-05-21 15:05 ` Eli Zaretskii
2018-05-23 9:22 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh6mwno1.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=31492@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).