From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: "Daniel Colascione" <dancol@dancol.org>
Cc: 31988@debbugs.gnu.org
Subject: bug#31988: scroll-other-window broken on master
Date: Thu, 28 Jun 2018 00:26:33 +0300 [thread overview]
Message-ID: <87sh57ncom.fsf@tcd.ie> (raw)
In-Reply-To: <f636a41ba6c0bc20113daa8464a1f937.squirrel@dancol.org> (Daniel Colascione's message of "Wed, 27 Jun 2018 13:44:47 -0700")
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
tags 31988 patch
quit
"Daniel Colascione" <dancol@dancol.org> writes:
> Basil, it looks like you recently rewrote a big chunk of the window
> scrolling code. Can you please take a look?
>
> Thanks.
>
>> scroll-other-window scrolls the current window _and_ the other window. To
>> repro, visit a big file, C-x 2, and mash C-M-v. Only the other window
>> should scroll. Now, both windows scroll.
This bug was indeed introduced by my recent refactor.
Does the following patch fix it?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-other-window-scroll-when-showing-same-buffer.patch --]
[-- Type: text/x-diff, Size: 986 bytes --]
From 026b6befc40795d8597e036f930f634b2a17e4f3 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Thu, 28 Jun 2018 00:13:07 +0300
Subject: [PATCH] Fix other window scroll when showing same buffer
src/window.c (scroll_command): Make other window's buffer current
before scrolling, even when displaying the same buffer. (bug#31988)
---
src/window.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/window.c b/src/window.c
index 81fd7f2b47..42b9522862 100644
--- a/src/window.c
+++ b/src/window.c
@@ -5654,7 +5654,7 @@ scroll_command (Lisp_Object window, Lisp_Object n, int direction)
/* If given window's buffer isn't current, make it current for
the moment. But don't screw up if window_scroll gets an error. */
- if (XBUFFER (w->contents) != current_buffer)
+ if (other_window || XBUFFER (w->contents) != current_buffer)
{
record_unwind_protect_excursion ();
Fset_buffer (w->contents);
--
2.18.0
[-- Attachment #3: Type: text/plain, Size: 20 bytes --]
Thanks,
--
Basil
next prev parent reply other threads:[~2018-06-27 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 19:54 bug#31988: scroll-other-window broken on master Daniel Colascione
2018-06-27 20:44 ` Daniel Colascione
2018-06-27 21:26 ` Basil L. Contovounesios [this message]
2018-07-06 15:18 ` Daniel Colascione
2018-07-06 22:20 ` Basil L. Contovounesios
2018-07-06 23:31 ` Daniel Colascione
2018-07-07 7:48 ` Eli Zaretskii
2018-07-07 13:40 ` Basil L. Contovounesios
2018-07-07 13:50 ` Eli Zaretskii
2018-07-07 14:14 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh57ncom.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=31988@debbugs.gnu.org \
--cc=dancol@dancol.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).