From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.bugs Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame Date: Sun, 01 Jul 2018 17:18:08 +0000 Message-ID: <87sh52yiwf.fsf@gmail.com> References: <87po2gkxpi.fsf@gmail.com> <87sh57yrax.fsf@gmail.com> <83lgawmwup.fsf@gnu.org> <878t6wxbzr.fsf@gmail.com> <5B38994B.2010605@gmx.at> <87va9zxfhe.fsf@gmail.com> <83in5zkjsk.fsf@gnu.org> <87tvpiyjz6.fsf@gmail.com> <83fu12lwh2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530465429 5875 195.159.176.226 (1 Jul 2018 17:17:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2018 17:17:09 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 31325@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 01 19:17:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZfyC-0001PS-97 for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 19:17:04 +0200 Original-Received: from localhost ([::1]:55053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZg0J-0007Xt-6E for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 13:19:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZg09-0007Xc-Vt for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 13:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZg06-0004rv-R4 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 13:19:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34407) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZg06-0004rl-MK for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 13:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fZg06-0000vQ-AS for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 13:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jul 2018 17:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31325-submit@debbugs.gnu.org id=B31325.15304654993505 (code B ref 31325); Sun, 01 Jul 2018 17:19:02 +0000 Original-Received: (at 31325) by debbugs.gnu.org; 1 Jul 2018 17:18:19 +0000 Original-Received: from localhost ([127.0.0.1]:42304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZfzP-0000uT-8C for submit@debbugs.gnu.org; Sun, 01 Jul 2018 13:18:19 -0400 Original-Received: from mail-qt0-f175.google.com ([209.85.216.175]:45991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZfzM-0000uE-7h for 31325@debbugs.gnu.org; Sun, 01 Jul 2018 13:18:16 -0400 Original-Received: by mail-qt0-f175.google.com with SMTP id y5-v6so2329371qti.12 for <31325@debbugs.gnu.org>; Sun, 01 Jul 2018 10:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=8H+JMaB0ZzCMzKFhgDy+Yihk4UcVpaOzzrxiDaH4Hv8=; b=df68HDomZDWYaeJLK8dDhQkeg0Wd0fj4ixtHFgegf8mO+7kv8pup0yHZiSGvIbHQ6y htDGE0iHleclRZiptnTgarU3UVKHdJpahUvHROTqDfKD8P+AzEbBjJ9ulybls+r7ZUMS k+0dl+0m08mhF29wxD1U/ng8M+Pw5B6Hp3Z9GD+0beLUcAFePOfyucVedUYOL9dgIXmP 25BVpvvm7kD3U600yqVyEa3gkZPeBhdsfuySRFHMlq8iTYYbt46zWHCJyEFERVnc8kAu JeggMfdg5ctocbZudesRC6uKe3Ma2KPOKIDMln0l6UMt5r2m/7l6BMDEbe+R+1/+wY9Q 5ogg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=8H+JMaB0ZzCMzKFhgDy+Yihk4UcVpaOzzrxiDaH4Hv8=; b=bv0Ht9GB4rr5E1HeERT+RY/RH0bmiDJ00grc0moJjquDGtD0m+vjLg4FCCQuzcLfXW GZFWJ7oiI94NTaqCCEXK7UwWJJPaFppLrpDx7qtDwlxG0680yebUNcjfF+W/M9q5khR3 XPa+hET+V2tsob0LyO8Li5hgzkrvRJoYhAz2cLrqjOzXeglmIoLRrZk/RvakglNGtaXs 30dY474GHSQHHpWjwLkXJFpcRcx4Z8FxHU9BIOLNyPip9IxsWacv3vrjFZtVtxIojSP6 vXyza/i2R3RSXRl2byJAVuBlNFlE1RrRcLLHfeZdngiQ9Me0CsD1Nf/hnUKbjdn7JJku VdkA== X-Gm-Message-State: APt69E2y7JWogbZZJrxsbutwhDAm5BrCZsTiZ51XgiG+cpC66qSH7mMC cBur73bSRH4FK1gYiOsl8yU= X-Google-Smtp-Source: AAOMgpcbOySvdZ8cPizjrarxLyZsdvPj8A6WkzUj4GRHZuYjo2bq4fHkuyH6n/hJBO/bCA6lRwSguA== X-Received: by 2002:ac8:610a:: with SMTP id a10-v6mr21391430qtm.139.1530465490576; Sun, 01 Jul 2018 10:18:10 -0700 (PDT) Original-Received: from 9a50e8462956 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id u1-v6sm8831063qkd.45.2018.07.01.10.18.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 10:18:09 -0700 (PDT) In-reply-to: <83fu12lwh2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148054 Archived-At: Eli Zaretskii writes: >> From: John Shahid >> Cc: rudalics@gmx.at, 31325-done@debbugs.gnu.org, monnier@iro.umontreal.ca >> Date: Sun, 01 Jul 2018 16:54:53 +0000 >> >> It just occurred to me that this change will break backward >> comparability for those who bind some key to the `recenter' command, >> since now the second argument will always be nil and thus won't >> redisplay. Should we also change the interactive form of recenter to >> use "p" for the second argument? That way the second arg is never nil >> when used interactively. > > I think you are right. > > Alternatively, we could simply make 'recenter' behave specially in > interactive invocations. But in any case, incompatible changes in > behavior are bad, and should be avoided. I am happy to make the change. Should we just revert this patch and instead of adding a new argument change the behavior of`recenter' to redraw if called interactively ? How can we determine from C whether the function is called interactively ? Is it ok to use `called-interactively-p' ?