From: Stephen Berman <stephen.berman@gmx.net>
To: Ken Brown <kbrown@cornell.edu>
Cc: 32318@debbugs.gnu.org
Subject: bug#32318: wdired-test-bug32173-02 fails
Date: Tue, 31 Jul 2018 00:57:59 +0200 [thread overview]
Message-ID: <87sh40uya0.fsf@gmx.net> (raw)
In-Reply-To: <7263d625-faff-9dc1-b0dd-325514abe4cd@cornell.edu> (Ken Brown's message of "Mon, 30 Jul 2018 14:46:51 -0400")
On Mon, 30 Jul 2018 14:46:51 -0400 Ken Brown <kbrown@cornell.edu> wrote:
> On 7/30/2018 2:02 PM, Glenn Morris wrote:
>> Package: emacs
>> Severity: minor
>> Version: 26.1.50
>>
>> emacs-26 branch at 0252f73, RHEL 7.5, wdired-test-bug32173-02 fails, see
>> log below. Identical failure on hydra.nixos.org, see eg
>> https://hydra.nixos.org/build/78668940 .
>
> I'm seeing the same thing on Cygwin, but only if the test is run from
> wdired-tests.elc (which happens by default when you run 'make check'). But the
> test passes if it is run from wdired-tests.el:
>
> $ make -C test wdired-tests TEST_LOAD_EL=yes
> make: Entering directory '/home/kbrown/src/emacs/i686/test'
> make[1]: Entering directory '/home/kbrown/src/emacs/i686/test'
> GEN lisp/wdired-tests.log
> Running 3 tests (2018-07-30 14:41:43-0400, selector `(not (tag :unstable))')
> Press C-c C-c when finished or C-c ESC to abort changes
> passed 1/3 wdired-test-bug32173-01 (0.426361 sec)
> Press C-c C-c when finished or C-c ESC to abort changes
> passed 2/3 wdired-test-bug32173-02 (0.240313 sec)
> Press C-c C-c when finished or C-c ESC to abort changes
> passed 3/3 wdired-test-unfinished-edit-01 (0.130247 sec)
>
> Ran 3 tests, 3 results as expected (2018-07-30 14:41:44-0400, 0.797493 sec)
I think I've fixed this now, simply by requiring wdired (in emacs-26
951c5a1).
I had run make check several times before pushing the test file and all
tests were as expected, though there were a few byte-compiler warnings.
But after reading your reports, I also tried a batch run on the compiled
file and got the same failure. Then I stepped through the ert test run
in edebug and found that on the first run from emacs -Q,
wdired-use-interactive-rename was nil at the point of failure, though it
was let-bound to t; on rerunning the test the let-binding held. I don't
know why that happened, but I guess the autoloads in wdired.el aren't
enough to make sure all variables and functions are defined when used,
though again, I hadn't seen unexpected failures with make check.
Anyway, requiring the library being tested should have been obvious, and
I hope the problem is solved now.
Steve Berman
next prev parent reply other threads:[~2018-07-30 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 18:02 bug#32318: wdired-test-bug32173-02 fails Glenn Morris
2018-07-30 18:46 ` Ken Brown
2018-07-30 22:57 ` Stephen Berman [this message]
2018-07-31 12:35 ` Ken Brown
2018-07-31 12:40 ` Stephen Berman
2018-08-08 10:06 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh40uya0.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=32318@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).