From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#32463: 27.0.50; (logior -1) => 4611686018427387903 Date: Wed, 22 Aug 2018 10:56:56 -0600 Message-ID: <87sh362vc7.fsf@tromey.com> References: <5230a57b-5896-606d-f157-2e547710b6e8@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534958064 7201 195.159.176.226 (22 Aug 2018 17:14:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Aug 2018 17:14:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Andy Moreton , 32463@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 22 19:14:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsWi1-0001hw-Pw for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Aug 2018 19:14:18 +0200 Original-Received: from localhost ([::1]:60103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsWk8-0000R6-8l for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Aug 2018 13:16:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsWgI-0004YN-9M for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 13:12:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsWRL-0001yU-1r for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 12:57:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsWRK-0001yE-Q0 for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 12:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fsWRK-00072s-IN for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2018 12:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Aug 2018 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32463 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32463-submit@debbugs.gnu.org id=B32463.153495702027070 (code B ref 32463); Wed, 22 Aug 2018 16:57:02 +0000 Original-Received: (at 32463) by debbugs.gnu.org; 22 Aug 2018 16:57:00 +0000 Original-Received: from localhost ([127.0.0.1]:57940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsWRI-00072Y-Ax for submit@debbugs.gnu.org; Wed, 22 Aug 2018 12:57:00 -0400 Original-Received: from gateway36.websitewelcome.com ([192.185.192.36]:12438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsWRG-00072O-HD for 32463@debbugs.gnu.org; Wed, 22 Aug 2018 12:56:59 -0400 Original-Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 738BA400F1FC1 for <32463@debbugs.gnu.org>; Wed, 22 Aug 2018 11:00:41 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id sWRFf4o1cSjJAsWRFfl2Ta; Wed, 22 Aug 2018 11:56:57 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WEbynOsTbVw4FzFgeTrS5iRcBwQ1471rkPcxd4Btj3Q=; b=S5hSC7t1PdIWX1haDZNkRKL52A iUU41OfYwM4bOGTT8SveFLTRpWKDPQY2E87COkf5Usd82ResV1FdJ201Ky1aFtV8Ytge6cMSdDLO4 LoenUqJSd/BVCXO2kQcUjfuzP; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:39684 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fsWRF-001O2B-H1; Wed, 22 Aug 2018 11:56:57 -0500 X-Attribution: Tom In-Reply-To: <5230a57b-5896-606d-f157-2e547710b6e8@cs.ucla.edu> (Paul Eggert's message of "Sat, 18 Aug 2018 15:56:55 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fsWRF-001O2B-H1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (bapiya) [75.166.85.72]:39684 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149664 Archived-At: >>>>> "Paul" == Paul Eggert writes: Paul> My bigger concern is memory management, along with integer overflow in Paul> size or bitcount calculation. Copies are made of bignums when not Paul> needed One idea is to change make_number to take ownership of the passed-in mpz_t. I didn't do this because it makes the API confusing to use (I put in a comment to this effect) but perhaps efficiency outweighs this; and anyway the function could be renamed to make this more clear. Tom