From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases Date: Sat, 01 Sep 2018 12:38:19 -0400 Message-ID: <87sh2tqikk.fsf@gmail.com> References: <83lgetri7r.fsf@gnu.org> <87in9cpd3a.fsf@gmail.com> <87in48ww9l.fsf@gmail.com> <83o9e0f9uj.fsf@gnu.org> <87tvnluvp4.fsf@gmail.com> <83bm9tb2yj.fsf@gnu.org> <875zzrrzv6.fsf@gmail.com> <83h8ja395r.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535820770 20374 195.159.176.226 (1 Sep 2018 16:52:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Sep 2018 16:52:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 01 18:52:46 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fw98f-0005Ay-Sk for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Sep 2018 18:52:46 +0200 Original-Received: from localhost ([::1]:37863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fw9Am-0002zg-3V for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Sep 2018 12:54:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fw9Ac-0002zN-Tf for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2018 12:54:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fw8vO-0002vG-S3 for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2018 12:39:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37033) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fw8vO-0002v0-OC for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2018 12:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fw8vO-0007xO-IH for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2018 12:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Sep 2018 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30823-submit@debbugs.gnu.org id=B30823.153581990930538 (code B ref 30823); Sat, 01 Sep 2018 16:39:02 +0000 Original-Received: (at 30823) by debbugs.gnu.org; 1 Sep 2018 16:38:29 +0000 Original-Received: from localhost ([127.0.0.1]:42051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fw8uq-0007wT-UC for submit@debbugs.gnu.org; Sat, 01 Sep 2018 12:38:29 -0400 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:55741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fw8up-0007wF-LR for 30823@debbugs.gnu.org; Sat, 01 Sep 2018 12:38:28 -0400 Original-Received: by mail-it0-f54.google.com with SMTP id d10-v6so10878692itj.5 for <30823@debbugs.gnu.org>; Sat, 01 Sep 2018 09:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T9bs6UBkJKHmDaxcmyOwyMaanFbNtdGSaX0alSxCEYE=; b=k7epBSZXCkDoYRlpiZPCtKkshdcWfbGvGflcKCmP92AYU0c9+71IDCTz2UxdvevbuB If7dPc+X/nRNXEkRHClT4J4CzJd0F5DyPiuC+wED4dZbd+XYx9Ps8K21dAnkaUSw7N9i gzzXHvCjKTsnZU5NWsD1MB+Woix1d2b95p/VL3+PtQASJJxP/L+pVDQYqCvnB6RoemTG PyPNcohffWvaDcmcu6puDNRRxgwjyttwW4Uvs1H65Dv7cZjddsVUe2SvmviOTuSKN2mI lfPQNcDE9HxZpL8h9+FPV8veZ9hQ+0AWqitep3rwGgNouJgnKT6h1+bk4Lue1VrvwbNv ee0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T9bs6UBkJKHmDaxcmyOwyMaanFbNtdGSaX0alSxCEYE=; b=Fu4SuaZgQTV1Dl23E0SZIc3lQD50x/97MwYT6PTfPM/6VERcQUN58bo4qyDClwub0k zOkEUiiY0Eql1hhlPkpOQzb8QqGKEgc+Kope2tXrSKtgipOeAM3eSh+cHpcGFTH/3War lc7oWD0UzWWQJriExL2kWnUP9oK70CnZEthlc6Z0H+SVvsVW0T/P7/uGrBHRhei13oHK pGbMQ2+H2vnkWOmDslUGiiicdHjcXKSXHLoJSunpSvB5I0HGSEbs+1SaKB+V1vdYKd2P CEsDjw672lW2YFI0soHDoexuDMY40+JfJUp29Hd9d8eSoQZ8zEE+E60Cy0QmK6++Vc0q gdlQ== X-Gm-Message-State: APzg51DKGebohkE0mGy2W5EkjB2nUCrMhuvk1CmuDB0ldEFQGfI/GRPo OFhRUJQfqOB1w8sk7T9y1hk= X-Google-Smtp-Source: ANB0VdZ6HELrsNm5XXrRkmNSecCGgU3PMx8+5I7kAtUBHXQWr9TDo4bnWlj/0iFtYmqXCs1LpF7rgw== X-Received: by 2002:a02:5651:: with SMTP id o78-v6mr16179775jab.8.1535819902147; Sat, 01 Sep 2018 09:38:22 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e140-v6sm4942154iof.50.2018.09.01.09.38.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Sep 2018 09:38:20 -0700 (PDT) In-Reply-To: <83h8ja395r.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 31 Aug 2018 17:25:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149948 Archived-At: Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca >> Date: Thu, 30 Aug 2018 23:14:53 -0400 >> >> This makes the "safety device" redundant, but with the after-change >> suppression added it doesn't do any harm; so if you insist, we can leave >> it in. I don't think it's a good idea to have such things cluttering up >> the source though. > > Not sure I follow this part: are you saying that we shouldn't protect > ourselves from overlay modification hooks that record a wrong buffer? Hmm, I'm not sure I follow you on this. As far as I can tell, it rather protects against a particular bug in the C code: calling modification hooks without calling prepare_to_modify_buffer. Once this is fixed, there is no need for it. Furthermore, the "protection" is somewhat dubious, since it also prevents running hooks in the correct buffer (i.e., this bug).