From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases
Date: Sat, 01 Sep 2018 12:38:19 -0400 [thread overview]
Message-ID: <87sh2tqikk.fsf@gmail.com> (raw)
In-Reply-To: <83h8ja395r.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 31 Aug 2018 17:25:36 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Noam Postavsky <npostavs@gmail.com>
>> Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca
>> Date: Thu, 30 Aug 2018 23:14:53 -0400
>>
>> This makes the "safety device" redundant, but with the after-change
>> suppression added it doesn't do any harm; so if you insist, we can leave
>> it in. I don't think it's a good idea to have such things cluttering up
>> the source though.
>
> Not sure I follow this part: are you saying that we shouldn't protect
> ourselves from overlay modification hooks that record a wrong buffer?
Hmm, I'm not sure I follow you on this. As far as I can tell, it rather
protects against a particular bug in the C code: calling modification
hooks without calling prepare_to_modify_buffer. Once this is fixed,
there is no need for it. Furthermore, the "protection" is somewhat
dubious, since it also prevents running hooks in the correct buffer
(i.e., this bug).
next prev parent reply other threads:[~2018-09-01 16:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 4:15 bug#30823: 25.3; modification-hooks of overlays are not run in some cases Ren Victor
2018-03-15 6:00 ` Eli Zaretskii
2018-03-15 7:29 ` Ren Victor
2018-03-31 13:51 ` Noam Postavsky
2018-08-17 20:52 ` Noam Postavsky
2018-08-18 6:49 ` Eli Zaretskii
2018-08-19 3:48 ` Stefan Monnier
2018-08-19 14:46 ` Eli Zaretskii
2018-08-19 15:43 ` Stefan Monnier
2018-08-19 16:13 ` Eli Zaretskii
2018-08-20 3:02 ` Richard Stallman
2018-08-20 16:37 ` Eli Zaretskii
2018-08-19 20:46 ` Stefan Monnier
2018-08-20 16:34 ` Eli Zaretskii
2018-08-23 12:13 ` Noam Postavsky
2018-08-23 13:57 ` Eli Zaretskii
2018-08-31 3:14 ` Noam Postavsky
2018-08-31 14:25 ` Eli Zaretskii
2018-09-01 16:38 ` Noam Postavsky [this message]
2018-09-11 11:59 ` Eli Zaretskii
2018-09-13 1:34 ` Noam Postavsky
2018-09-13 13:43 ` Eli Zaretskii
2018-09-14 12:03 ` Noam Postavsky
2018-09-15 9:23 ` Eli Zaretskii
2018-09-15 14:10 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh2tqikk.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30823@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=victorhge@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).