From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34939: Some minibuffer behaviour is annoying Date: Sun, 31 Mar 2019 23:29:11 +0300 Organization: LINKOV.NET Message-ID: <87sgv2pz3c.fsf@mail.linkov.net> References: <1879851553195601@myt3-2475c4d2af83.qloud-c.yandex.net> <87a7hasuz4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177328"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 34939@debbugs.gnu.org To: pinkanon pinkanon Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 31 22:31:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAh6o-000k0Q-6W for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 22:31:14 +0200 Original-Received: from localhost ([127.0.0.1]:53963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAh6n-0002fq-5l for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 16:31:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAh6g-0002fk-LP for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 16:31:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAh6d-0001Jo-5T for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 16:31:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAh6c-0001JX-B4 for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 16:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAh6c-0003nQ-0y for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 16:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2019 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34939 X-GNU-PR-Package: emacs Original-Received: via spool by 34939-submit@debbugs.gnu.org id=B34939.155406423514533 (code B ref 34939); Sun, 31 Mar 2019 20:31:01 +0000 Original-Received: (at 34939) by debbugs.gnu.org; 31 Mar 2019 20:30:35 +0000 Original-Received: from localhost ([127.0.0.1]:38517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAh6B-0003mK-3e for submit@debbugs.gnu.org; Sun, 31 Mar 2019 16:30:35 -0400 Original-Received: from eastern.maple.relay.mailchannels.net ([23.83.214.55]:4556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAh68-0003mB-Jx for 34939@debbugs.gnu.org; Sun, 31 Mar 2019 16:30:33 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 730C25E1B8E; Sun, 31 Mar 2019 20:30:30 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a74.g.dreamhost.com (100-96-6-76.trex.outbound.svc.cluster.local [100.96.6.76]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B69985E1B6F; Sun, 31 Mar 2019 20:30:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a74.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sun, 31 Mar 2019 20:30:30 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wide-Eyed-Fearful: 25de28ce6202afd9_1554064230134_1043169119 X-MC-Loop-Signature: 1554064230134:945011632 X-MC-Ingress-Time: 1554064230133 Original-Received: from pdx1-sub0-mail-a74.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTP id 5062A82D2E; Sun, 31 Mar 2019 13:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=tf1tkH6XP1elMfqh/pxulpAHeb0=; b= yIa2Dkp8fKkbvhfh6w1LTkAE+gFu57XtMSd77z7SSAMW9uSIXieRBQA6bX78zLAv ZG7uFgeWuJXlbK7NNULdpxre2K3uKEXlXP9OS00tsZbR2rmDWhmD0A0UDrXRQVBy +1+n2n5iB2fkR+DSpjj/ktN+z74L/P4UpnaSVlSYItU= Original-Received: from mail.jurta.org (m91-129-99-202.cust.tele2.ee [91.129.99.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTPSA id 0446A82D22; Sun, 31 Mar 2019 13:30:21 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a74 In-Reply-To: <87a7hasuz4.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 31 Mar 2019 22:49:51 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrledvgdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrvddtvdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdelledrvddtvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehpihhnkhgrnhhonhdrphhinhhkrghnohhnseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156988 Archived-At: >> (1) when I press backspace and the prompt is empty, minibuffer tells me >> "Text is read-only". You. Don't. Say. > > Messages in the echo area should not conceal the minibuffer. Period. > > There is a special function minibuffer-message for this purpose: There is another place where messages conceal the minibuffer: running a version-control command that asks for a branch name and typing TAB for completion runs a command to fetch branch names. Its output conceals the minibuffer when vc-command-messages is non-nil. Here is a fix: diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index edbb83f3df..c4b327a3f0 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -324,7 +324,8 @@ vc-do-command (apply 'start-file-process command (current-buffer) command squeezed)))) (when vc-command-messages - (message "Running in background: %s" full-command)) + (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (message "Running in background: %s" full-command))) ;; Get rid of the default message insertion, in case we don't ;; set a sentinel explicitly. (set-process-sentinel proc #'ignore) @@ -332,11 +333,13 @@ vc-do-command (setq status proc) (when vc-command-messages (vc-run-delayed - (let ((message-truncate-lines t)) + (let ((message-truncate-lines t) + (inhibit-message (eq (selected-window) (active-minibuffer-window)))) (message "Done in background: %s" full-command))))) ;; Run synchronously (when vc-command-messages - (message "Running in foreground: %s" full-command)) + (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (message "Running in foreground: %s" full-command))) (let ((buffer-undo-list t)) (setq status (apply 'process-file command nil t nil squeezed))) (when (and (not (eq t okstatus)) @@ -350,7 +353,8 @@ vc-do-command (if (integerp status) (format "status %d" status) status) full-command)) (when vc-command-messages - (message "Done (status=%d): %s" status full-command)))) + (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (message "Done (status=%d): %s" status full-command))))) (vc-run-delayed (run-hook-with-args 'vc-post-command-functions command file-or-list flags))