From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35981: [PATCH] Use ngettext in `count-lines-page' Date: Wed, 29 May 2019 12:41:42 +0100 Message-ID: <87sgsxfpxl.fsf@tcd.ie> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161197"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35981@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 29 13:42:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVwyF-000fpM-ER for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 May 2019 13:42:15 +0200 Original-Received: from localhost ([127.0.0.1]:52239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVwyE-0005A6-8u for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 May 2019 07:42:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVwy4-00058r-2M for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 07:42:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVwy3-0003gS-2Z for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 07:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44697) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVwy2-0003g0-H8 for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 07:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVwy2-00069c-EL for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 07:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 May 2019 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35981 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35981-submit@debbugs.gnu.org id=B35981.155913011323627 (code B ref 35981); Wed, 29 May 2019 11:42:02 +0000 Original-Received: (at 35981) by debbugs.gnu.org; 29 May 2019 11:41:53 +0000 Original-Received: from localhost ([127.0.0.1]:58238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVwxs-00068z-NR for submit@debbugs.gnu.org; Wed, 29 May 2019 07:41:52 -0400 Original-Received: from mail-ed1-f66.google.com ([209.85.208.66]:37180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVwxq-00068W-ND for 35981@debbugs.gnu.org; Wed, 29 May 2019 07:41:51 -0400 Original-Received: by mail-ed1-f66.google.com with SMTP id w37so3305191edw.4 for <35981@debbugs.gnu.org>; Wed, 29 May 2019 04:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cLkK43/SP90vPzgkFL2YqezuPfUUMpA+MfLSaJ4vcRo=; b=rZDLbeqa1/H3o8L2FyM98WDWPEsqotaHXUM22OiwxM2Ud9MuOmIB5FMstj8vqVPdhy FOHvymVZL2E327/wJ/eFHzHt1QL4JIm2/vJTCJJq2O1QpBBimz5Gp7uH0Td2J0PBs2DB KqMcAqRqxB0cxYIWHlNoCClegOml5X6h8n6SIUHAd2AJ2VaQE0VjyhApzmRBcQyPPNKH E2fdL70B9pCkFW53XhQtD68T2sbpX0FKs5NfrmV/J8zWXdt9a48ED8Lz9sJT/z0WybdC TBXcy3s0NdnEWKoHqA6QFy88e83+D4zU9PssNfqmN2ooe0AJCjWDC2xRBJrTc790SLjx +tdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cLkK43/SP90vPzgkFL2YqezuPfUUMpA+MfLSaJ4vcRo=; b=D5r7sjB6llVWW14tG3ZsbdFHFkLM01X2RCgbdbvur4HGCmBMPrzTdMXQSeDr2/EXpV R618ylKO3Jappr9KeIraf9DrmfiyY/bdzQypaeJbZKvvI5PE4pIq6Mdi4FokivJVsC7Z UoIruICWVN4vAVd37YFWGoHLibO6OD+qZnem21CtLofVO/m3eFJrYePrKN4mI0FuSJhY LUL4pWwt8eVEENZ7v7U5O9DRpu9RX37IlOsUT6hAR3YST1DwN/JeH0h/ufqR17yI5CRR /I4G776qzPi+rqIgkcwkssqfoDSFG1rVtbssUGArUJtrh3rE7412VQt79ooeBTzZaWOj AESA== X-Gm-Message-State: APjAAAVwEW3f/rK96FwGkFIyvC+cwgg5XchttuMNg7oBaT8UYxHcLj1c v74XiRXPzSdnGjwwoBdzoCFh5Q== X-Google-Smtp-Source: APXvYqzo+7MWgChkIGGPsZc7g4UMoVVbkyCjWP/LiwFFJ88ja/+3Bhun2ixPlFkEiBSzTfe/CxecYQ== X-Received: by 2002:aa7:c641:: with SMTP id z1mr135511911edr.142.1559130104812; Wed, 29 May 2019 04:41:44 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id a17sm4970240edt.63.2019.05.29.04.41.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 29 May 2019 04:41:43 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Wed, 29 May 2019 11:34:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159879 Archived-At: --=-=-= Content-Type: text/plain severity 35981 minor quit > From 93092aa18ca4348d14c3154a6ffbdfc535536cba Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Wed, 29 May 2019 11:27:22 +0200 > Subject: [PATCH] Use ngettext in `count-lines-page' > > * textmodes/page.el (count-lines-page): Use ngettext. > --- > lisp/textmodes/page.el | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lisp/textmodes/page.el b/lisp/textmodes/page.el > index 220ef2d7fd..1379880374 100644 > --- a/lisp/textmodes/page.el > +++ b/lisp/textmodes/page.el > @@ -142,7 +142,10 @@ count-lines-page > (setq total (count-lines beg end) > before (count-lines beg opoint) > after (count-lines opoint end)) > - (message "Page has %d lines (%d + %d)" total before after)))) > + (message "Page has %s (%d + %d)" > + (format-message (ngettext "%d line" "%d lines" total) total) > + before > + after)))) I don't think it's right to split the phrase into two parts "Page has" and "N lines" for i18n purposes. How about the following instead: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=page.diff diff --git a/lisp/textmodes/page.el b/lisp/textmodes/page.el index 220ef2d7fd..d7214f610f 100644 --- a/lisp/textmodes/page.el +++ b/lisp/textmodes/page.el @@ -142,7 +142,8 @@ count-lines-page (setq total (count-lines beg end) before (count-lines beg opoint) after (count-lines opoint end)) - (message "Page has %d lines (%d + %d)" total before after)))) + (let ((fmt (ngettext "Page has %d line" "Page has %d lines" total))) + (message "%s (%d + %d)" (format-message fmt total) before after))))) (defun what-page () "Print page and line number of point." --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=--