* bug#36212: [PATCH] make undo less enthusiastic
@ 2019-06-14 18:21 Alex Branham
2019-06-15 9:47 ` Mattias Engdegård
2019-06-21 8:54 ` Noam Postavsky
0 siblings, 2 replies; 4+ messages in thread
From: Alex Branham @ 2019-06-14 18:21 UTC (permalink / raw)
To: 36212
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
This is really minor, but I find it annoying that undo is so
enthusiastic in its messaging. This patch removes the exclamation mark,
which makes undo's messaging more similar to other functions messaging
(e.g. C-g, C-SPC, etc).
Alex
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-simple.el-undo-Make-message-less-enthusiastic.patch --]
[-- Type: text/x-patch, Size: 912 bytes --]
From 5165b92810a29ea409b0dd92179b3599112e1f4e Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 14 Jun 2019 10:00:29 -0500
Subject: [PATCH] * lisp/simple.el (undo): Make message less enthusiastic
---
lisp/simple.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/simple.el b/lisp/simple.el
index 5e9d13f9f8..d9f310b203 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -2530,7 +2530,7 @@ undo
;; so, ask the user whether she wants to skip the redo/undo pair.
(let ((equiv (gethash pending-undo-list undo-equiv-table)))
(or (eq (selected-window) (minibuffer-window))
- (setq message (format "%s%s!"
+ (setq message (format "%s%s"
(if (or undo-no-redo (not equiv))
"Undo" "Redo")
(if undo-in-region " in region" ""))))
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#36212: [PATCH] make undo less enthusiastic
2019-06-14 18:21 bug#36212: [PATCH] make undo less enthusiastic Alex Branham
@ 2019-06-15 9:47 ` Mattias Engdegård
2019-06-21 8:54 ` Noam Postavsky
1 sibling, 0 replies; 4+ messages in thread
From: Mattias Engdegård @ 2019-06-15 9:47 UTC (permalink / raw)
To: 36212, alex.branham
To show my support and appreciation for your attention to detail, please let me propose that the exclamation point be replaced by a full stop.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#36212: [PATCH] make undo less enthusiastic
2019-06-14 18:21 bug#36212: [PATCH] make undo less enthusiastic Alex Branham
2019-06-15 9:47 ` Mattias Engdegård
@ 2019-06-21 8:54 ` Noam Postavsky
2019-06-28 0:58 ` Alex Branham
1 sibling, 1 reply; 4+ messages in thread
From: Noam Postavsky @ 2019-06-21 8:54 UTC (permalink / raw)
To: Alex Branham; +Cc: 36212, Mattias Engdegård
severity 36212 wishlist
quit
Alex Branham <alex.branham@gmail.com> writes:
> This is really minor, but I find it annoying that undo is so
> enthusiastic in its messaging. This patch removes the exclamation mark,
> which makes undo's messaging more similar to other functions messaging
> (e.g. C-g, C-SPC, etc).
Mattias Engdegård <mattiase@acm.org> writes:
> To show my support and appreciation for your attention to detail,
> please let me propose that the exclamation point be replaced by a full
> stop.
Alex is right that no punctuation at all is more consistent with
existing messages though. How about we just go with that for now, and
put off the bike-shedding over punctuation policy for another time.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#36212: [PATCH] make undo less enthusiastic
2019-06-21 8:54 ` Noam Postavsky
@ 2019-06-28 0:58 ` Alex Branham
0 siblings, 0 replies; 4+ messages in thread
From: Alex Branham @ 2019-06-28 0:58 UTC (permalink / raw)
To: Noam Postavsky; +Cc: Mattias Engdegård, 36212-done
On Fri 21 Jun 2019 at 03:54, Noam Postavsky <npostavs@gmail.com> wrote:
> Alex is right that no punctuation at all is more consistent with
> existing messages though. How about we just go with that for now, and
> put off the bike-shedding over punctuation policy for another time.
Since no one seemed to hate this, I applied the patch as
cb182ce6f8d2fa6e1509252fecc2b0e504e36d63 on the master branch (Emacs
27.1).
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-28 0:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-14 18:21 bug#36212: [PATCH] make undo less enthusiastic Alex Branham
2019-06-15 9:47 ` Mattias Engdegård
2019-06-21 8:54 ` Noam Postavsky
2019-06-28 0:58 ` Alex Branham
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).