From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#36765: 27.0.50; gnus-group-split-setup should delay until Gnus has finished starting up Date: Fri, 26 Jul 2019 09:38:58 -0700 Message-ID: <87sgqseonx.fsf@ericabrahamsen.net> References: <87lfwq6i9u.fsf@ericabrahamsen.net> <87ef2g1xc1.fsf@mouse.gnus.org> <87d0i04mzf.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="91402"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 36765@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 26 18:40:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hr3GK-000NeX-1a for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 18:40:08 +0200 Original-Received: from localhost ([::1]:41758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr3GJ-0006Go-3Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 12:40:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52264) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr3GF-0006Gi-Mr for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hr3GE-0002Vn-L9 for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34448) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hr3GE-0002Vb-Ho for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hr3GE-00077S-8o; Fri, 26 Jul 2019 12:40:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87lfwq6i9u.fsf@ericabrahamsen.net> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 26 Jul 2019 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36765 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156415915427140 (code B ref -1); Fri, 26 Jul 2019 16:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jul 2019 16:39:14 +0000 Original-Received: from localhost ([127.0.0.1]:43268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr3FR-00073d-7F for submit@debbugs.gnu.org; Fri, 26 Jul 2019 12:39:14 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr3FP-00073R-Ff for submit@debbugs.gnu.org; Fri, 26 Jul 2019 12:39:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51905) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr3FO-0006Dx-Eg for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:39:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hr3FN-0001X6-Bv for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:39:10 -0400 Original-Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:56490 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hr3FN-0001Re-1Y for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:39:09 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hr3FI-000MZe-Lq for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 18:39:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:D1EhhdztKdVdnsxDOHH/xKFAPDU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163806 Archived-At: Eric Abrahamsen writes: > Lars Ingebrigtsen writes: > >> Eric Abrahamsen writes: >> >>> I think a simple solution would be to change the above to: >>> >>> (add-hook (if auto-update >>> 'nnmail-pre-get-new-mail-hook >>> 'gnus-started-hook) >>> 'gnus-group-split-update) >>> >>> Ie, if auto-update isn't passed, only run the update once, at start time. >> >> I think that makes sense -- if it doesn't have to be called from >> nnmail-pre-get-new-mail-hook; I'm not too familiar with that code. > > I think the idea is that if `auto-update' is nil, the update should only > happen once, at start-up time. If it's t, it should happen every time > before we check new mail (which will include start-up time, I think). > > Anyway, let me make sure this solves the user's error first. Okay, I've heard back from the user. I think the proper solution is: (add-hook (if auto-update 'gnus-get-top-new-news-hook 'gnus-read-newsrc-el-hook) #'gnus-group-split-update) The reasoning being: The original 'nnmail-pre-get-new-mail-hook runs for all mail backends *except* nnimap, so the update won't fire if the user only has nnimap backends. 'gnus-get-top-new-news-hook should do just as well. Originally I put the non-auto-update on the 'gnus-started-hook, but that means the update happens *after* the first check for mail, which isn't ideal. There's also the 'gnus-startup-hook, but that happens before the newsrc-hashtb is built, so we'd get the same error. 'gnus-read-newsrc-el-hook seems to be the only hook that runs after the hash table is built, but before new news is fetched. WDYT?