From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: spacibba@aol.com, 36861@debbugs.gnu.org
Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode
Date: Sun, 04 Aug 2019 01:31:59 +0300 [thread overview]
Message-ID: <87sgqhricg.fsf@mail.linkov.net> (raw)
In-Reply-To: <83zhksexvx.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Aug 2019 12:10:10 +0300")
>> >> (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
>> >> - (log-edit-setup-add-author . t)))
>> >> + (log-edit-setup-add-author . t)
>> >> + (display-fill-column-indicator-column . 78)
>> >> + (eval . (display-fill-column-indicator-mode))))
>> >
>> > This will cause an annoying message and prompt when editing Emacs
>> > sources with an Emacs which doesn't yet have
>> > display-fill-column-indicator-mode, right? Can we avoid that? I
>> > routinely need to work on the latest sources with an older Emacs.
>>
>> Shouldn't local-variables functions ignore undefined variables and commands?
>> Probably not, since such change won't help for older versions.
>
> Right, and we cannot summarily allow any variables a given Emacs
> doesn't know about, that'd we unsafe.
Actually by using the word "ignore" I meant to not set an unbound variable
(currently `hack-local-variables' defines and sets unbound variables).
But this is not backward-compatible change.
>> Then one way is to put such lines to the init file
>> to avoid typing `y' to confirm local variables
>> while using emacs-26 to commit emacs-27 changes:
>
> Rather than requiring users of older Emacsen to change their init
> files in such strange ways, which will/might be a problem when they
> upgrade to Emacs 27, why not expect users who want the early detection
> of long lines to turn on display-fill-column-indicator-mode in their
> init files? IOW, the solution that requires changes to one's init
> files goes both ways.
I don't understand why display-fill-column-indicator customization
should be more complicated than necessary? Why it requires adding
these lines:
(display-fill-column-indicator-column . 78)
(eval . (display-fill-column-indicator-mode))
when it should be enough to avoid eval by:
(display-fill-column-indicator-column . 78)
(display-fill-column-indicator . t)
Is it because the only purpose of display-fill-column-indicator-mode
is to set display-fill-column-indicator-character? But then why
display-fill-column-indicator-character is not nil by default?
This contradicts the docstring of display-fill-column-indicator-character
that says that the default is U+2502, but actually the default is nil.
I'm CC-ing the author of display-fill-column-indicator:
Could you please consider setting the default value of
display-fill-column-indicator-character? This could
simplify customization.
next prev parent reply other threads:[~2019-08-03 22:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 20:44 bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Juri Linkov
2019-07-30 21:21 ` Juri Linkov
2019-07-31 2:30 ` Eli Zaretskii
2019-07-31 20:49 ` Juri Linkov
2019-08-02 9:10 ` Eli Zaretskii
2019-08-03 22:31 ` Juri Linkov [this message]
2019-08-04 0:51 ` Ergus
2019-08-04 19:39 ` Juri Linkov
2019-08-04 20:30 ` Ergus
2019-08-06 14:59 ` Eli Zaretskii
2019-08-06 17:51 ` Ergus
2019-08-06 18:26 ` Eli Zaretskii
2019-08-06 19:25 ` Ergus
2019-08-07 14:42 ` Eli Zaretskii
2020-08-09 19:18 ` Lars Ingebrigtsen
2019-08-05 21:43 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgqhricg.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=36861@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).