From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38164: quit-restore-window doesn't restore point in man Date: Wed, 13 Nov 2019 23:29:10 +0200 Organization: LINKOV.NET Message-ID: <87sgmrjwih.fsf@mail.linkov.net> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87r3i9nped.fsf@gnus.org> <87wps1m7co.fsf@web.de> <87r22gbquk.fsf@mail.linkov.net> <875zjrzgoz.fsf_-_@mail.linkov.net> <02f0564a-baf3-b15c-bcc5-98d37f510d7a@gmx.at> <877e45ksaz.fsf@mail.linkov.net> <37ad920d-a8ca-8cc4-33c7-ecec4792eb61@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="263762"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 38164@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 13 22:52:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iV0Yg-0016L8-0r for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Nov 2019 22:52:14 +0100 Original-Received: from localhost ([::1]:51454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iV0Ye-0004gR-Q4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Nov 2019 16:52:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48492) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iV0XY-0003LB-PJ for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 16:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iV0XX-0006vJ-Ny for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 16:51:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51461) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iV0XX-0006uv-4n for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 16:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iV0XX-0007su-1u for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 16:51:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Nov 2019 21:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38164 X-GNU-PR-Package: emacs Original-Received: via spool by 38164-submit@debbugs.gnu.org id=B38164.157368181830227 (code B ref 38164); Wed, 13 Nov 2019 21:51:03 +0000 Original-Received: (at 38164) by debbugs.gnu.org; 13 Nov 2019 21:50:18 +0000 Original-Received: from localhost ([127.0.0.1]:60277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV0Wn-0007rT-S1 for submit@debbugs.gnu.org; Wed, 13 Nov 2019 16:50:18 -0500 Original-Received: from bongo.elm.relay.mailchannels.net ([23.83.212.21]:12793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV0Wm-0007rL-Tm for 38164@debbugs.gnu.org; Wed, 13 Nov 2019 16:50:17 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E16BE34136F; Wed, 13 Nov 2019 21:50:15 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a44.g.dreamhost.com (100-96-169-194.trex.outbound.svc.cluster.local [100.96.169.194]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 762AE34186D; Wed, 13 Nov 2019 21:50:15 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a44.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 13 Nov 2019 21:50:15 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Shrill-Absorbed: 0a127d7604ba8626_1573681815711_972327705 X-MC-Loop-Signature: 1573681815711:3390697648 X-MC-Ingress-Time: 1573681815711 Original-Received: from pdx1-sub0-mail-a44.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTP id DADA58521B; Wed, 13 Nov 2019 13:50:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=u6MO6YAa/ABGfSAsf6hJon+l8RY=; b= 1Xg2tnodvMxjf7GHrAZDhI+TGje9NUaUT36NtkHWYNk2foiy2Kk96iWy6vdnvRkK g+xuoaZi9Pbxfml9OCZ1qvKpiEp8zp3YBPYGhJtTfL5cxUllhvgW2InoiY5RftST Yin6qc1yGdB1DnV5Di48jqLgtRPUE9zv/skYJznrLOU= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTPSA id E500D85225; Wed, 13 Nov 2019 13:50:08 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a44 In-Reply-To: <37ad920d-a8ca-8cc4-33c7-ecec4792eb61@gmx.at> (martin rudalics's message of "Wed, 13 Nov 2019 09:04:12 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171512 Archived-At: >> @@ -1469,8 +1469,10 @@ Man-bgproc-sentinel >> >> (when delete-buff >> (if (window-live-p (get-buffer-window Man-buffer t)) >> - (quit-restore-window >> - (get-buffer-window Man-buffer t) 'kill) >> + (progn >> + (quit-restore-window >> + (get-buffer-window Man-buffer t) 'kill) >> + (select-window (old-selected-window))) >> (kill-buffer Man-buffer))) > > I'm completely lost now. Can you tell me in a detailed fashion what > goes wrong here? Is the window stored in (nth 2 quit-restore) the > wrong window right from the outset? Or is it in a sense falsified by > what happens later during minibuffer interaction? (progn (man "XYZ") (read-string "--> ")) 'read-string' activates the minibuffer, but asynchronous Man-bgproc-sentinel later calls 'quit-restore-window' that selects its previous window, ignoring the fact that now the selected window was in the minibuffer. So we need an exception for the case of active minibuffer.